[INFO] updating cached repository zero-frost/church-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zero-frost/church-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zero-frost/church-rs" "work/ex/clippy-test-run/sources/stable/gh/zero-frost/church-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zero-frost/church-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zero-frost/church-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zero-frost/church-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zero-frost/church-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6247f8c86a2f1457e7d27098701ca55c085142ff [INFO] sha for GitHub repo zero-frost/church-rs: 6247f8c86a2f1457e7d27098701ca55c085142ff [INFO] validating manifest of zero-frost/church-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zero-frost/church-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zero-frost/church-rs [INFO] finished frobbing zero-frost/church-rs [INFO] frobbed toml for zero-frost/church-rs written to work/ex/clippy-test-run/sources/stable/gh/zero-frost/church-rs/Cargo.toml [INFO] started frobbing zero-frost/church-rs [INFO] finished frobbing zero-frost/church-rs [INFO] frobbed toml for zero-frost/church-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zero-frost/church-rs/Cargo.toml [INFO] crate zero-frost/church-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zero-frost/church-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zero-frost/church-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5a0e0048dd32711d6f6cc14c5be3931f06e1be9c12275511f113bfcae2425bb [INFO] running `"docker" "start" "-a" "d5a0e0048dd32711d6f6cc14c5be3931f06e1be9c12275511f113bfcae2425bb"` [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking church v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 24 | ChurchIntParseError => "Failed to parse value into integer", [INFO] [stderr] | ------------------- matches any value [INFO] [stderr] 25 | ChurchBoolParseError => "Failed to parse value into boolean", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ unreachable pattern [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ChurchIntParseError` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ChurchIntParseError => "Failed to parse value into integer", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_ChurchIntParseError` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ChurchBoolParseError` [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | ChurchBoolParseError => "Failed to parse value into boolean", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_ChurchBoolParseError` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/main.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | Err(ret) => Err(ChurchParseError::ChurchIntParseError), [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 24 | ChurchIntParseError => "Failed to parse value into integer", [INFO] [stderr] | ------------------- matches any value [INFO] [stderr] 25 | ChurchBoolParseError => "Failed to parse value into boolean", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ unreachable pattern [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ChurchIntParseError` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ChurchIntParseError => "Failed to parse value into integer", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_ChurchIntParseError` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ChurchBoolParseError` [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | ChurchBoolParseError => "Failed to parse value into boolean", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_ChurchBoolParseError` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/main.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | Err(ret) => Err(ChurchParseError::ChurchIntParseError), [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] [INFO] [stderr] warning: variable `ChurchIntParseError` should have a snake case name such as `church_int_parse_error` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ChurchIntParseError => "Failed to parse value into integer", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `ChurchBoolParseError` should have a snake case name such as `church_bool_parse_error` [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | ChurchBoolParseError => "Failed to parse value into boolean", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &ChurchValue::Number(out) => out.to_string(), [INFO] [stderr] 66 | | &ChurchValue::Bool(out) => out.to_string(), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | ChurchValue::Number(out) => out.to_string(), [INFO] [stderr] 66 | ChurchValue::Bool(out) => out.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable `ChurchIntParseError` should have a snake case name such as `church_int_parse_error` [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | ChurchIntParseError => "Failed to parse value into integer", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `ChurchBoolParseError` should have a snake case name such as `church_bool_parse_error` [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | ChurchBoolParseError => "Failed to parse value into boolean", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &ChurchValue::Number(out) => out.to_string(), [INFO] [stderr] 66 | | &ChurchValue::Bool(out) => out.to_string(), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | ChurchValue::Number(out) => out.to_string(), [INFO] [stderr] 66 | ChurchValue::Bool(out) => out.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | std::io::stdin().read_line(&mut input).ok().expect("FAILED"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | std::io::stdin().read_line(&mut input).ok().expect("FAILED"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.27s [INFO] running `"docker" "inspect" "d5a0e0048dd32711d6f6cc14c5be3931f06e1be9c12275511f113bfcae2425bb"` [INFO] running `"docker" "rm" "-f" "d5a0e0048dd32711d6f6cc14c5be3931f06e1be9c12275511f113bfcae2425bb"` [INFO] [stdout] d5a0e0048dd32711d6f6cc14c5be3931f06e1be9c12275511f113bfcae2425bb