[INFO] updating cached repository zenria/pendu
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/zenria/pendu
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/zenria/pendu" "work/ex/clippy-test-run/sources/stable/gh/zenria/pendu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zenria/pendu'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/zenria/pendu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zenria/pendu"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zenria/pendu'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 17396ac8b1fc953e12ab7dfd06437f55d1490ebb
[INFO] sha for GitHub repo zenria/pendu: 17396ac8b1fc953e12ab7dfd06437f55d1490ebb
[INFO] validating manifest of zenria/pendu on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zenria/pendu on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zenria/pendu
[INFO] finished frobbing zenria/pendu
[INFO] frobbed toml for zenria/pendu written to work/ex/clippy-test-run/sources/stable/gh/zenria/pendu/Cargo.toml
[INFO] started frobbing zenria/pendu
[INFO] finished frobbing zenria/pendu
[INFO] frobbed toml for zenria/pendu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zenria/pendu/Cargo.toml
[INFO] crate zenria/pendu has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zenria/pendu against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zenria/pendu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b0c7323785e7e0d9f84eb00274d05144662c9b837cc320377a07752d5f71a17c
[INFO] running `"docker" "start" "-a" "b0c7323785e7e0d9f84eb00274d05144662c9b837cc320377a07752d5f71a17c"`
[INFO] [stderr]    Compiling semver-parser v0.7.0
[INFO] [stderr]    Compiling cc v1.0.25
[INFO] [stderr]    Compiling libc v0.2.44
[INFO] [stderr]    Compiling pkg-config v0.3.14
[INFO] [stderr]     Checking rand_xorshift v0.1.0
[INFO] [stderr]     Checking rand_isaac v0.1.0
[INFO] [stderr]     Checking rand_hc v0.1.0
[INFO] [stderr]    Compiling semver v0.9.0
[INFO] [stderr]    Compiling rustc_version v0.2.3
[INFO] [stderr]    Compiling ncurses v5.97.0
[INFO] [stderr]    Compiling rand_chacha v0.1.0
[INFO] [stderr]    Compiling rand_pcg v0.1.1
[INFO] [stderr]    Compiling rand v0.6.1
[INFO] [stderr]     Checking pendu v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return (max_x, max_y);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(max_x, max_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return (max_x, max_y);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(max_x, max_y)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/potence.rs:24:20
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn as_strs(&self) -> Vec<&str> {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/potence.rs:24:20
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn as_strs(&self) -> Vec<&str> {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lettre_a_trouver.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 |             found: c < 'A' as u8 || c > 'Z' as u8,
[INFO] [stderr]    |                        ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lettre_a_trouver.rs:37:41
[INFO] [stderr]    |
[INFO] [stderr] 37 |             found: c < 'A' as u8 || c > 'Z' as u8,
[INFO] [stderr]    |                                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |     fn new(mots: &Vec<&str>) -> Self {
[INFO] [stderr]    |                  ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/main.rs:74:33
[INFO] [stderr]    |
[INFO] [stderr] 74 |               .fold(0, |count, l| {
[INFO] [stderr]    |  _________________________________^
[INFO] [stderr] 75 | |                 // pour chaque lettre trouvée, on la marque comme tel, et on compte
[INFO] [stderr] 76 | |                 l.set_found();
[INFO] [stderr] 77 | |                 count + 1
[INFO] [stderr] 78 | |             })
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 | /             match self.potence.next() {
[INFO] [stderr] 83 | |                 // Quand on perd => on marque comme trouvées toutes les lettres, ainsi,
[INFO] [stderr] 84 | |                 // elles sont affichées au joueur !
[INFO] [stderr] 85 | |                 Some(Potence::Perdu) => self.a_trouver.iter_mut().for_each(|l| {
[INFO] [stderr] ...  |
[INFO] [stderr] 88 | |                 _ => (),
[INFO] [stderr] 89 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 82 |             if let Some(Potence::Perdu) = self.potence.next() { self.a_trouver.iter_mut().for_each(|l| {
[INFO] [stderr] 83 |     l.set_force_display();
[INFO] [stderr] 84 | }) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:141:53
[INFO] [stderr]     |
[INFO] [stderr] 141 |     let mots: Vec<&str> = mots.lines().filter(|mot| mot.len() > 0).collect();
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!mot.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lettre_a_trouver.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 |             found: c < 'A' as u8 || c > 'Z' as u8,
[INFO] [stderr]    |                        ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'A'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/lettre_a_trouver.rs:37:41
[INFO] [stderr]    |
[INFO] [stderr] 37 |             found: c < 'A' as u8 || c > 'Z' as u8,
[INFO] [stderr]    |                                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'Z'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |     fn new(mots: &Vec<&str>) -> Self {
[INFO] [stderr]    |                  ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/main.rs:74:33
[INFO] [stderr]    |
[INFO] [stderr] 74 |               .fold(0, |count, l| {
[INFO] [stderr]    |  _________________________________^
[INFO] [stderr] 75 | |                 // pour chaque lettre trouvée, on la marque comme tel, et on compte
[INFO] [stderr] 76 | |                 l.set_found();
[INFO] [stderr] 77 | |                 count + 1
[INFO] [stderr] 78 | |             })
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 | /             match self.potence.next() {
[INFO] [stderr] 83 | |                 // Quand on perd => on marque comme trouvées toutes les lettres, ainsi,
[INFO] [stderr] 84 | |                 // elles sont affichées au joueur !
[INFO] [stderr] 85 | |                 Some(Potence::Perdu) => self.a_trouver.iter_mut().for_each(|l| {
[INFO] [stderr] ...  |
[INFO] [stderr] 88 | |                 _ => (),
[INFO] [stderr] 89 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 82 |             if let Some(Potence::Perdu) = self.potence.next() { self.a_trouver.iter_mut().for_each(|l| {
[INFO] [stderr] 83 |     l.set_force_display();
[INFO] [stderr] 84 | }) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:141:53
[INFO] [stderr]     |
[INFO] [stderr] 141 |     let mots: Vec<&str> = mots.lines().filter(|mot| mot.len() > 0).collect();
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!mot.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 18.12s
[INFO] running `"docker" "inspect" "b0c7323785e7e0d9f84eb00274d05144662c9b837cc320377a07752d5f71a17c"`
[INFO] running `"docker" "rm" "-f" "b0c7323785e7e0d9f84eb00274d05144662c9b837cc320377a07752d5f71a17c"`
[INFO] [stdout] b0c7323785e7e0d9f84eb00274d05144662c9b837cc320377a07752d5f71a17c