[INFO] updating cached repository zeljic/sxmldiff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zeljic/sxmldiff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zeljic/sxmldiff" "work/ex/clippy-test-run/sources/stable/gh/zeljic/sxmldiff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zeljic/sxmldiff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zeljic/sxmldiff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zeljic/sxmldiff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zeljic/sxmldiff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d08115a300a1687a0ec2eab1391d98bd951cfc8 [INFO] sha for GitHub repo zeljic/sxmldiff: 2d08115a300a1687a0ec2eab1391d98bd951cfc8 [INFO] validating manifest of zeljic/sxmldiff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zeljic/sxmldiff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zeljic/sxmldiff [INFO] finished frobbing zeljic/sxmldiff [INFO] frobbed toml for zeljic/sxmldiff written to work/ex/clippy-test-run/sources/stable/gh/zeljic/sxmldiff/Cargo.toml [INFO] started frobbing zeljic/sxmldiff [INFO] finished frobbing zeljic/sxmldiff [INFO] frobbed toml for zeljic/sxmldiff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zeljic/sxmldiff/Cargo.toml [INFO] crate zeljic/sxmldiff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zeljic/sxmldiff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zeljic/sxmldiff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c7a4afbd086c21529058773ae8afede99ace89e3e066aaa343ad35ecf9fc4d5 [INFO] running `"docker" "start" "-a" "7c7a4afbd086c21529058773ae8afede99ace89e3e066aaa343ad35ecf9fc4d5"` [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking xml-rs v0.7.0 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking colored v1.6.1 [INFO] [stderr] Checking xmltree v0.8.0 [INFO] [stderr] Checking sxmldiff v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | fn print(&self, indent: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | fn print_end(&self, indent: &usize) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:107:34 [INFO] [stderr] | [INFO] [stderr] 107 | fn print_diff(&self, indent: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | fn print(&self, indent: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | fn print_end(&self, indent: &usize) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:107:34 [INFO] [stderr] | [INFO] [stderr] 107 | fn print_diff(&self, indent: &usize) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.86s [INFO] running `"docker" "inspect" "7c7a4afbd086c21529058773ae8afede99ace89e3e066aaa343ad35ecf9fc4d5"` [INFO] running `"docker" "rm" "-f" "7c7a4afbd086c21529058773ae8afede99ace89e3e066aaa343ad35ecf9fc4d5"` [INFO] [stdout] 7c7a4afbd086c21529058773ae8afede99ace89e3e066aaa343ad35ecf9fc4d5