[INFO] updating cached repository zekesonxx/regexfs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zekesonxx/regexfs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zekesonxx/regexfs" "work/ex/clippy-test-run/sources/stable/gh/zekesonxx/regexfs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zekesonxx/regexfs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zekesonxx/regexfs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zekesonxx/regexfs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zekesonxx/regexfs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bf6aa6118ca1e5e8b77a4ed6cc9d37147f8db1ea [INFO] sha for GitHub repo zekesonxx/regexfs: bf6aa6118ca1e5e8b77a4ed6cc9d37147f8db1ea [INFO] validating manifest of zekesonxx/regexfs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zekesonxx/regexfs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zekesonxx/regexfs [INFO] finished frobbing zekesonxx/regexfs [INFO] frobbed toml for zekesonxx/regexfs written to work/ex/clippy-test-run/sources/stable/gh/zekesonxx/regexfs/Cargo.toml [INFO] started frobbing zekesonxx/regexfs [INFO] finished frobbing zekesonxx/regexfs [INFO] frobbed toml for zekesonxx/regexfs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zekesonxx/regexfs/Cargo.toml [INFO] crate zekesonxx/regexfs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zekesonxx/regexfs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zekesonxx/regexfs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5aec48be65b4c5daf116e77e6c6e33812aae746d02a0d8733f9a4a27527cb140 [INFO] running `"docker" "start" "-a" "5aec48be65b4c5daf116e77e6c6e33812aae746d02a0d8733f9a4a27527cb140"` [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Compiling fuse v0.3.1 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking regexfs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `libc::ENOENT` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use libc::ENOENT; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `time::Timespec` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use time::Timespec; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `FileAttr`, `FileType`, `Filesystem`, `ReplyAttr`, `ReplyData`, `ReplyDirectory`, `ReplyEntry`, `Request` [INFO] [stderr] --> src/main.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | use fuse::{FileType, FileAttr, Filesystem, Request, ReplyData, ReplyEntry, ReplyAttr, ReplyDirectory}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/regexfs.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ReplyOpen` [INFO] [stderr] --> src/regexfs.rs:11:103 [INFO] [stderr] | [INFO] [stderr] 11 | use fuse::{FileType, FileAttr, Filesystem, Request, ReplyData, ReplyEntry, ReplyAttr, ReplyDirectory, ReplyOpen}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/regexfs.rs:16:47 [INFO] [stderr] | [INFO] [stderr] 16 | const CREATE_TIME: Timespec = Timespec { sec: 1381237736, nsec: 0 }; // 2013-10-08 08:56 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_381_237_736` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/regexfs.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | / if entry.metadata().unwrap().is_file() { [INFO] [stderr] 95 | | if self.regex.is_match(entry.file_name().to_string_lossy().as_ref()) { [INFO] [stderr] 96 | | entries.push((i, entry.file_name().to_string_lossy().to_string())); [INFO] [stderr] 97 | | i += 1; [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | if entry.metadata().unwrap().is_file() && self.regex.is_match(entry.file_name().to_string_lossy().as_ref()) { [INFO] [stderr] 95 | entries.push((i, entry.file_name().to_string_lossy().to_string())); [INFO] [stderr] 96 | i += 1; [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc::ENOENT` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use libc::ENOENT; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `time::Timespec` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use time::Timespec; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `FileAttr`, `FileType`, `Filesystem`, `ReplyAttr`, `ReplyData`, `ReplyDirectory`, `ReplyEntry`, `Request` [INFO] [stderr] --> src/main.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | use fuse::{FileType, FileAttr, Filesystem, Request, ReplyData, ReplyEntry, ReplyAttr, ReplyDirectory}; [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/regexfs.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ReplyOpen` [INFO] [stderr] --> src/regexfs.rs:11:103 [INFO] [stderr] | [INFO] [stderr] 11 | use fuse::{FileType, FileAttr, Filesystem, Request, ReplyData, ReplyEntry, ReplyAttr, ReplyDirectory, ReplyOpen}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/regexfs.rs:16:47 [INFO] [stderr] | [INFO] [stderr] 16 | const CREATE_TIME: Timespec = Timespec { sec: 1381237736, nsec: 0 }; // 2013-10-08 08:56 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_381_237_736` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/regexfs.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | / if entry.metadata().unwrap().is_file() { [INFO] [stderr] 95 | | if self.regex.is_match(entry.file_name().to_string_lossy().as_ref()) { [INFO] [stderr] 96 | | entries.push((i, entry.file_name().to_string_lossy().to_string())); [INFO] [stderr] 97 | | i += 1; [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | if entry.metadata().unwrap().is_file() && self.regex.is_match(entry.file_name().to_string_lossy().as_ref()) { [INFO] [stderr] 95 | entries.push((i, entry.file_name().to_string_lossy().to_string())); [INFO] [stderr] 96 | i += 1; [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut filesystem = regexfs::RegexFS::new(PathBuf::from(env::args_os().nth(1).unwrap()), env::args_os().nth(2).unwrap().to_string_lossy().as_ref()); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let mut filesystem = regexfs::RegexFS::new(PathBuf::from(env::args_os().nth(1).unwrap()), env::args_os().nth(2).unwrap().to_string_lossy().as_ref()); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/regexfs.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | // reply.attr(&TTL, &FileAttr { [INFO] [stderr] 132 | | // ino: ino, [INFO] [stderr] ... | [INFO] [stderr] 146 | | // }) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/regexfs.rs:127:54 [INFO] [stderr] | [INFO] [stderr] 127 | if ino as usize > self.entries.len() { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 128 | | //reply.error(ENOENT); [INFO] [stderr] 129 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/regexfs.rs:172:43 [INFO] [stderr] | [INFO] [stderr] 172 | for (i, entry) in (&self.entries).into_iter().enumerate().skip(to_skip) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `regexfs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/regexfs.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 130 | | [INFO] [stderr] 131 | | // reply.attr(&TTL, &FileAttr { [INFO] [stderr] 132 | | // ino: ino, [INFO] [stderr] ... | [INFO] [stderr] 146 | | // }) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/regexfs.rs:127:54 [INFO] [stderr] | [INFO] [stderr] 127 | if ino as usize > self.entries.len() { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 128 | | //reply.error(ENOENT); [INFO] [stderr] 129 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/regexfs.rs:172:43 [INFO] [stderr] | [INFO] [stderr] 172 | for (i, entry) in (&self.entries).into_iter().enumerate().skip(to_skip) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `regexfs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5aec48be65b4c5daf116e77e6c6e33812aae746d02a0d8733f9a4a27527cb140"` [INFO] running `"docker" "rm" "-f" "5aec48be65b4c5daf116e77e6c6e33812aae746d02a0d8733f9a4a27527cb140"` [INFO] [stdout] 5aec48be65b4c5daf116e77e6c6e33812aae746d02a0d8733f9a4a27527cb140