[INFO] updating cached repository zaynetro/roller [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zaynetro/roller [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zaynetro/roller" "work/ex/clippy-test-run/sources/stable/gh/zaynetro/roller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zaynetro/roller'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zaynetro/roller" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaynetro/roller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaynetro/roller'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0dac7c1b7e81ae71a50b746fdbdab7f632ae4b39 [INFO] sha for GitHub repo zaynetro/roller: 0dac7c1b7e81ae71a50b746fdbdab7f632ae4b39 [INFO] validating manifest of zaynetro/roller on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zaynetro/roller on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zaynetro/roller [INFO] finished frobbing zaynetro/roller [INFO] frobbed toml for zaynetro/roller written to work/ex/clippy-test-run/sources/stable/gh/zaynetro/roller/Cargo.toml [INFO] started frobbing zaynetro/roller [INFO] finished frobbing zaynetro/roller [INFO] frobbed toml for zaynetro/roller written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaynetro/roller/Cargo.toml [INFO] crate zaynetro/roller has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zaynetro/roller against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zaynetro/roller:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b73aac5244f9e2d1acaa12f064ec359983c5e4449f81bfa99a413746d1719414 [INFO] running `"docker" "start" "-a" "b73aac5244f9e2d1acaa12f064ec359983c5e4449f81bfa99a413746d1719414"` [INFO] [stderr] Checking libc v0.2.29 [INFO] [stderr] Checking lazy_static v0.2.8 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Checking regex-syntax v0.4.1 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking log v0.3.8 [INFO] [stderr] Checking num-traits v0.1.40 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking itoa v0.3.3 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking serde v1.0.14 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking scheduled-thread-pool v0.1.0 [INFO] [stderr] Checking lz4-compress v0.1.0 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Compiling serde_derive_internals v0.16.0 [INFO] [stderr] Checking snap v0.2.2 [INFO] [stderr] Checking r2d2 v0.7.3 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.14 [INFO] [stderr] Checking cdrs v1.0.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking config v0.7.0 [INFO] [stderr] Checking roller v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/migration.rs:240:41 [INFO] [stderr] | [INFO] [stderr] 240 | let authored_at = Timespec::new(1503223035, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_503_223_035` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/client.rs:212:44 [INFO] [stderr] | [INFO] [stderr] 212 | authored_at: Timespec::new(1503833798, 0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_503_833_798` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader.rs:21:47 [INFO] [stderr] | [INFO] [stderr] 21 | let folder = path.components().nth(1).ok_or(format!( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 22 | | "Could not find keyspace folder name from {}", [INFO] [stderr] 23 | | path.display() [INFO] [stderr] 24 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | let folder = path.components().nth(1).ok_or_else(|| format!( [INFO] [stderr] 22 | "Could not find keyspace folder name from {}", [INFO] [stderr] 23 | path.display() [INFO] [stderr] 24 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | .ok_or(format!("Couldn't make string out of {:?}", keyspace)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't make string out of {:?}", keyspace))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/client.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | let ref applied = applied_vec[0]; [INFO] [stderr] | ----^^^^^^^^^^^------------------ help: try: `let applied = &applied_vec[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader.rs:21:47 [INFO] [stderr] | [INFO] [stderr] 21 | let folder = path.components().nth(1).ok_or(format!( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 22 | | "Could not find keyspace folder name from {}", [INFO] [stderr] 23 | | path.display() [INFO] [stderr] 24 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | let folder = path.components().nth(1).ok_or_else(|| format!( [INFO] [stderr] 22 | "Could not find keyspace folder name from {}", [INFO] [stderr] 23 | path.display() [INFO] [stderr] 24 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/reader.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | .ok_or(format!("Couldn't make string out of {:?}", keyspace)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Couldn't make string out of {:?}", keyspace))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/reader.rs:62:26 [INFO] [stderr] | [INFO] [stderr] 62 | let migrations = migrations_map.get("one").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&migrations_map["one"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.61s [INFO] running `"docker" "inspect" "b73aac5244f9e2d1acaa12f064ec359983c5e4449f81bfa99a413746d1719414"` [INFO] running `"docker" "rm" "-f" "b73aac5244f9e2d1acaa12f064ec359983c5e4449f81bfa99a413746d1719414"` [INFO] [stdout] b73aac5244f9e2d1acaa12f064ec359983c5e4449f81bfa99a413746d1719414