[INFO] updating cached repository zaubermaerchen/rupick
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/zaubermaerchen/rupick
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/zaubermaerchen/rupick" "work/ex/clippy-test-run/sources/stable/gh/zaubermaerchen/rupick"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zaubermaerchen/rupick'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/zaubermaerchen/rupick" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaubermaerchen/rupick"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaubermaerchen/rupick'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6268c0582011694b95d1b839df8b6b2d5c64ffad
[INFO] sha for GitHub repo zaubermaerchen/rupick: 6268c0582011694b95d1b839df8b6b2d5c64ffad
[INFO] validating manifest of zaubermaerchen/rupick on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zaubermaerchen/rupick on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zaubermaerchen/rupick
[INFO] finished frobbing zaubermaerchen/rupick
[INFO] frobbed toml for zaubermaerchen/rupick written to work/ex/clippy-test-run/sources/stable/gh/zaubermaerchen/rupick/Cargo.toml
[INFO] started frobbing zaubermaerchen/rupick
[INFO] finished frobbing zaubermaerchen/rupick
[INFO] frobbed toml for zaubermaerchen/rupick written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaubermaerchen/rupick/Cargo.toml
[INFO] crate zaubermaerchen/rupick has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zaubermaerchen/rupick against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zaubermaerchen/rupick:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a8ec7a08ee1457c44d673c9695a2df58f6a8ee45da7a3c583e77d37159fd4533
[INFO] running `"docker" "start" "-a" "a8ec7a08ee1457c44d673c9695a2df58f6a8ee45da7a3c583e77d37159fd4533"`
[INFO] [stderr]     Checking libc v0.2.22
[INFO] [stderr]     Checking argparse v0.2.1
[INFO] [stderr]     Checking rand v0.3.15
[INFO] [stderr]     Checking rupick v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return Ok(items);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(items)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return Ok(items);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(items)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let items = match if filepath.len() > 0 { read_from_file(filepath.as_str()) } 
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!filepath.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:64:8
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if items.len() == 0 || n == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:74:8
[INFO] [stderr]    |
[INFO] [stderr] 74 |     if items.len() == 0 || n == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return Ok(items);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(items)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     return Ok(items);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(items)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 |     let items = match if filepath.len() > 0 { read_from_file(filepath.as_str()) } 
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!filepath.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:64:8
[INFO] [stderr]    |
[INFO] [stderr] 64 |     if items.len() == 0 || n == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:74:8
[INFO] [stderr]    |
[INFO] [stderr] 74 |     if items.len() == 0 || n == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.79s
[INFO] running `"docker" "inspect" "a8ec7a08ee1457c44d673c9695a2df58f6a8ee45da7a3c583e77d37159fd4533"`
[INFO] running `"docker" "rm" "-f" "a8ec7a08ee1457c44d673c9695a2df58f6a8ee45da7a3c583e77d37159fd4533"`
[INFO] [stdout] a8ec7a08ee1457c44d673c9695a2df58f6a8ee45da7a3c583e77d37159fd4533