[INFO] updating cached repository zargony/synacor-challenge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zargony/synacor-challenge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zargony/synacor-challenge" "work/ex/clippy-test-run/sources/stable/gh/zargony/synacor-challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zargony/synacor-challenge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zargony/synacor-challenge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zargony/synacor-challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zargony/synacor-challenge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07b7a31e7ad31202e31007eac05fe6173bf7ff60 [INFO] sha for GitHub repo zargony/synacor-challenge: 07b7a31e7ad31202e31007eac05fe6173bf7ff60 [INFO] validating manifest of zargony/synacor-challenge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zargony/synacor-challenge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zargony/synacor-challenge [INFO] finished frobbing zargony/synacor-challenge [INFO] frobbed toml for zargony/synacor-challenge written to work/ex/clippy-test-run/sources/stable/gh/zargony/synacor-challenge/Cargo.toml [INFO] started frobbing zargony/synacor-challenge [INFO] finished frobbing zargony/synacor-challenge [INFO] frobbed toml for zargony/synacor-challenge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zargony/synacor-challenge/Cargo.toml [INFO] crate zargony/synacor-challenge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zargony/synacor-challenge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zargony/synacor-challenge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f542523fa2ab90ffba838364884f5aa84e834fb78c54218ed0771ee4452dce90 [INFO] running `"docker" "start" "-a" "f542523fa2ab90ffba838364884f5aa84e834fb78c54218ed0771ee4452dce90"` [INFO] [stderr] Checking libc v0.2.17 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking log v0.3.6 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking synacor-challenge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | Pointer { mem: mem, addr: addr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | Pointer { mem: mem, addr: addr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm.rs:256:14 [INFO] [stderr] | [INFO] [stderr] 256 | VM { mem: mem, reg: [0; 8], stack: Vec::new(), ip: 0, halted: false } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | Pointer { mem: mem, addr: addr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | Pointer { mem: mem, addr: addr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm.rs:256:14 [INFO] [stderr] | [INFO] [stderr] 256 | VM { mem: mem, reg: [0; 8], stack: Vec::new(), ip: 0, halted: false } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `jump` [INFO] [stderr] --> src/memory.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn jump(&mut self, addr: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `addr` is only used to index `mem`. [INFO] [stderr] --> src/memory.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | for addr in 0.. { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 59 | for in &mut mem { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:62:49 [INFO] [stderr] | [INFO] [stderr] 62 | Some(Ok(hb)) => mem[addr] = (hb as u16) << 8 | (lb as u16), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:62:68 [INFO] [stderr] | [INFO] [stderr] 62 | Some(Ok(hb)) => mem[addr] = (hb as u16) << 8 | (lb as u16), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/vm.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | / match b.get(vm) == c.get(vm) { [INFO] [stderr] 130 | | false => a.set(vm, 0), [INFO] [stderr] 131 | | true => a.set(vm, 1), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if b.get(vm) == c.get(vm) { a.set(vm, 1) } else { a.set(vm, 0) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/vm.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | / match b.get(vm) > c.get(vm) { [INFO] [stderr] 136 | | false => a.set(vm, 0), [INFO] [stderr] 137 | | true => a.set(vm, 1), [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if b.get(vm) > c.get(vm) { a.set(vm, 1) } else { a.set(vm, 0) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | let val = ((b.get(vm) as u32 * c.get(vm) as u32) % 0x8000) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(b.get(vm))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:158:48 [INFO] [stderr] | [INFO] [stderr] 158 | let val = ((b.get(vm) as u32 * c.get(vm) as u32) % 0x8000) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(c.get(vm))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:202:47 [INFO] [stderr] | [INFO] [stderr] 202 | Some(Ok(ch)) => a.set(vm, ch as u16), [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:217:53 [INFO] [stderr] | [INFO] [stderr] 217 | 2 => FromPointer::from_pointer(ptr).map(|a| Instruction::Push(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Push` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:218:53 [INFO] [stderr] | [INFO] [stderr] 218 | 3 => FromPointer::from_pointer(ptr).map(|a| Instruction::Pop(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Pop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:221:53 [INFO] [stderr] | [INFO] [stderr] 221 | 6 => FromPointer::from_pointer(ptr).map(|a| Instruction::Jmp(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Jmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:232:54 [INFO] [stderr] | [INFO] [stderr] 232 | 17 => FromPointer::from_pointer(ptr).map(|a| Instruction::Call(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Call` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:234:54 [INFO] [stderr] | [INFO] [stderr] 234 | 19 => FromPointer::from_pointer(ptr).map(|a| Instruction::Out(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:235:54 [INFO] [stderr] | [INFO] [stderr] 235 | 20 => FromPointer::from_pointer(ptr).map(|a| Instruction::In(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::In` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the loop variable `addr` is only used to index `mem`. [INFO] [stderr] --> src/memory.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | for addr in 0.. { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 59 | for in &mut mem { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:62:49 [INFO] [stderr] | [INFO] [stderr] 62 | Some(Ok(hb)) => mem[addr] = (hb as u16) << 8 | (lb as u16), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hb)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:62:68 [INFO] [stderr] | [INFO] [stderr] 62 | Some(Ok(hb)) => mem[addr] = (hb as u16) << 8 | (lb as u16), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/vm.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | / match b.get(vm) == c.get(vm) { [INFO] [stderr] 130 | | false => a.set(vm, 0), [INFO] [stderr] 131 | | true => a.set(vm, 1), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if b.get(vm) == c.get(vm) { a.set(vm, 1) } else { a.set(vm, 0) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/vm.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | / match b.get(vm) > c.get(vm) { [INFO] [stderr] 136 | | false => a.set(vm, 0), [INFO] [stderr] 137 | | true => a.set(vm, 1), [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if b.get(vm) > c.get(vm) { a.set(vm, 1) } else { a.set(vm, 0) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | let val = ((b.get(vm) as u32 * c.get(vm) as u32) % 0x8000) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(b.get(vm))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:158:48 [INFO] [stderr] | [INFO] [stderr] 158 | let val = ((b.get(vm) as u32 * c.get(vm) as u32) % 0x8000) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(c.get(vm))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:202:47 [INFO] [stderr] | [INFO] [stderr] 202 | Some(Ok(ch)) => a.set(vm, ch as u16), [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:217:53 [INFO] [stderr] | [INFO] [stderr] 217 | 2 => FromPointer::from_pointer(ptr).map(|a| Instruction::Push(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Push` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:218:53 [INFO] [stderr] | [INFO] [stderr] 218 | 3 => FromPointer::from_pointer(ptr).map(|a| Instruction::Pop(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Pop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:221:53 [INFO] [stderr] | [INFO] [stderr] 221 | 6 => FromPointer::from_pointer(ptr).map(|a| Instruction::Jmp(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Jmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:232:54 [INFO] [stderr] | [INFO] [stderr] 232 | 17 => FromPointer::from_pointer(ptr).map(|a| Instruction::Call(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Call` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:234:54 [INFO] [stderr] | [INFO] [stderr] 234 | 19 => FromPointer::from_pointer(ptr).map(|a| Instruction::Out(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::Out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/vm.rs:235:54 [INFO] [stderr] | [INFO] [stderr] 235 | 20 => FromPointer::from_pointer(ptr).map(|a| Instruction::In(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::In` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.23s [INFO] running `"docker" "inspect" "f542523fa2ab90ffba838364884f5aa84e834fb78c54218ed0771ee4452dce90"` [INFO] running `"docker" "rm" "-f" "f542523fa2ab90ffba838364884f5aa84e834fb78c54218ed0771ee4452dce90"` [INFO] [stdout] f542523fa2ab90ffba838364884f5aa84e834fb78c54218ed0771ee4452dce90