[INFO] updating cached repository zaneli/rust-protobuf-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zaneli/rust-protobuf-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zaneli/rust-protobuf-example" "work/ex/clippy-test-run/sources/stable/gh/zaneli/rust-protobuf-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zaneli/rust-protobuf-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zaneli/rust-protobuf-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaneli/rust-protobuf-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaneli/rust-protobuf-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b76223bdf373ca0ec7374b4b4eb2e54f9758d51 [INFO] sha for GitHub repo zaneli/rust-protobuf-example: 5b76223bdf373ca0ec7374b4b4eb2e54f9758d51 [INFO] validating manifest of zaneli/rust-protobuf-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zaneli/rust-protobuf-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zaneli/rust-protobuf-example [INFO] finished frobbing zaneli/rust-protobuf-example [INFO] frobbed toml for zaneli/rust-protobuf-example written to work/ex/clippy-test-run/sources/stable/gh/zaneli/rust-protobuf-example/Cargo.toml [INFO] started frobbing zaneli/rust-protobuf-example [INFO] finished frobbing zaneli/rust-protobuf-example [INFO] frobbed toml for zaneli/rust-protobuf-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zaneli/rust-protobuf-example/Cargo.toml [INFO] crate zaneli/rust-protobuf-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zaneli/rust-protobuf-example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zaneli/rust-protobuf-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ce5b8690b5c3682723319a32ed49e873a7c4fba7f6964e88d614a7d15924ece [INFO] running `"docker" "start" "-a" "6ce5b8690b5c3682723319a32ed49e873a7c4fba7f6964e88d614a7d15924ece"` [INFO] [stderr] Checking protobuf v1.0.24 [INFO] [stderr] Checking rust-protobuf-example v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/addressbook.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/addressbook.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/addressbook.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | / (format!("Unexpected module name: {}. (expected \ [INFO] [stderr] 31 | | 'add_person' or 'list_people')", [INFO] [stderr] 32 | | other)))) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 30 | format!("Unexpected module name: {}. (expected \ [INFO] [stderr] 31 | 'add_person' or 'list_people')", [INFO] [stderr] 32 | other))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/addressbook.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | / (format!("Unexpected module name: {}. (expected \ [INFO] [stderr] 31 | | 'add_person' or 'list_people')", [INFO] [stderr] 32 | | other)))) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 30 | format!("Unexpected module name: {}. (expected \ [INFO] [stderr] 31 | 'add_person' or 'list_people')", [INFO] [stderr] 32 | other))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `stderr().write_fmt(...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/main.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | stderr().write_fmt(format_args!("{}\n", e)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | fn get_module_name(args: &Vec) -> Result ProtobufResult<()>, io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | fn get_file_path(args: &Vec) -> Result<&str, io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `stderr().write_fmt(...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/main.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | stderr().write_fmt(format_args!("{}\n", e)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | fn get_module_name(args: &Vec) -> Result ProtobufResult<()>, io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | fn get_file_path(args: &Vec) -> Result<&str, io::Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.84s [INFO] running `"docker" "inspect" "6ce5b8690b5c3682723319a32ed49e873a7c4fba7f6964e88d614a7d15924ece"` [INFO] running `"docker" "rm" "-f" "6ce5b8690b5c3682723319a32ed49e873a7c4fba7f6964e88d614a7d15924ece"` [INFO] [stdout] 6ce5b8690b5c3682723319a32ed49e873a7c4fba7f6964e88d614a7d15924ece