[INFO] updating cached repository zahidkhawaja/User-Registration [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zahidkhawaja/User-Registration [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zahidkhawaja/User-Registration" "work/ex/clippy-test-run/sources/stable/gh/zahidkhawaja/User-Registration"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zahidkhawaja/User-Registration'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zahidkhawaja/User-Registration" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zahidkhawaja/User-Registration"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zahidkhawaja/User-Registration'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] baed4ecd38885a0a0b96f47e1c2a8f4502acf191 [INFO] sha for GitHub repo zahidkhawaja/User-Registration: baed4ecd38885a0a0b96f47e1c2a8f4502acf191 [INFO] validating manifest of zahidkhawaja/User-Registration on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zahidkhawaja/User-Registration on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zahidkhawaja/User-Registration [INFO] finished frobbing zahidkhawaja/User-Registration [INFO] frobbed toml for zahidkhawaja/User-Registration written to work/ex/clippy-test-run/sources/stable/gh/zahidkhawaja/User-Registration/Cargo.toml [INFO] started frobbing zahidkhawaja/User-Registration [INFO] finished frobbing zahidkhawaja/User-Registration [INFO] frobbed toml for zahidkhawaja/User-Registration written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zahidkhawaja/User-Registration/Cargo.toml [INFO] crate zahidkhawaja/User-Registration has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zahidkhawaja/User-Registration against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zahidkhawaja/User-Registration:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5f953f5fffd2eead17785c09cc875a6da7050296a03ff20e01391ee786336ce [INFO] running `"docker" "start" "-a" "a5f953f5fffd2eead17785c09cc875a6da7050296a03ff20e01391ee786336ce"` [INFO] [stderr] Checking user_registration v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | self.email.contains("@") && self.email.len() >= 3 && self.email.len() <= 254 [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:23:36 [INFO] [stderr] | [INFO] [stderr] 23 | if user1.acceptable_email() && user1.acceptable_password() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `user1.acceptable_password()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | } else if user1.acceptable_email() == true && user1.acceptable_password() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `user1.acceptable_email()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | } else if user1.acceptable_email() == true && user1.acceptable_password() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!user1.acceptable_password()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | } else if user1.acceptable_email() == false && user1.acceptable_password() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!user1.acceptable_email()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:27:52 [INFO] [stderr] | [INFO] [stderr] 27 | } else if user1.acceptable_email() == false && user1.acceptable_password() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `user1.acceptable_password()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | self.email.contains("@") && self.email.len() >= 3 && self.email.len() <= 254 [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:23:36 [INFO] [stderr] | [INFO] [stderr] 23 | if user1.acceptable_email() && user1.acceptable_password() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `user1.acceptable_password()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | } else if user1.acceptable_email() == true && user1.acceptable_password() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `user1.acceptable_email()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | } else if user1.acceptable_email() == true && user1.acceptable_password() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!user1.acceptable_password()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | } else if user1.acceptable_email() == false && user1.acceptable_password() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!user1.acceptable_email()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:27:52 [INFO] [stderr] | [INFO] [stderr] 27 | } else if user1.acceptable_email() == false && user1.acceptable_password() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `user1.acceptable_password()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "a5f953f5fffd2eead17785c09cc875a6da7050296a03ff20e01391ee786336ce"` [INFO] running `"docker" "rm" "-f" "a5f953f5fffd2eead17785c09cc875a6da7050296a03ff20e01391ee786336ce"` [INFO] [stdout] a5f953f5fffd2eead17785c09cc875a6da7050296a03ff20e01391ee786336ce