[INFO] updating cached repository zackmdavis/Statusgitian [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zackmdavis/Statusgitian [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zackmdavis/Statusgitian" "work/ex/clippy-test-run/sources/stable/gh/zackmdavis/Statusgitian"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zackmdavis/Statusgitian'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zackmdavis/Statusgitian" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zackmdavis/Statusgitian"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zackmdavis/Statusgitian'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dce4a75528ed5cf8b4c7846b09fcf842b6e86fce [INFO] sha for GitHub repo zackmdavis/Statusgitian: dce4a75528ed5cf8b4c7846b09fcf842b6e86fce [INFO] validating manifest of zackmdavis/Statusgitian on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zackmdavis/Statusgitian on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zackmdavis/Statusgitian [INFO] finished frobbing zackmdavis/Statusgitian [INFO] frobbed toml for zackmdavis/Statusgitian written to work/ex/clippy-test-run/sources/stable/gh/zackmdavis/Statusgitian/Cargo.toml [INFO] started frobbing zackmdavis/Statusgitian [INFO] finished frobbing zackmdavis/Statusgitian [INFO] frobbed toml for zackmdavis/Statusgitian written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zackmdavis/Statusgitian/Cargo.toml [INFO] crate zackmdavis/Statusgitian has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zackmdavis/Statusgitian against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/zackmdavis/Statusgitian:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 884a4f236c452ab8c3b2013bf04abf251c6544e5f2d59126f647add9a041ec3e [INFO] running `"docker" "start" "-a" "884a4f236c452ab8c3b2013bf04abf251c6544e5f2d59126f647add9a041ec3e"` [INFO] [stderr] Compiling cc v1.0.12 [INFO] [stderr] Compiling pkg-config v0.3.11 [INFO] [stderr] Checking matches v0.1.6 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking byteorder v1.2.2 [INFO] [stderr] Checking encode_unicode v0.3.1 [INFO] [stderr] Checking openssl-probe v0.1.2 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking bitflags v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking term v0.4.6 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking atty v0.2.9 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Compiling cmake v0.1.30 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling curl-sys v0.4.2 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.1 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking git2 v0.7.1 [INFO] [stderr] Checking statusgitian v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:43:43 [INFO] [stderr] | [INFO] [stderr] 43 | let counts = self.0.entry(author).or_insert(Counts::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Counts::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:43:43 [INFO] [stderr] | [INFO] [stderr] 43 | let counts = self.0.entry(author).or_insert(Counts::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Counts::default)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 51s [INFO] running `"docker" "inspect" "884a4f236c452ab8c3b2013bf04abf251c6544e5f2d59126f647add9a041ec3e"` [INFO] running `"docker" "rm" "-f" "884a4f236c452ab8c3b2013bf04abf251c6544e5f2d59126f647add9a041ec3e"` [INFO] [stdout] 884a4f236c452ab8c3b2013bf04abf251c6544e5f2d59126f647add9a041ec3e