[INFO] updating cached repository ywzjackal/axtix-web-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ywzjackal/axtix-web-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ywzjackal/axtix-web-test" "work/ex/clippy-test-run/sources/stable/gh/ywzjackal/axtix-web-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ywzjackal/axtix-web-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ywzjackal/axtix-web-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ywzjackal/axtix-web-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ywzjackal/axtix-web-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ae05113b2d95864a8b50efa25964ea9a5201efb [INFO] sha for GitHub repo ywzjackal/axtix-web-test: 9ae05113b2d95864a8b50efa25964ea9a5201efb [INFO] validating manifest of ywzjackal/axtix-web-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ywzjackal/axtix-web-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ywzjackal/axtix-web-test [INFO] finished frobbing ywzjackal/axtix-web-test [INFO] frobbed toml for ywzjackal/axtix-web-test written to work/ex/clippy-test-run/sources/stable/gh/ywzjackal/axtix-web-test/Cargo.toml [INFO] started frobbing ywzjackal/axtix-web-test [INFO] finished frobbing ywzjackal/axtix-web-test [INFO] frobbed toml for ywzjackal/axtix-web-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ywzjackal/axtix-web-test/Cargo.toml [INFO] crate ywzjackal/axtix-web-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ywzjackal/axtix-web-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ywzjackal/axtix-web-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0990356f04d624c4c27ee085d6b2e49c2cf00deda5eef7a69835a4ad3ff5446c [INFO] running `"docker" "start" "-a" "0990356f04d624c4c27ee085d6b2e49c2cf00deda5eef7a69835a4ad3ff5446c"` [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling cc v1.0.17 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking lazy_static v1.0.1 [INFO] [stderr] Compiling cfg-if v0.1.3 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling version_check v0.1.3 [INFO] [stderr] Checking futures v0.1.21 [INFO] [stderr] Compiling serde v1.0.66 [INFO] [stderr] Checking lazycell v0.6.0 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling rustc-demangle v0.1.8 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling pulldown-cmark v0.1.2 [INFO] [stderr] Compiling itoa v0.4.1 [INFO] [stderr] Checking matches v0.1.6 [INFO] [stderr] Compiling same-file v1.0.2 [INFO] [stderr] Compiling remove_dir_all v0.5.1 [INFO] [stderr] Checking unicode-normalization v0.1.7 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking stable_deref_trait v1.0.0 [INFO] [stderr] Compiling bytecount v0.3.1 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Checking smallvec v0.6.1 [INFO] [stderr] Compiling gcc v0.3.54 [INFO] [stderr] Checking siphasher v0.2.2 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling regex v1.0.0 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Checking untrusted v0.5.1 [INFO] [stderr] Checking string v0.1.0 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking indexmap v1.0.1 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking httparse v1.2.4 [INFO] [stderr] Checking http-range v0.1.1 [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Compiling proc-macro2 v0.4.6 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Compiling arrayvec v0.4.7 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Compiling unicase v2.1.0 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Compiling actix-web v0.6.10 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking hostname v0.1.5 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling walkdir v2.1.4 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking regex-syntax v0.6.0 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking base64 v0.9.2 [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Checking bytes v0.4.8 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking resolv-conf v0.6.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking tokio-timer v0.2.3 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking http v0.1.5 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Checking phf_shared v0.7.22 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking mime v0.3.7 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Compiling backtrace v0.3.8 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Compiling serde_json v1.0.19 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking h2 v0.1.9 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Compiling cargo_metadata v0.5.5 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Compiling actix v0.5.7 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Checking actix-web-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(HttpResponse::Ok().body(html)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().body(html))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:13:43 [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = match fs::File::create(file_path_string.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = match fs::File::create(&(*file_path_string).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = match fs::File::create(&str::clone(file_path_string)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | .map(move |item| handle_multipart_item(item)).flatten()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `handle_multipart_item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `actix-web-test`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(HttpResponse::Ok().body(html)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(HttpResponse::Ok().body(html))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:13:43 [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = match fs::File::create(file_path_string.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = match fs::File::create(&(*file_path_string).clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = match fs::File::create(&str::clone(file_path_string)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | .map(move |item| handle_multipart_item(item)).flatten()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `handle_multipart_item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `actix-web-test`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0990356f04d624c4c27ee085d6b2e49c2cf00deda5eef7a69835a4ad3ff5446c"` [INFO] running `"docker" "rm" "-f" "0990356f04d624c4c27ee085d6b2e49c2cf00deda5eef7a69835a4ad3ff5446c"` [INFO] [stdout] 0990356f04d624c4c27ee085d6b2e49c2cf00deda5eef7a69835a4ad3ff5446c