[INFO] updating cached repository yuya373/slack-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yuya373/slack-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yuya373/slack-rs" "work/ex/clippy-test-run/sources/stable/gh/yuya373/slack-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yuya373/slack-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yuya373/slack-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuya373/slack-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuya373/slack-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 72d00539329da77df4d77a2d4d30567a51628814 [INFO] sha for GitHub repo yuya373/slack-rs: 72d00539329da77df4d77a2d4d30567a51628814 [INFO] validating manifest of yuya373/slack-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yuya373/slack-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yuya373/slack-rs [INFO] finished frobbing yuya373/slack-rs [INFO] frobbed toml for yuya373/slack-rs written to work/ex/clippy-test-run/sources/stable/gh/yuya373/slack-rs/Cargo.toml [INFO] started frobbing yuya373/slack-rs [INFO] finished frobbing yuya373/slack-rs [INFO] frobbed toml for yuya373/slack-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuya373/slack-rs/Cargo.toml [INFO] crate yuya373/slack-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yuya373/slack-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yuya373/slack-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec5b589155eb38bf655ee1d86888307af24ef60babbc5ba60a5c91475e69a86b [INFO] running `"docker" "start" "-a" "ec5b589155eb38bf655ee1d86888307af24ef60babbc5ba60a5c91475e69a86b"` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking futures v0.1.24 [INFO] [stderr] Checking lazycell v1.2.0 [INFO] [stderr] Compiling proc-macro2 v0.4.19 [INFO] [stderr] Compiling openssl v0.10.12 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Checking string v0.1.1 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Compiling serde v1.0.79 [INFO] [stderr] Checking indexmap v1.0.1 [INFO] [stderr] Checking safemem v0.3.0 [INFO] [stderr] Checking openssl-probe v0.1.2 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking utf-8 v0.7.4 [INFO] [stderr] Checking dirs v1.0.3 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Compiling openssl-sys v0.9.36 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Checking tokio-executor v0.1.4 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking tokio-timer v0.2.6 [INFO] [stderr] Checking tokio-current-thread v0.1.1 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Compiling syn v0.15.4 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking tokio-dns-unofficial v0.3.1 [INFO] [stderr] Checking tokio-tls v0.2.0 [INFO] [stderr] Checking tungstenite v0.6.0 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking tokio-tungstenite v0.6.0 [INFO] [stderr] Checking hyper v0.12.10 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking serde_json v1.0.28 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Checking reqwest v0.9.0 [INFO] [stderr] Checking slack-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `futures::future` [INFO] [stderr] --> src/model/workspace.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use futures::future; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::Sink` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use futures::Sink; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Channel`, `Group`, `Im`, `Me`, `Mpim`, `Team` [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | use model::{Channel, Group, Im, Me, Mpim, Team, Workspace}; [INFO] [stderr] | ^^^^^^^ ^^^^^ ^^ ^^ ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::future` [INFO] [stderr] --> src/model/workspace.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use futures::future; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::Sink` [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use futures::Sink; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Channel`, `Group`, `Im`, `Me`, `Mpim`, `Team` [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | use model::{Channel, Group, Im, Me, Mpim, Team, Workspace}; [INFO] [stderr] | ^^^^^^^ ^^^^^ ^^ ^^ ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Timestamp` [INFO] [stderr] --> src/model/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | type Timestamp = String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/api/conversations.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | if res.ok && res.response_metadata.next_cursor.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!res.response_metadata.next_cursor.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rtm/ping.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | / tx.unbounded_send(Action::ping()) [INFO] [stderr] 12 | | .map_err(|err| println!("Failed to send Action::ping, {:?}", err)); [INFO] [stderr] | |___________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `Type` should have a snake case name such as `type` [INFO] [stderr] --> src/rtm/handler.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Type: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `Type` should have a snake case name such as `type` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Type: ActionType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | resp.team.map(|team| workspace.set_team(team)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(team) = resp.team { workspace.set_team(team) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | resp.me.map(|me| workspace.set_me(me)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(me) = resp.me { workspace.set_me(me) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Timestamp` [INFO] [stderr] --> src/model/mod.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | type Timestamp = String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/api/conversations.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | if res.ok && res.response_metadata.next_cursor.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!res.response_metadata.next_cursor.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rtm/ping.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | / tx.unbounded_send(Action::ping()) [INFO] [stderr] 12 | | .map_err(|err| println!("Failed to send Action::ping, {:?}", err)); [INFO] [stderr] | |___________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `Type` should have a snake case name such as `type` [INFO] [stderr] --> src/rtm/handler.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Type: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `Type` should have a snake case name such as `type` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Type: ActionType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | resp.team.map(|team| workspace.set_team(team)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(team) = resp.team { workspace.set_team(team) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | resp.me.map(|me| workspace.set_me(me)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(me) = resp.me { workspace.set_me(me) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `"docker" "inspect" "ec5b589155eb38bf655ee1d86888307af24ef60babbc5ba60a5c91475e69a86b"` [INFO] running `"docker" "rm" "-f" "ec5b589155eb38bf655ee1d86888307af24ef60babbc5ba60a5c91475e69a86b"` [INFO] [stdout] ec5b589155eb38bf655ee1d86888307af24ef60babbc5ba60a5c91475e69a86b