[INFO] updating cached repository yuttie/Scrib [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yuttie/Scrib [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yuttie/Scrib" "work/ex/clippy-test-run/sources/stable/gh/yuttie/Scrib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yuttie/Scrib'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yuttie/Scrib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuttie/Scrib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuttie/Scrib'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61c0992578717c5134519b500ae8d9f3dfae5b72 [INFO] sha for GitHub repo yuttie/Scrib: 61c0992578717c5134519b500ae8d9f3dfae5b72 [INFO] validating manifest of yuttie/Scrib on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yuttie/Scrib on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yuttie/Scrib [INFO] finished frobbing yuttie/Scrib [INFO] frobbed toml for yuttie/Scrib written to work/ex/clippy-test-run/sources/stable/gh/yuttie/Scrib/Cargo.toml [INFO] started frobbing yuttie/Scrib [INFO] finished frobbing yuttie/Scrib [INFO] frobbed toml for yuttie/Scrib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuttie/Scrib/Cargo.toml [INFO] crate yuttie/Scrib has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yuttie/Scrib against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yuttie/Scrib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5de5fe05164218ec57d3e17d8b6288f5e2dda1521c8aabf922468212e8b14f7 [INFO] running `"docker" "start" "-a" "f5de5fe05164218ec57d3e17d8b6288f5e2dda1521c8aabf922468212e8b14f7"` [INFO] [stderr] Compiling cc v1.0.15 [INFO] [stderr] Checking libc v0.2.41 [INFO] [stderr] Compiling nodrop v0.1.12 [INFO] [stderr] Compiling cfg-if v0.1.3 [INFO] [stderr] Compiling serde v1.0.59 [INFO] [stderr] Compiling lazy_static v1.0.0 [INFO] [stderr] Compiling memoffset v0.2.1 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling rustc-demangle v0.1.8 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling itoa v0.4.1 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling backtrace v0.2.3 [INFO] [stderr] Compiling pulldown-cmark v0.1.2 [INFO] [stderr] Compiling same-file v1.0.2 [INFO] [stderr] Compiling remove_dir_all v0.5.1 [INFO] [stderr] Compiling gcc v0.3.54 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling bytecount v0.3.1 [INFO] [stderr] Checking linked-hash-map v0.4.2 [INFO] [stderr] Checking memoffset v0.1.0 [INFO] [stderr] Checking quick-error v1.2.1 [INFO] [stderr] Checking untrusted v0.5.1 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking string v0.1.0 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking http-range v0.1.1 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling proc-macro2 v0.4.3 [INFO] [stderr] Compiling proc-macro2 v0.3.8 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Compiling actix-web v0.6.8 [INFO] [stderr] Compiling dbghelp-sys v0.2.0 [INFO] [stderr] Compiling arrayvec v0.4.7 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Compiling walkdir v2.1.4 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Checking base64 v0.9.1 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Checking lru-cache v0.1.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking hostname v0.1.4 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking crossbeam-epoch v0.2.0 [INFO] [stderr] Checking tokio-timer v0.2.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling quote v0.6.1 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Checking resolv-conf v0.6.0 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Compiling syn v0.14.0 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking uuid v0.6.3 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking http v0.1.5 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Compiling serde_derive v1.0.59 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Compiling structopt-derive v0.2.8 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking crossbeam-channel v0.1.2 [INFO] [stderr] Compiling backtrace v0.3.7 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking structopt v0.2.8 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Checking h2 v0.1.7 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Compiling cargo_metadata v0.5.4 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Compiling actix v0.5.7 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking scrib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | id: id, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | id: id, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let mut pathbuf = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let mut pathbuf = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:102:8 [INFO] [stderr] | [INFO] [stderr] 102 | if candidates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:102:8 [INFO] [stderr] | [INFO] [stderr] 102 | if candidates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `candidates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | .bind(HOST_PORT).expect(&format!("Can not bind to {}", HOST_PORT)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can not bind to {}", HOST_PORT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:219:26 [INFO] [stderr] | [INFO] [stderr] 219 | .bind(HOST_PORT).expect(&format!("Can not bind to {}", HOST_PORT)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can not bind to {}", HOST_PORT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 11s [INFO] running `"docker" "inspect" "f5de5fe05164218ec57d3e17d8b6288f5e2dda1521c8aabf922468212e8b14f7"` [INFO] running `"docker" "rm" "-f" "f5de5fe05164218ec57d3e17d8b6288f5e2dda1521c8aabf922468212e8b14f7"` [INFO] [stdout] f5de5fe05164218ec57d3e17d8b6288f5e2dda1521c8aabf922468212e8b14f7