[INFO] updating cached repository yurydelendik/wasm-dwarf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yurydelendik/wasm-dwarf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yurydelendik/wasm-dwarf" "work/ex/clippy-test-run/sources/stable/gh/yurydelendik/wasm-dwarf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yurydelendik/wasm-dwarf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yurydelendik/wasm-dwarf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yurydelendik/wasm-dwarf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yurydelendik/wasm-dwarf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d5cd83df84d6709c079cf540f1217e559c47d66a [INFO] sha for GitHub repo yurydelendik/wasm-dwarf: d5cd83df84d6709c079cf540f1217e559c47d66a [INFO] validating manifest of yurydelendik/wasm-dwarf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yurydelendik/wasm-dwarf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yurydelendik/wasm-dwarf [INFO] finished frobbing yurydelendik/wasm-dwarf [INFO] frobbed toml for yurydelendik/wasm-dwarf written to work/ex/clippy-test-run/sources/stable/gh/yurydelendik/wasm-dwarf/Cargo.toml [INFO] started frobbing yurydelendik/wasm-dwarf [INFO] finished frobbing yurydelendik/wasm-dwarf [INFO] frobbed toml for yurydelendik/wasm-dwarf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yurydelendik/wasm-dwarf/Cargo.toml [INFO] crate yurydelendik/wasm-dwarf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yurydelendik/wasm-dwarf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yurydelendik/wasm-dwarf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e8d0b8ae391c5e59118eb721e02ad96360de6c4ee803ece21fca33f7995b0b8 [INFO] running `"docker" "start" "-a" "2e8d0b8ae391c5e59118eb721e02ad96360de6c4ee803ece21fca33f7995b0b8"` [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking fallible-iterator v0.1.4 [INFO] [stderr] Checking byteorder v1.2.2 [INFO] [stderr] Checking getopts v0.2.17 [INFO] [stderr] Checking vlq v0.5.1 [INFO] [stderr] Checking wasmparser v0.15.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking gimli v0.15.0 [INFO] [stderr] Checking wasm-dwarf v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return name.len() >= 13 && &name[0..13] == b"reloc..debug_"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.len() >= 13 && &name[0..13] == b"reloc..debug_"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return name.len() >= 7 && &name[0..7] == b".debug_"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.len() >= 7 && &name[0..7] == b".debug_"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return name == b"linking"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name == b"linking"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return name == b"sourceMappingURL"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name == b"sourceMappingURL"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return PrefixReplacements { replacements }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrefixReplacements { replacements }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return name.len() >= 13 && &name[0..13] == b"reloc..debug_"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.len() >= 13 && &name[0..13] == b"reloc..debug_"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return name.len() >= 7 && &name[0..7] == b".debug_"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.len() >= 7 && &name[0..7] == b".debug_"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return name == b"linking"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name == b"linking"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wasm_read.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return name == b"sourceMappingURL"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name == b"sourceMappingURL"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return PrefixReplacements { replacements }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrefixReplacements { replacements }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let ref tables = debug_sections.tables; [INFO] [stderr] | ----^^^^^^^^^^------------------------- help: try: `let tables = &debug_sections.tables;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let ref debug_str = DebugStr::new(&tables[&to_vec(b".debug_str")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^---------------------------------------------------------------- help: try: `let debug_str = &DebugStr::new(&tables[&to_vec(b".debug_str")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref debug_abbrev = DebugAbbrev::new(&tables[&to_vec(b".debug_abbrev")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^---------------------------------------------------------------------- help: try: `let debug_abbrev = &DebugAbbrev::new(&tables[&to_vec(b".debug_abbrev")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | let ref debug_info = DebugInfo::new(&tables[&to_vec(b".debug_info")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------------------------ help: try: `let debug_info = &DebugInfo::new(&tables[&to_vec(b".debug_info")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let ref debug_line = DebugLine::new(&tables[&to_vec(b".debug_line")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------------------------ help: try: `let debug_line = &DebugLine::new(&tables[&to_vec(b".debug_line")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/dwarf.rs:77:33 [INFO] [stderr] | [INFO] [stderr] 77 | let source_id = if !source_to_id_map.contains_key(&file_index) { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 78 | | let file_path: String = if let Some(file) = row.file(header) { [INFO] [stderr] 79 | | if let Some(directory) = file.directory(header) { [INFO] [stderr] 80 | | format!( [INFO] [stderr] ... | [INFO] [stderr] 96 | | *source_to_id_map.get(&file_index).unwrap() as usize [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________________^ help: consider using: `source_to_id_map.entry(file_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dwarf.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | *source_to_id_map.get(&file_index).unwrap() as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&source_to_id_map[&file_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dwarf.rs:110:99 [INFO] [stderr] | [INFO] [stderr] 110 | if locations[block_start_loc].address <= debug_sections.code_content as u64 + fn_size_field_len as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fn_size_field_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let ref tables = debug_sections.tables; [INFO] [stderr] | ----^^^^^^^^^^------------------------- help: try: `let tables = &debug_sections.tables;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | let ref debug_str = DebugStr::new(&tables[&to_vec(b".debug_str")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^---------------------------------------------------------------- help: try: `let debug_str = &DebugStr::new(&tables[&to_vec(b".debug_str")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref debug_abbrev = DebugAbbrev::new(&tables[&to_vec(b".debug_abbrev")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^---------------------------------------------------------------------- help: try: `let debug_abbrev = &DebugAbbrev::new(&tables[&to_vec(b".debug_abbrev")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | let ref debug_info = DebugInfo::new(&tables[&to_vec(b".debug_info")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------------------------ help: try: `let debug_info = &DebugInfo::new(&tables[&to_vec(b".debug_info")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dwarf.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let ref debug_line = DebugLine::new(&tables[&to_vec(b".debug_line")], LittleEndian); [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------------------------------------ help: try: `let debug_line = &DebugLine::new(&tables[&to_vec(b".debug_line")], LittleEndian);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/dwarf.rs:77:33 [INFO] [stderr] | [INFO] [stderr] 77 | let source_id = if !source_to_id_map.contains_key(&file_index) { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 78 | | let file_path: String = if let Some(file) = row.file(header) { [INFO] [stderr] 79 | | if let Some(directory) = file.directory(header) { [INFO] [stderr] 80 | | format!( [INFO] [stderr] ... | [INFO] [stderr] 96 | | *source_to_id_map.get(&file_index).unwrap() as usize [INFO] [stderr] 97 | | }; [INFO] [stderr] | |_________________^ help: consider using: `source_to_id_map.entry(file_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dwarf.rs:96:22 [INFO] [stderr] | [INFO] [stderr] 96 | *source_to_id_map.get(&file_index).unwrap() as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&source_to_id_map[&file_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dwarf.rs:110:99 [INFO] [stderr] | [INFO] [stderr] 110 | if locations[block_start_loc].address <= debug_sections.code_content as u64 + fn_size_field_len as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(fn_size_field_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/reloc.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let ref linking_table = debug_sections.linking.as_ref().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^-------------------------------------------- help: try: `let linking_table = &debug_sections.linking.as_ref().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/reloc.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let ref linking_table = debug_sections.linking.as_ref().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^-------------------------------------------- help: try: `let linking_table = &debug_sections.linking.as_ref().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/reloc.rs:84:9 [INFO] [stderr] | [INFO] [stderr] --> src/reloc.rs:84:9 [INFO] [stderr] 84 | for ref reloc_table_name in reloc_tables_names { [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ------------------ help: try: `let reloc_table_name = &reloc_tables_names;` [INFO] [stderr] 84 | for ref reloc_table_name in reloc_tables_names { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ------------------ help: try: `let reloc_table_name = &reloc_tables_names;` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/reloc.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | let func_index = func_indices.get(&index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&func_indices[&index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/reloc.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | let func_index = func_indices.get(&index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&func_indices[&index]` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | let _old_offset = (table[fixup_offset + 0] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `fixup_offset` [INFO] [stderr] --> src/reloc.rs:115:38 [INFO] [stderr] | [INFO] [stderr] 115 | let _old_offset = (table[fixup_offset + 0] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | | ((table[fixup_offset + 1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 1])` [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | let _old_offset = (table[fixup_offset + 0] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `fixup_offset` [INFO] [stderr] --> src/reloc.rs:115:38 [INFO] [stderr] | [INFO] [stderr] 115 | let _old_offset = (table[fixup_offset + 0] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | | ((table[fixup_offset + 1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | | ((table[fixup_offset + 2] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | | ((table[fixup_offset + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `fixup_offset` [INFO] [stderr] --> src/reloc.rs:121:19 [INFO] [stderr] | [INFO] [stderr] 121 | table[fixup_offset + 0] = (offset & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | let source_id_delta = loc.source_id as i64 - last_source_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.source_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | let line_delta = loc.line as i64 - last_line; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(loc.line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let column_delta = loc.column as i64 - last_column; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | last_source_id = loc.source_id as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.source_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | last_line = loc.line as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(loc.line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | last_column = loc.column as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/to_json.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | if di.locations.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!di.locations.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | | ((table[fixup_offset + 2] as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reloc.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | | ((table[fixup_offset + 3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[fixup_offset + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `fixup_offset` [INFO] [stderr] --> src/reloc.rs:121:19 [INFO] [stderr] | [INFO] [stderr] 121 | table[fixup_offset + 0] = (offset & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | let source_id_delta = loc.source_id as i64 - last_source_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.source_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | let line_delta = loc.line as i64 - last_line; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(loc.line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let column_delta = loc.column as i64 - last_column; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | last_source_id = loc.source_id as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.source_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | last_line = loc.line as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(loc.line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/to_json.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | last_column = loc.column as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(loc.column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/to_json.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | if di.locations.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!di.locations.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wasm_read.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | / write [INFO] [stderr] 173 | | .write(&wasm[last_written..offset]) [INFO] [stderr] 174 | | .expect("wasm result written"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wasm_read.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / write [INFO] [stderr] 196 | | .write(&wasm[last_written..wasm.len()]) [INFO] [stderr] 197 | | .expect("wasm result written"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/wasm_read.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | i = i >> 7; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `i >>= 7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wasm_read.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | write.write(&result).expect("wasm result written"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | fn parse(input: &Vec) -> PrefixReplacements { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | fn replace(&self, path: &String) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 46 | fn replace(&self, path: &str) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 47 | let mut result = path.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wasm_read.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | / write [INFO] [stderr] 173 | | .write(&wasm[last_written..offset]) [INFO] [stderr] 174 | | .expect("wasm result written"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | if matches.opt_present("h") || matches.free.len() < 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.free.is_empty()` [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wasm_read.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | / write [INFO] [stderr] 196 | | .write(&wasm[last_written..wasm.len()]) [INFO] [stderr] 197 | | .expect("wasm result written"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/wasm_read.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | i = i >> 7; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `i >>= 7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | f_out.write(result.as_bytes()).expect("data written"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / f_out [INFO] [stderr] 171 | | .write(&modified_wasm.unwrap_or(data)) [INFO] [stderr] 172 | | .expect("wasm data written"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wasm_read.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | write.write(&result).expect("wasm result written"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | fn parse(input: &Vec) -> PrefixReplacements { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | fn replace(&self, path: &String) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 46 | fn replace(&self, path: &str) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 47 | let mut result = path.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-dwarf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | if matches.opt_present("h") || matches.free.len() < 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | f_out.write(result.as_bytes()).expect("data written"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / f_out [INFO] [stderr] 171 | | .write(&modified_wasm.unwrap_or(data)) [INFO] [stderr] 172 | | .expect("wasm data written"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-dwarf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2e8d0b8ae391c5e59118eb721e02ad96360de6c4ee803ece21fca33f7995b0b8"` [INFO] running `"docker" "rm" "-f" "2e8d0b8ae391c5e59118eb721e02ad96360de6c4ee803ece21fca33f7995b0b8"` [INFO] [stdout] 2e8d0b8ae391c5e59118eb721e02ad96360de6c4ee803ece21fca33f7995b0b8