[INFO] updating cached repository yuri91/overbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yuri91/overbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yuri91/overbot" "work/ex/clippy-test-run/sources/stable/gh/yuri91/overbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yuri91/overbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yuri91/overbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuri91/overbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuri91/overbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b82513b900a1b6f55ac22c5889fe439765d6213 [INFO] sha for GitHub repo yuri91/overbot: 3b82513b900a1b6f55ac22c5889fe439765d6213 [INFO] validating manifest of yuri91/overbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yuri91/overbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yuri91/overbot [INFO] finished frobbing yuri91/overbot [INFO] frobbed toml for yuri91/overbot written to work/ex/clippy-test-run/sources/stable/gh/yuri91/overbot/Cargo.toml [INFO] started frobbing yuri91/overbot [INFO] finished frobbing yuri91/overbot [INFO] frobbed toml for yuri91/overbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuri91/overbot/Cargo.toml [INFO] crate yuri91/overbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yuri91/overbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yuri91/overbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] acf61fe39664d6e3d2d292b016aa16a10a54dab15c6ceb39f92b54ae9e3b0d3d [INFO] running `"docker" "start" "-a" "acf61fe39664d6e3d2d292b016aa16a10a54dab15c6ceb39f92b54ae9e3b0d3d"` [INFO] [stderr] Compiling gcc v0.3.51 [INFO] [stderr] Checking libc v0.2.29 [INFO] [stderr] Checking log v0.3.8 [INFO] [stderr] Checking lazycell v0.5.1 [INFO] [stderr] Compiling openssl v0.9.15 [INFO] [stderr] Checking futures v0.1.14 [INFO] [stderr] Checking lazy_static v0.2.8 [INFO] [stderr] Checking foreign-types v0.2.0 [INFO] [stderr] Checking rustc-demangle v0.1.4 [INFO] [stderr] Checking percent-encoding v1.0.0 [INFO] [stderr] Checking httparse v1.2.3 [INFO] [stderr] Checking unicode-segmentation v1.2.0 [INFO] [stderr] Checking num-traits v0.1.40 [INFO] [stderr] Checking serde v1.0.11 [INFO] [stderr] Checking itoa v0.3.1 [INFO] [stderr] Checking dtoa v0.4.1 [INFO] [stderr] Checking regex-syntax v0.4.1 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.30 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Compiling unicase v2.0.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Compiling openssl-sys v0.9.15 [INFO] [stderr] Compiling backtrace-sys v0.1.12 [INFO] [stderr] Checking bytes v0.4.4 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking tokio-io v0.1.2 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking mime v0.3.2 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-signal v0.1.2 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Compiling structopt-derive v0.0.5 [INFO] [stderr] Checking tokio-process v0.1.4 [INFO] [stderr] Compiling serde_derive v1.0.11 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking toml v0.4.4 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking structopt v0.0.5 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking telegram-bot-types v0.1.4 [INFO] [stderr] Checking telegram-bot-types v0.2.1 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking telegram-bot-client v0.2.1 [INFO] [stderr] Checking overbot v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | let text = msg.text.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.text.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / let work; [INFO] [stderr] 109 | | if cmd.output == config::OutputType::Json { [INFO] [stderr] 110 | | let json: Result = serde_json::from_str(&out); [INFO] [stderr] 111 | | let json = match json { [INFO] [stderr] ... | [INFO] [stderr] 131 | | ); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 108 | let work = if cmd.output == config::OutputType::Json { ..; bot.request::<_, serde_json::Value>("sendMessage", &json) } else { ..; bot.request::<_, serde_json::Value>( [INFO] [stderr] 109 | "sendMessage", [INFO] [stderr] 110 | &serde_json::to_value( [INFO] [stderr] 111 | types::request::Message::new(msg.chat.id, out).parse_mode( [INFO] [stderr] 112 | parse_mode, [INFO] [stderr] 113 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in results.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:230:26 [INFO] [stderr] | [INFO] [stderr] 230 | for r in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | let text = msg.text.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.text.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / let work; [INFO] [stderr] 109 | | if cmd.output == config::OutputType::Json { [INFO] [stderr] 110 | | let json: Result = serde_json::from_str(&out); [INFO] [stderr] 111 | | let json = match json { [INFO] [stderr] ... | [INFO] [stderr] 131 | | ); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 108 | let work = if cmd.output == config::OutputType::Json { ..; bot.request::<_, serde_json::Value>("sendMessage", &json) } else { ..; bot.request::<_, serde_json::Value>( [INFO] [stderr] 109 | "sendMessage", [INFO] [stderr] 110 | &serde_json::to_value( [INFO] [stderr] 111 | types::request::Message::new(msg.chat.id, out).parse_mode( [INFO] [stderr] 112 | parse_mode, [INFO] [stderr] 113 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in results.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:230:26 [INFO] [stderr] | [INFO] [stderr] 230 | for r in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `"docker" "inspect" "acf61fe39664d6e3d2d292b016aa16a10a54dab15c6ceb39f92b54ae9e3b0d3d"` [INFO] running `"docker" "rm" "-f" "acf61fe39664d6e3d2d292b016aa16a10a54dab15c6ceb39f92b54ae9e3b0d3d"` [INFO] [stdout] acf61fe39664d6e3d2d292b016aa16a10a54dab15c6ceb39f92b54ae9e3b0d3d