[INFO] updating cached repository yukihir0/rs_monkey [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yukihir0/rs_monkey [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yukihir0/rs_monkey" "work/ex/clippy-test-run/sources/stable/gh/yukihir0/rs_monkey"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yukihir0/rs_monkey'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yukihir0/rs_monkey" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yukihir0/rs_monkey"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yukihir0/rs_monkey'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0cfaa6c5ad7c1ffe611cee5a5289f4d6dd582db [INFO] sha for GitHub repo yukihir0/rs_monkey: b0cfaa6c5ad7c1ffe611cee5a5289f4d6dd582db [INFO] validating manifest of yukihir0/rs_monkey on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yukihir0/rs_monkey on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yukihir0/rs_monkey [INFO] finished frobbing yukihir0/rs_monkey [INFO] frobbed toml for yukihir0/rs_monkey written to work/ex/clippy-test-run/sources/stable/gh/yukihir0/rs_monkey/Cargo.toml [INFO] started frobbing yukihir0/rs_monkey [INFO] finished frobbing yukihir0/rs_monkey [INFO] frobbed toml for yukihir0/rs_monkey written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yukihir0/rs_monkey/Cargo.toml [INFO] crate yukihir0/rs_monkey has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yukihir0/rs_monkey against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yukihir0/rs_monkey:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b566e938d185d0d3c71ce855514a7f0a3445f269df39c29a03d2c652f368fb8 [INFO] running `"docker" "start" "-a" "6b566e938d185d0d3c71ce855514a7f0a3445f269df39c29a03d2c652f368fb8"` [INFO] [stderr] Checking rs_monkey v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | consequence: consequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | alternative: alternative, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alternative` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | args: args, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evaluator.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | consequence: consequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | alternative: alternative, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alternative` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | args: args, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/evaluator.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:597:58 [INFO] [stderr] | [INFO] [stderr] 597 | Expression::Literal(Literal::Integer(838383)), [INFO] [stderr] | ^^^^^^ help: consider: `838_383` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:620:72 [INFO] [stderr] | [INFO] [stderr] 620 | Statement::Return(Expression::Literal(Literal::Integer(993322))), [INFO] [stderr] | ^^^^^^ help: consider: `993_322` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/object.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | result.push_str(&format!("{}", s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/object.rs:73:1 [INFO] [stderr] | [INFO] [stderr] 73 | / impl Hash for Object { [INFO] [stderr] 74 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 75 | | match *self { [INFO] [stderr] 76 | | Object::Integer(ref i) => i.hash(state), [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/object.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(PartialEq, Clone, Debug)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `environment::Environment` [INFO] [stderr] --> src/environment.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Environment { [INFO] [stderr] 16 | | store: HashMap::new(), [INFO] [stderr] 17 | | outer: None, [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builtin.rs:79:32 [INFO] [stderr] | [INFO] [stderr] 79 | Object::Array(o) => if o.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!o.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / match self.parse_statement() { [INFO] [stderr] 131 | | Some(statement) => program.push(statement), [INFO] [stderr] 132 | | None => {}, [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(statement) = self.parse_statement() { program.push(statement) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:405:9 [INFO] [stderr] | [INFO] [stderr] 405 | / let mut alternative = None; [INFO] [stderr] 406 | | [INFO] [stderr] 407 | | if self.peek_token_is(&Token::Else) { [INFO] [stderr] 408 | | self.next_token(); [INFO] [stderr] ... | [INFO] [stderr] 414 | | alternative = Some(self.parse_block_statement()); [INFO] [stderr] 415 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let alternative = if self.peek_token_is(&Token::Else) { ..; Some(self.parse_block_statement()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | / match self.parse_statement() { [INFO] [stderr] 431 | | Some(statement) => block.push(statement), [INFO] [stderr] 432 | | None => {} [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(statement) = self.parse_statement() { block.push(statement) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator.rs:141:35 [INFO] [stderr] | [INFO] [stderr] 141 | None => Object::Error(String::from(format!("identifier not found: {}", name))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("identifier not found: {}", name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator.rs:258:32 [INFO] [stderr] | [INFO] [stderr] 258 | _ => Object::Error(String::from(format!( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 259 | | "unknown operator: {} {} {}", [INFO] [stderr] 260 | | left, infix, right [INFO] [stderr] 261 | | ))), [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 258 | _ => Object::Error(format!( [INFO] [stderr] 259 | "unknown operator: {} {} {}", [INFO] [stderr] 260 | left, infix, right [INFO] [stderr] 261 | )), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/evaluator.rs:280:40 [INFO] [stderr] | [INFO] [stderr] 280 | fn eval_call_expression(&mut self, function: Box, args: Vec) -> Object { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rs_monkey`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/object.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | result.push_str(&format!("{}", s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/object.rs:73:1 [INFO] [stderr] | [INFO] [stderr] 73 | / impl Hash for Object { [INFO] [stderr] 74 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 75 | | match *self { [INFO] [stderr] 76 | | Object::Integer(ref i) => i.hash(state), [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/object.rs:10:10 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(PartialEq, Clone, Debug)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `environment::Environment` [INFO] [stderr] --> src/environment.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Environment { [INFO] [stderr] 16 | | store: HashMap::new(), [INFO] [stderr] 17 | | outer: None, [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/builtin.rs:79:32 [INFO] [stderr] | [INFO] [stderr] 79 | Object::Array(o) => if o.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!o.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lexer.rs:118:18 [INFO] [stderr] | [INFO] [stderr] 118 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / match self.parse_statement() { [INFO] [stderr] 131 | | Some(statement) => program.push(statement), [INFO] [stderr] 132 | | None => {}, [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(statement) = self.parse_statement() { program.push(statement) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:405:9 [INFO] [stderr] | [INFO] [stderr] 405 | / let mut alternative = None; [INFO] [stderr] 406 | | [INFO] [stderr] 407 | | if self.peek_token_is(&Token::Else) { [INFO] [stderr] 408 | | self.next_token(); [INFO] [stderr] ... | [INFO] [stderr] 414 | | alternative = Some(self.parse_block_statement()); [INFO] [stderr] 415 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let alternative = if self.peek_token_is(&Token::Else) { ..; Some(self.parse_block_statement()) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | / match self.parse_statement() { [INFO] [stderr] 431 | | Some(statement) => block.push(statement), [INFO] [stderr] 432 | | None => {} [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(statement) = self.parse_statement() { block.push(statement) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:562:12 [INFO] [stderr] | [INFO] [stderr] 562 | if errors.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator.rs:141:35 [INFO] [stderr] | [INFO] [stderr] 141 | None => Object::Error(String::from(format!("identifier not found: {}", name))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("identifier not found: {}", name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/evaluator.rs:258:32 [INFO] [stderr] | [INFO] [stderr] 258 | _ => Object::Error(String::from(format!( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 259 | | "unknown operator: {} {} {}", [INFO] [stderr] 260 | | left, infix, right [INFO] [stderr] 261 | | ))), [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 258 | _ => Object::Error(format!( [INFO] [stderr] 259 | "unknown operator: {} {} {}", [INFO] [stderr] 260 | left, infix, right [INFO] [stderr] 261 | )), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/evaluator.rs:280:40 [INFO] [stderr] | [INFO] [stderr] 280 | fn eval_call_expression(&mut self, function: Box, args: Vec) -> Object { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rs_monkey`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6b566e938d185d0d3c71ce855514a7f0a3445f269df39c29a03d2c652f368fb8"` [INFO] running `"docker" "rm" "-f" "6b566e938d185d0d3c71ce855514a7f0a3445f269df39c29a03d2c652f368fb8"` [INFO] [stdout] 6b566e938d185d0d3c71ce855514a7f0a3445f269df39c29a03d2c652f368fb8