[INFO] updating cached repository yuk1ty/lsh-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/yuk1ty/lsh-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/yuk1ty/lsh-rs" "work/ex/clippy-test-run/sources/stable/gh/yuk1ty/lsh-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yuk1ty/lsh-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/yuk1ty/lsh-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuk1ty/lsh-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuk1ty/lsh-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] aee999e0e28cf0d8655f92006fc66c6b607830ed
[INFO] sha for GitHub repo yuk1ty/lsh-rs: aee999e0e28cf0d8655f92006fc66c6b607830ed
[INFO] validating manifest of yuk1ty/lsh-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of yuk1ty/lsh-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing yuk1ty/lsh-rs
[INFO] finished frobbing yuk1ty/lsh-rs
[INFO] frobbed toml for yuk1ty/lsh-rs written to work/ex/clippy-test-run/sources/stable/gh/yuk1ty/lsh-rs/Cargo.toml
[INFO] started frobbing yuk1ty/lsh-rs
[INFO] finished frobbing yuk1ty/lsh-rs
[INFO] frobbed toml for yuk1ty/lsh-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuk1ty/lsh-rs/Cargo.toml
[INFO] crate yuk1ty/lsh-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting yuk1ty/lsh-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yuk1ty/lsh-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 59cce4d97f1760e20e0ddd2c9dee0cef90e6919c39ff86e1d2bf71dbd5d43ff4
[INFO] running `"docker" "start" "-a" "59cce4d97f1760e20e0ddd2c9dee0cef90e6919c39ff86e1d2bf71dbd5d43ff4"`
[INFO] [stderr]     Checking libc v0.2.40
[INFO] [stderr]     Checking byteorder v1.2.2
[INFO] [stderr]    Compiling nix v0.10.0
[INFO] [stderr]     Checking bitflags v1.0.1
[INFO] [stderr]     Checking cfg-if v0.1.2
[INFO] [stderr]     Checking iovec v0.1.2
[INFO] [stderr]     Checking bytes v0.4.6
[INFO] [stderr]     Checking lsh_rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: method is never used: `values`
[INFO] [stderr]   --> src/lsh/mod.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 |     fn values() -> Vec<String> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lsh::LshLoop`
[INFO] [stderr]   --> src/lsh/mod.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> LshLoop {
[INFO] [stderr] 16 | |         LshLoop
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lsh/mod.rs:25:22
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 .map(|token: &str| String::from(token))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lsh/mod.rs:75:12
[INFO] [stderr]    |
[INFO] [stderr] 75 |           Ok(println!(
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 76 | |             "{}",
[INFO] [stderr] 77 | |             match *self {
[INFO] [stderr] 78 | |                 Commands::Cd => "cd",
[INFO] [stderr] ...  |
[INFO] [stderr] 82 | |             }
[INFO] [stderr] 83 | |         ))
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lsh/mod.rs:89:8
[INFO] [stderr]    |
[INFO] [stderr] 89 |     if args.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `values`
[INFO] [stderr]   --> src/lsh/mod.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 |     fn values() -> Vec<String> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lsh::LshLoop`
[INFO] [stderr]   --> src/lsh/mod.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> LshLoop {
[INFO] [stderr] 16 | |         LshLoop
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lsh/mod.rs:25:22
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 .map(|token: &str| String::from(token))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/lsh/mod.rs:75:12
[INFO] [stderr]    |
[INFO] [stderr] 75 |           Ok(println!(
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 76 | |             "{}",
[INFO] [stderr] 77 | |             match *self {
[INFO] [stderr] 78 | |                 Commands::Cd => "cd",
[INFO] [stderr] ...  |
[INFO] [stderr] 82 | |             }
[INFO] [stderr] 83 | |         ))
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lsh/mod.rs:89:8
[INFO] [stderr]    |
[INFO] [stderr] 89 |     if args.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.97s
[INFO] running `"docker" "inspect" "59cce4d97f1760e20e0ddd2c9dee0cef90e6919c39ff86e1d2bf71dbd5d43ff4"`
[INFO] running `"docker" "rm" "-f" "59cce4d97f1760e20e0ddd2c9dee0cef90e6919c39ff86e1d2bf71dbd5d43ff4"`
[INFO] [stdout] 59cce4d97f1760e20e0ddd2c9dee0cef90e6919c39ff86e1d2bf71dbd5d43ff4