[INFO] updating cached repository yufengwng/wallsplash [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yufengwng/wallsplash [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yufengwng/wallsplash" "work/ex/clippy-test-run/sources/stable/gh/yufengwng/wallsplash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yufengwng/wallsplash'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yufengwng/wallsplash" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yufengwng/wallsplash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yufengwng/wallsplash'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 847ab9f11af163c3a8cb10a080f4f0799e35856c [INFO] sha for GitHub repo yufengwng/wallsplash: 847ab9f11af163c3a8cb10a080f4f0799e35856c [INFO] validating manifest of yufengwng/wallsplash on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yufengwng/wallsplash on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yufengwng/wallsplash [INFO] finished frobbing yufengwng/wallsplash [INFO] frobbed toml for yufengwng/wallsplash written to work/ex/clippy-test-run/sources/stable/gh/yufengwng/wallsplash/Cargo.toml [INFO] started frobbing yufengwng/wallsplash [INFO] finished frobbing yufengwng/wallsplash [INFO] frobbed toml for yufengwng/wallsplash written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yufengwng/wallsplash/Cargo.toml [INFO] crate yufengwng/wallsplash has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yufengwng/wallsplash against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yufengwng/wallsplash:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f846fb09a18cc600f4bf067896e450f4c69089bbb3525963cb5546751bb6d034 [INFO] running `"docker" "start" "-a" "f846fb09a18cc600f4bf067896e450f4c69089bbb3525963cb5546751bb6d034"` [INFO] [stderr] Compiling openssl v0.9.12 [INFO] [stderr] Checking unicode-normalization v0.1.4 [INFO] [stderr] Checking libc v0.2.23 [INFO] [stderr] Checking httparse v1.2.2 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Checking serde v1.0.7 [INFO] [stderr] Compiling openssl-sys v0.9.12 [INFO] [stderr] Checking unicode-bidi v0.2.6 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking libflate v0.1.6 [INFO] [stderr] Checking mime v0.2.4 [INFO] [stderr] Compiling hyper v0.10.10 [INFO] [stderr] Compiling serde_derive_internals v0.15.0 [INFO] [stderr] Checking unicase v1.4.0 [INFO] [stderr] Checking num_cpus v1.4.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking idna v0.1.1 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Compiling serde_derive v1.0.7 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking url v1.4.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking wallsplash v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetchers.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetchers.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | refresh: refresh, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | refresh: refresh, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetchers.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetchers.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | refresh: refresh, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | refresh: refresh, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetchers.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | const UNSPLASH_API: &'static str = "https://api.unsplash.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetchers.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | const PHOTOS_ENDPOINT: &'static str = "/photos"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/fetchers.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | let mut cache = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetchers.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | const UNSPLASH_API: &'static str = "https://api.unsplash.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetchers.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | const PHOTOS_ENDPOINT: &'static str = "/photos"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/fetchers.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | let mut cache = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fetchers.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if images.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!images.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fetchers.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | self.next = self.next % images.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next %= images.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fetchers.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if images.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!images.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fetchers.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | self.next = self.next % images.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next %= images.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fetchers.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | self.next = self.next % self.total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next %= self.total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/fetchers.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | self.next = self.next % self.total; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next %= self.total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | let mut p = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | let mut p = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:37 [INFO] [stderr] | [INFO] [stderr] 250 | Duration::from_secs(self.timeout as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:251:37 [INFO] [stderr] | [INFO] [stderr] 251 | Duration::from_secs(self.unsplash_refresh as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.unsplash_refresh)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:303:18 [INFO] [stderr] | [INFO] [stderr] 303 | .or(self.table.local.as_ref().and_then(|t| t.dir.to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.table.local.as_ref().and_then(|t| t.dir.to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:311:18 [INFO] [stderr] | [INFO] [stderr] 311 | .or(self.table [INFO] [stderr] | __________________^ [INFO] [stderr] 312 | | .unsplash [INFO] [stderr] 313 | | .as_ref() [INFO] [stderr] 314 | | .and_then(|t| t.token.to_owned())) [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 311 | .or_else(|| self.table [INFO] [stderr] 312 | .unsplash [INFO] [stderr] 313 | .as_ref() [INFO] [stderr] 314 | .and_then(|t| t.token.to_owned())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | Ok(num.or(self.table.unsplash.as_ref().and_then(|t| t.limit)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.table.unsplash.as_ref().and_then(|t| t.limit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:333:22 [INFO] [stderr] | [INFO] [stderr] 333 | secs.or(self.table.unsplash.as_ref().and_then(|t| t.refresh)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.table.unsplash.as_ref().and_then(|t| t.refresh))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:37 [INFO] [stderr] | [INFO] [stderr] 250 | Duration::from_secs(self.timeout as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:251:37 [INFO] [stderr] | [INFO] [stderr] 251 | Duration::from_secs(self.unsplash_refresh as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.unsplash_refresh)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:303:18 [INFO] [stderr] | [INFO] [stderr] 303 | .or(self.table.local.as_ref().and_then(|t| t.dir.to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.table.local.as_ref().and_then(|t| t.dir.to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:311:18 [INFO] [stderr] | [INFO] [stderr] 311 | .or(self.table [INFO] [stderr] | __________________^ [INFO] [stderr] 312 | | .unsplash [INFO] [stderr] 313 | | .as_ref() [INFO] [stderr] 314 | | .and_then(|t| t.token.to_owned())) [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 311 | .or_else(|| self.table [INFO] [stderr] 312 | .unsplash [INFO] [stderr] 313 | .as_ref() [INFO] [stderr] 314 | .and_then(|t| t.token.to_owned())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:323:20 [INFO] [stderr] | [INFO] [stderr] 323 | Ok(num.or(self.table.unsplash.as_ref().and_then(|t| t.limit)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.table.unsplash.as_ref().and_then(|t| t.limit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:333:22 [INFO] [stderr] | [INFO] [stderr] 333 | secs.or(self.table.unsplash.as_ref().and_then(|t| t.refresh)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.table.unsplash.as_ref().and_then(|t| t.refresh))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.16s [INFO] running `"docker" "inspect" "f846fb09a18cc600f4bf067896e450f4c69089bbb3525963cb5546751bb6d034"` [INFO] running `"docker" "rm" "-f" "f846fb09a18cc600f4bf067896e450f4c69089bbb3525963cb5546751bb6d034"` [INFO] [stdout] f846fb09a18cc600f4bf067896e450f4c69089bbb3525963cb5546751bb6d034