[INFO] updating cached repository yrjok/Raspberry-Pi-Drive-Client [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yrjok/Raspberry-Pi-Drive-Client [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yrjok/Raspberry-Pi-Drive-Client" "work/ex/clippy-test-run/sources/stable/gh/yrjok/Raspberry-Pi-Drive-Client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yrjok/Raspberry-Pi-Drive-Client'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yrjok/Raspberry-Pi-Drive-Client" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yrjok/Raspberry-Pi-Drive-Client"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yrjok/Raspberry-Pi-Drive-Client'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a93b86e2f57eceb2cba615e3b54e38c7335579b2 [INFO] sha for GitHub repo yrjok/Raspberry-Pi-Drive-Client: a93b86e2f57eceb2cba615e3b54e38c7335579b2 [INFO] validating manifest of yrjok/Raspberry-Pi-Drive-Client on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yrjok/Raspberry-Pi-Drive-Client on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yrjok/Raspberry-Pi-Drive-Client [INFO] finished frobbing yrjok/Raspberry-Pi-Drive-Client [INFO] frobbed toml for yrjok/Raspberry-Pi-Drive-Client written to work/ex/clippy-test-run/sources/stable/gh/yrjok/Raspberry-Pi-Drive-Client/Cargo.toml [INFO] started frobbing yrjok/Raspberry-Pi-Drive-Client [INFO] finished frobbing yrjok/Raspberry-Pi-Drive-Client [INFO] frobbed toml for yrjok/Raspberry-Pi-Drive-Client written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yrjok/Raspberry-Pi-Drive-Client/Cargo.toml [INFO] crate yrjok/Raspberry-Pi-Drive-Client has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yrjok/Raspberry-Pi-Drive-Client against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yrjok/Raspberry-Pi-Drive-Client:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9690c5146af2d445e0bb04f8e61dde488a926cd00e3a3be1cee4f79e8fc1eaa2 [INFO] running `"docker" "start" "-a" "9690c5146af2d445e0bb04f8e61dde488a926cd00e3a3be1cee4f79e8fc1eaa2"` [INFO] [stderr] Checking rapid_client v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/input.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | if let Ok(n) = res { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DISCONNECT` [INFO] [stderr] --> src/communication.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | DISCONNECT, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MESSAGE` [INFO] [stderr] --> src/communication.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | MESSAGE(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/communication.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | self.connection.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/communication.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | if let Err(_) = writer.write_all(payload.as_bytes()) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 78 | | return Err("Failed to send message to server.") [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________- help: try this: `if writer.write_all(payload.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/communication.rs:97:42 [INFO] [stderr] | [INFO] [stderr] 97 | let mut entries = response.split("\t"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/communication.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | if args.len() == 0 { return Err("Input is empty.")} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:8:25 [INFO] [stderr] | [INFO] [stderr] 8 | if let Some(host) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/input.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | if let Ok(n) = res { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DISCONNECT` [INFO] [stderr] --> src/communication.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | DISCONNECT, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MESSAGE` [INFO] [stderr] --> src/communication.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | MESSAGE(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/communication.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | self.connection.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/communication.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | if let Err(_) = writer.write_all(payload.as_bytes()) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 78 | | return Err("Failed to send message to server.") [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____________- help: try this: `if writer.write_all(payload.as_bytes()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/communication.rs:97:42 [INFO] [stderr] | [INFO] [stderr] 97 | let mut entries = response.split("\t"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/communication.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | if args.len() == 0 { return Err("Input is empty.")} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:8:25 [INFO] [stderr] | [INFO] [stderr] 8 | if let Some(host) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "9690c5146af2d445e0bb04f8e61dde488a926cd00e3a3be1cee4f79e8fc1eaa2"` [INFO] running `"docker" "rm" "-f" "9690c5146af2d445e0bb04f8e61dde488a926cd00e3a3be1cee4f79e8fc1eaa2"` [INFO] [stdout] 9690c5146af2d445e0bb04f8e61dde488a926cd00e3a3be1cee4f79e8fc1eaa2