[INFO] updating cached repository ypkulkar/postfix_evaluator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ypkulkar/postfix_evaluator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ypkulkar/postfix_evaluator" "work/ex/clippy-test-run/sources/stable/gh/ypkulkar/postfix_evaluator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ypkulkar/postfix_evaluator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ypkulkar/postfix_evaluator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/postfix_evaluator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/postfix_evaluator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 035212e7174dd5349a9032a0a7eb226bbabfc623 [INFO] sha for GitHub repo ypkulkar/postfix_evaluator: 035212e7174dd5349a9032a0a7eb226bbabfc623 [INFO] validating manifest of ypkulkar/postfix_evaluator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ypkulkar/postfix_evaluator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ypkulkar/postfix_evaluator [INFO] finished frobbing ypkulkar/postfix_evaluator [INFO] frobbed toml for ypkulkar/postfix_evaluator written to work/ex/clippy-test-run/sources/stable/gh/ypkulkar/postfix_evaluator/Cargo.toml [INFO] started frobbing ypkulkar/postfix_evaluator [INFO] finished frobbing ypkulkar/postfix_evaluator [INFO] frobbed toml for ypkulkar/postfix_evaluator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/postfix_evaluator/Cargo.toml [INFO] crate ypkulkar/postfix_evaluator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ypkulkar/postfix_evaluator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ypkulkar/postfix_evaluator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29b45a250e5ec0d38e140b652949ca70ea8068b485730d05e771384f9dac9d55 [INFO] running `"docker" "start" "-a" "29b45a250e5ec0d38e140b652949ca70ea8068b485730d05e771384f9dac9d55"` [INFO] [stderr] Checking your v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:6 [INFO] [stderr] | [INFO] [stderr] 71 | return Some(stack[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(stack[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:6 [INFO] [stderr] | [INFO] [stderr] 71 | return Some(stack[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(stack[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:22:8 [INFO] [stderr] | [INFO] [stderr] 22 | / match token{ [INFO] [stderr] 23 | | &Token::Operand(token) => stack.push(token), [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | &Token::Operator(ref x) => { [INFO] [stderr] ... | [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *token{ [INFO] [stderr] 23 | Token::Operand(token) => stack.push(token), [INFO] [stderr] 24 | [INFO] [stderr] 25 | Token::Operator(ref x) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | match x{ [INFO] [stderr] | ____________________^ [INFO] [stderr] 28 | | &Operator::Add => { [INFO] [stderr] 29 | | if stack.len() < 2{ [INFO] [stderr] 30 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *x{ [INFO] [stderr] 28 | Operator::Add => { [INFO] [stderr] 29 | if stack.len() < 2{ [INFO] [stderr] 30 | return None; [INFO] [stderr] 31 | } [INFO] [stderr] 32 | else{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:22:8 [INFO] [stderr] | [INFO] [stderr] 22 | / match token{ [INFO] [stderr] 23 | | &Token::Operand(token) => stack.push(token), [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | &Token::Operator(ref x) => { [INFO] [stderr] ... | [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *token{ [INFO] [stderr] 23 | Token::Operand(token) => stack.push(token), [INFO] [stderr] 24 | [INFO] [stderr] 25 | Token::Operator(ref x) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | match x{ [INFO] [stderr] | ____________________^ [INFO] [stderr] 28 | | &Operator::Add => { [INFO] [stderr] 29 | | if stack.len() < 2{ [INFO] [stderr] 30 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *x{ [INFO] [stderr] 28 | Operator::Add => { [INFO] [stderr] 29 | if stack.len() < 2{ [INFO] [stderr] 30 | return None; [INFO] [stderr] 31 | } [INFO] [stderr] 32 | else{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "29b45a250e5ec0d38e140b652949ca70ea8068b485730d05e771384f9dac9d55"` [INFO] running `"docker" "rm" "-f" "29b45a250e5ec0d38e140b652949ca70ea8068b485730d05e771384f9dac9d55"` [INFO] [stdout] 29b45a250e5ec0d38e140b652949ca70ea8068b485730d05e771384f9dac9d55