[INFO] updating cached repository ypkulkar/matrix_operator_overload [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ypkulkar/matrix_operator_overload [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ypkulkar/matrix_operator_overload" "work/ex/clippy-test-run/sources/stable/gh/ypkulkar/matrix_operator_overload"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ypkulkar/matrix_operator_overload'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ypkulkar/matrix_operator_overload" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/matrix_operator_overload"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/matrix_operator_overload'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0a120e243e3e05749de79fcf1ed0401bac9d5872 [INFO] sha for GitHub repo ypkulkar/matrix_operator_overload: 0a120e243e3e05749de79fcf1ed0401bac9d5872 [INFO] validating manifest of ypkulkar/matrix_operator_overload on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ypkulkar/matrix_operator_overload on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ypkulkar/matrix_operator_overload [INFO] finished frobbing ypkulkar/matrix_operator_overload [INFO] frobbed toml for ypkulkar/matrix_operator_overload written to work/ex/clippy-test-run/sources/stable/gh/ypkulkar/matrix_operator_overload/Cargo.toml [INFO] started frobbing ypkulkar/matrix_operator_overload [INFO] finished frobbing ypkulkar/matrix_operator_overload [INFO] frobbed toml for ypkulkar/matrix_operator_overload written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/matrix_operator_overload/Cargo.toml [INFO] crate ypkulkar/matrix_operator_overload has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ypkulkar/matrix_operator_overload against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ypkulkar/matrix_operator_overload:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02ad38038067e0b331e126b3b50a96511b92cae99408296f6a31592ccfa8a930 [INFO] running `"docker" "start" "-a" "02ad38038067e0b331e126b3b50a96511b92cae99408296f6a31592ccfa8a930"` [INFO] [stderr] Checking your v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:40 [INFO] [stderr] | [INFO] [stderr] 22 | let new_vector = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:48 [INFO] [stderr] | [INFO] [stderr] 22 | let new_vector = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:40 [INFO] [stderr] | [INFO] [stderr] 30 | let any_struct = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:48 [INFO] [stderr] | [INFO] [stderr] 30 | let any_struct = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:40 [INFO] [stderr] | [INFO] [stderr] 22 | let new_vector = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:48 [INFO] [stderr] | [INFO] [stderr] 22 | let new_vector = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:40 [INFO] [stderr] | [INFO] [stderr] 30 | let any_struct = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:48 [INFO] [stderr] | [INFO] [stderr] 30 | let any_struct = Matrix{data:v,row:row,col:col}; [INFO] [stderr] | ^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return new_vector; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_vector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return any_struct; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `any_struct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return new_vector; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_vector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return any_struct; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `any_struct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | let length = self.row*self.col; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | let length = self.row*self.col; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | string.push_str(&format!(" ")); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `" ".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:133:28 [INFO] [stderr] | [INFO] [stderr] 133 | string.push_str(&format!("\n")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | string.push_str(&format!("\n")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `your`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | let length = self.row*self.col; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | let length = self.row*self.col; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | string.push_str(&format!(" ")); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using .to_string(): `" ".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:133:28 [INFO] [stderr] | [INFO] [stderr] 133 | string.push_str(&format!("\n")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | string.push_str(&format!("\n")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `your`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "02ad38038067e0b331e126b3b50a96511b92cae99408296f6a31592ccfa8a930"` [INFO] running `"docker" "rm" "-f" "02ad38038067e0b331e126b3b50a96511b92cae99408296f6a31592ccfa8a930"` [INFO] [stdout] 02ad38038067e0b331e126b3b50a96511b92cae99408296f6a31592ccfa8a930