[INFO] updating cached repository youhavethewrong/hyperboop [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/youhavethewrong/hyperboop [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/youhavethewrong/hyperboop" "work/ex/clippy-test-run/sources/stable/gh/youhavethewrong/hyperboop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/youhavethewrong/hyperboop'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/youhavethewrong/hyperboop" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/youhavethewrong/hyperboop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/youhavethewrong/hyperboop'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 00caf586bf4d20b09ec28e320c1302158eedccb9 [INFO] sha for GitHub repo youhavethewrong/hyperboop: 00caf586bf4d20b09ec28e320c1302158eedccb9 [INFO] validating manifest of youhavethewrong/hyperboop on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of youhavethewrong/hyperboop on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing youhavethewrong/hyperboop [INFO] finished frobbing youhavethewrong/hyperboop [INFO] frobbed toml for youhavethewrong/hyperboop written to work/ex/clippy-test-run/sources/stable/gh/youhavethewrong/hyperboop/Cargo.toml [INFO] started frobbing youhavethewrong/hyperboop [INFO] finished frobbing youhavethewrong/hyperboop [INFO] frobbed toml for youhavethewrong/hyperboop written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/youhavethewrong/hyperboop/Cargo.toml [INFO] crate youhavethewrong/hyperboop has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting youhavethewrong/hyperboop against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/youhavethewrong/hyperboop:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1ae32e218b81bfadb38a9e7eaa3fcc6cf824817b0b1354aafb4206bff04b757 [INFO] running `"docker" "start" "-a" "d1ae32e218b81bfadb38a9e7eaa3fcc6cf824817b0b1354aafb4206bff04b757"` [INFO] [stderr] Checking byteorder v1.2.6 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Checking futures v0.1.24 [INFO] [stderr] Checking string v0.1.1 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking indexmap v1.0.1 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking lazy_static v1.1.0 [INFO] [stderr] Checking lock_api v0.1.4 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-executor v0.1.5 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking tokio-current-thread v0.1.3 [INFO] [stderr] Checking tokio-timer v0.2.7 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyperboop v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return current_guess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_guess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return current_guess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_guess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match req.method() { [INFO] [stderr] 33 | | &Method::GET => Response::new(Body::from(TEXT)), [INFO] [stderr] 34 | | &Method::POST => Response::new(Body::from(format!("{}", square_root(17)))), [INFO] [stderr] 35 | | _ => Response::new(Body::from("WTF is that supposed to be?")) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *req.method() { [INFO] [stderr] 33 | Method::GET => Response::new(Body::from(TEXT)), [INFO] [stderr] 34 | Method::POST => Response::new(Body::from(format!("{}", square_root(17)))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match req.method() { [INFO] [stderr] 33 | | &Method::GET => Response::new(Body::from(TEXT)), [INFO] [stderr] 34 | | &Method::POST => Response::new(Body::from(format!("{}", square_root(17)))), [INFO] [stderr] 35 | | _ => Response::new(Body::from("WTF is that supposed to be?")) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *req.method() { [INFO] [stderr] 33 | Method::GET => Response::new(Body::from(TEXT)), [INFO] [stderr] 34 | Method::POST => Response::new(Body::from(format!("{}", square_root(17)))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.04s [INFO] running `"docker" "inspect" "d1ae32e218b81bfadb38a9e7eaa3fcc6cf824817b0b1354aafb4206bff04b757"` [INFO] running `"docker" "rm" "-f" "d1ae32e218b81bfadb38a9e7eaa3fcc6cf824817b0b1354aafb4206bff04b757"` [INFO] [stdout] d1ae32e218b81bfadb38a9e7eaa3fcc6cf824817b0b1354aafb4206bff04b757