[INFO] updating cached repository yoshuawuyts/github_auth [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yoshuawuyts/github_auth [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yoshuawuyts/github_auth" "work/ex/clippy-test-run/sources/stable/gh/yoshuawuyts/github_auth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yoshuawuyts/github_auth'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yoshuawuyts/github_auth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yoshuawuyts/github_auth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yoshuawuyts/github_auth'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07abcd9db3aa8300a12b9864e0f3b3bdec4d9a1d [INFO] sha for GitHub repo yoshuawuyts/github_auth: 07abcd9db3aa8300a12b9864e0f3b3bdec4d9a1d [INFO] validating manifest of yoshuawuyts/github_auth on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yoshuawuyts/github_auth on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yoshuawuyts/github_auth [INFO] finished frobbing yoshuawuyts/github_auth [INFO] frobbed toml for yoshuawuyts/github_auth written to work/ex/clippy-test-run/sources/stable/gh/yoshuawuyts/github_auth/Cargo.toml [INFO] started frobbing yoshuawuyts/github_auth [INFO] finished frobbing yoshuawuyts/github_auth [INFO] frobbed toml for yoshuawuyts/github_auth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yoshuawuyts/github_auth/Cargo.toml [INFO] crate yoshuawuyts/github_auth has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yoshuawuyts/github_auth against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yoshuawuyts/github_auth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d375c5263f247a39d2531f37ab61eda8feaf993e1064ced136eea4b7593eac05 [INFO] running `"docker" "start" "-a" "d375c5263f247a39d2531f37ab61eda8feaf993e1064ced136eea4b7593eac05"` [INFO] [stderr] Compiling libc v0.2.40 [INFO] [stderr] Compiling cc v1.0.15 [INFO] [stderr] Compiling pkg-config v0.3.11 [INFO] [stderr] Compiling openssl v0.10.12 [INFO] [stderr] Checking stable_deref_trait v1.0.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking unicode-normalization v0.1.6 [INFO] [stderr] Compiling serde v1.0.79 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking rustc-demangle v0.1.7 [INFO] [stderr] Checking mkdirp v0.1.0 [INFO] [stderr] Compiling unicase v2.1.0 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking directories v1.0.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking base64 v0.9.1 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Compiling openssl-sys v0.9.36 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking encoding_rs v0.8.10 [INFO] [stderr] Checking tokio-timer v0.2.5 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking phf_shared v0.7.22 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking libflate v0.1.18 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling syn v0.15.9 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking mime v0.3.9 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking dialoguer v0.1.0 [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking backtrace v0.3.6 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking github_auth v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub const GITHUB_AUTH_URL: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub const GITHUB_AUTH_URL: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/authenticator.rs:70:8 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(remove_file(self.location()?)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 70 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/builder.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if let None = self.scopes { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 33 | | self.scopes = Some(vec![]); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____- help: try this: `if self.scopes.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `github_auth`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "d375c5263f247a39d2531f37ab61eda8feaf993e1064ced136eea4b7593eac05"` [INFO] running `"docker" "rm" "-f" "d375c5263f247a39d2531f37ab61eda8feaf993e1064ced136eea4b7593eac05"` [INFO] [stdout] d375c5263f247a39d2531f37ab61eda8feaf993e1064ced136eea4b7593eac05