[INFO] updating cached repository yorodm/shsh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yorodm/shsh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yorodm/shsh" "work/ex/clippy-test-run/sources/stable/gh/yorodm/shsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yorodm/shsh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yorodm/shsh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yorodm/shsh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yorodm/shsh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 05a174b49cb5e3c99d3783b5e650f6d56dae4235 [INFO] sha for GitHub repo yorodm/shsh: 05a174b49cb5e3c99d3783b5e650f6d56dae4235 [INFO] validating manifest of yorodm/shsh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yorodm/shsh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yorodm/shsh [INFO] finished frobbing yorodm/shsh [INFO] frobbed toml for yorodm/shsh written to work/ex/clippy-test-run/sources/stable/gh/yorodm/shsh/Cargo.toml [INFO] started frobbing yorodm/shsh [INFO] finished frobbing yorodm/shsh [INFO] frobbed toml for yorodm/shsh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yorodm/shsh/Cargo.toml [INFO] crate yorodm/shsh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yorodm/shsh against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yorodm/shsh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29b093339c39ea7210c21f2b8e9f0619e4c5cd666302d58d6cd83984b2a3a01c [INFO] running `"docker" "start" "-a" "29b093339c39ea7210c21f2b8e9f0619e4c5cd666302d58d6cd83984b2a3a01c"` [INFO] [stderr] Compiling nix v0.11.0 [INFO] [stderr] Checking unicode-segmentation v1.2.1 [INFO] [stderr] Checking utf8parse v0.1.1 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking rustyline v2.1.0 [INFO] [stderr] Checking shsh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | fn print_working_directory(args: &[&str]) -> io::Result<()> { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | "cd" => match change_directory(&v[1..]) { [INFO] [stderr] | _________________^ [INFO] [stderr] 44 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 45 | | _ => (), [INFO] [stderr] 46 | | }, [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = change_directory(&v[1..]) { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | "pwd" => match print_working_directory(&v[1..]) { [INFO] [stderr] | __________________^ [INFO] [stderr] 48 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | }, [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = print_working_directory(&v[1..]) { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | _ => match execute_external_commnd(&v) { [INFO] [stderr] | ______________^ [INFO] [stderr] 55 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 56 | | _ => (), [INFO] [stderr] 57 | | }, [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = execute_external_commnd(&v) { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | fn print_working_directory(args: &[&str]) -> io::Result<()> { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | "cd" => match change_directory(&v[1..]) { [INFO] [stderr] | _________________^ [INFO] [stderr] 44 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 45 | | _ => (), [INFO] [stderr] 46 | | }, [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = change_directory(&v[1..]) { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | "pwd" => match print_working_directory(&v[1..]) { [INFO] [stderr] | __________________^ [INFO] [stderr] 48 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | }, [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = print_working_directory(&v[1..]) { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | _ => match execute_external_commnd(&v) { [INFO] [stderr] | ______________^ [INFO] [stderr] 55 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 56 | | _ => (), [INFO] [stderr] 57 | | }, [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = execute_external_commnd(&v) { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.08s [INFO] running `"docker" "inspect" "29b093339c39ea7210c21f2b8e9f0619e4c5cd666302d58d6cd83984b2a3a01c"` [INFO] running `"docker" "rm" "-f" "29b093339c39ea7210c21f2b8e9f0619e4c5cd666302d58d6cd83984b2a3a01c"` [INFO] [stdout] 29b093339c39ea7210c21f2b8e9f0619e4c5cd666302d58d6cd83984b2a3a01c