[INFO] updating cached repository yogesum/snake-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yogesum/snake-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yogesum/snake-rs" "work/ex/clippy-test-run/sources/stable/gh/yogesum/snake-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yogesum/snake-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yogesum/snake-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/snake-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/snake-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 017b0d419a91188396833da7415ea50fa5dcc292 [INFO] sha for GitHub repo yogesum/snake-rs: 017b0d419a91188396833da7415ea50fa5dcc292 [INFO] validating manifest of yogesum/snake-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yogesum/snake-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yogesum/snake-rs [INFO] finished frobbing yogesum/snake-rs [INFO] frobbed toml for yogesum/snake-rs written to work/ex/clippy-test-run/sources/stable/gh/yogesum/snake-rs/Cargo.toml [INFO] started frobbing yogesum/snake-rs [INFO] finished frobbing yogesum/snake-rs [INFO] frobbed toml for yogesum/snake-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/snake-rs/Cargo.toml [INFO] crate yogesum/snake-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yogesum/snake-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yogesum/snake-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4cb082804ba6d0842998a2bbe102b01e1ad52a09b66159c3296502b9f7d225bc [INFO] running `"docker" "start" "-a" "4cb082804ba6d0842998a2bbe102b01e1ad52a09b66159c3296502b9f7d225bc"` [INFO] [stderr] Compiling libc v0.2.37 [INFO] [stderr] Compiling num-traits v0.2.1 [INFO] [stderr] Compiling dtoa v0.4.2 [INFO] [stderr] Compiling serde v0.9.15 [INFO] [stderr] Compiling itoa v0.3.4 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Compiling cfg-if v0.1.2 [INFO] [stderr] Compiling bitflags v1.0.1 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Compiling either v1.4.0 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Compiling khronos_api v2.1.0 [INFO] [stderr] Checking serde v1.0.27 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Compiling xml-rs v0.6.1 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Compiling x11-dl v2.17.3 [INFO] [stderr] Checking draw_state v0.7.1 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking deflate v0.7.17 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Checking crossbeam-epoch v0.3.0 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling wayland-scanner v0.9.10 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling serde_derive_internals v0.19.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling wayland-client v0.9.10 [INFO] [stderr] Compiling wayland-protocols v0.9.10 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Compiling serde_derive v1.0.27 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking piston-gfx_texture v0.30.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.47.0 [INFO] [stderr] Checking piston_window v0.74.0 [INFO] [stderr] Checking snake-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | BLOCK_SIZE * (height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match dir { [INFO] [stderr] 76 | | Some(d) => self.direction = d, [INFO] [stderr] 77 | | None => (), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match dir { [INFO] [stderr] 114 | | Some(d) => moving_dir = d, [INFO] [stderr] 115 | | None => {}, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | BLOCK_SIZE * (width as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | BLOCK_SIZE * (height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match dir { [INFO] [stderr] 76 | | Some(d) => self.direction = d, [INFO] [stderr] 77 | | None => (), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { self.direction = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match dir { [INFO] [stderr] 114 | | Some(d) => moving_dir = d, [INFO] [stderr] 115 | | None => {}, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = dir { moving_dir = d }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 08s [INFO] running `"docker" "inspect" "4cb082804ba6d0842998a2bbe102b01e1ad52a09b66159c3296502b9f7d225bc"` [INFO] running `"docker" "rm" "-f" "4cb082804ba6d0842998a2bbe102b01e1ad52a09b66159c3296502b9f7d225bc"` [INFO] [stdout] 4cb082804ba6d0842998a2bbe102b01e1ad52a09b66159c3296502b9f7d225bc