[INFO] updating cached repository yogesum/pong-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yogesum/pong-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yogesum/pong-rs" "work/ex/clippy-test-run/sources/stable/gh/yogesum/pong-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yogesum/pong-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yogesum/pong-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/pong-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/pong-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd11ff9dac780b5620360919a5f83cec7d59e2da [INFO] sha for GitHub repo yogesum/pong-rs: bd11ff9dac780b5620360919a5f83cec7d59e2da [INFO] validating manifest of yogesum/pong-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yogesum/pong-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yogesum/pong-rs [INFO] finished frobbing yogesum/pong-rs [INFO] frobbed toml for yogesum/pong-rs written to work/ex/clippy-test-run/sources/stable/gh/yogesum/pong-rs/Cargo.toml [INFO] started frobbing yogesum/pong-rs [INFO] finished frobbing yogesum/pong-rs [INFO] frobbed toml for yogesum/pong-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/pong-rs/Cargo.toml [INFO] crate yogesum/pong-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yogesum/pong-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yogesum/pong-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2f100eff84fdc13209841c30c1417758c50ff1e87ff86b0fa48ce4953d4dc266 [INFO] running `"docker" "start" "-a" "2f100eff84fdc13209841c30c1417758c50ff1e87ff86b0fa48ce4953d4dc266"` [INFO] [stderr] Compiling libc v0.2.40 [INFO] [stderr] Compiling num-traits v0.2.2 [INFO] [stderr] Compiling serde v0.9.15 [INFO] [stderr] Compiling itoa v0.3.4 [INFO] [stderr] Compiling dtoa v0.4.2 [INFO] [stderr] Compiling bitflags v0.9.1 [INFO] [stderr] Compiling cfg-if v0.1.2 [INFO] [stderr] Compiling bitflags v1.0.1 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking serde v1.0.37 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking linked-hash-map v0.5.1 [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Compiling proc-macro2 v0.3.6 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Compiling xml-rs v0.6.1 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Compiling quote v0.5.1 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling wayland-scanner v0.9.10 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Compiling wayland-client v0.9.10 [INFO] [stderr] Compiling wayland-protocols v0.9.10 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling serde_derive_internals v0.23.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Compiling serde_derive v1.0.37 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.50.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking pong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | let left_pos = self.left_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.left_pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let right_pos = self.right_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.right_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | let ball_x = self.ball_x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | let ball_y = self.ball_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | c.transform.trans(args.width as f64 - 10.0, right_pos), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pong.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pong.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 108 | | match key { [INFO] [stderr] 109 | | Key::Up => { [INFO] [stderr] 110 | | self.right_vel = -1; [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 107 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pong.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 128 | | match key { [INFO] [stderr] 129 | | Key::Up => { [INFO] [stderr] 130 | | self.right_vel = 0; [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | let left_pos = self.left_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.left_pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let right_pos = self.right_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.right_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | let ball_x = self.ball_x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | let ball_y = self.ball_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pong.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | c.transform.trans(args.width as f64 - 10.0, right_pos), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pong.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pong.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 108 | | match key { [INFO] [stderr] 109 | | Key::Up => { [INFO] [stderr] 110 | | self.right_vel = -1; [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 107 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pong.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 128 | | match key { [INFO] [stderr] 129 | | Key::Up => { [INFO] [stderr] 130 | | self.right_vel = 0; [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 41s [INFO] running `"docker" "inspect" "2f100eff84fdc13209841c30c1417758c50ff1e87ff86b0fa48ce4953d4dc266"` [INFO] running `"docker" "rm" "-f" "2f100eff84fdc13209841c30c1417758c50ff1e87ff86b0fa48ce4953d4dc266"` [INFO] [stdout] 2f100eff84fdc13209841c30c1417758c50ff1e87ff86b0fa48ce4953d4dc266