[INFO] updating cached repository yogesum/blog_api-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yogesum/blog_api-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yogesum/blog_api-rs" "work/ex/clippy-test-run/sources/stable/gh/yogesum/blog_api-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yogesum/blog_api-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yogesum/blog_api-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/blog_api-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/blog_api-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91a54a73f37f61f8834da7fc2852f5d68d6a2ad7 [INFO] sha for GitHub repo yogesum/blog_api-rs: 91a54a73f37f61f8834da7fc2852f5d68d6a2ad7 [INFO] validating manifest of yogesum/blog_api-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yogesum/blog_api-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yogesum/blog_api-rs [INFO] finished frobbing yogesum/blog_api-rs [INFO] frobbed toml for yogesum/blog_api-rs written to work/ex/clippy-test-run/sources/stable/gh/yogesum/blog_api-rs/Cargo.toml [INFO] started frobbing yogesum/blog_api-rs [INFO] finished frobbing yogesum/blog_api-rs [INFO] frobbed toml for yogesum/blog_api-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogesum/blog_api-rs/Cargo.toml [INFO] crate yogesum/blog_api-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yogesum/blog_api-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yogesum/blog_api-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 61f0a5900d109c8bb3cbe97f1624ce9e5b040f18a1b466ec8c7a835ebdcc55d9 [INFO] running `"docker" "start" "-a" "61f0a5900d109c8bb3cbe97f1624ce9e5b040f18a1b466ec8c7a835ebdcc55d9"` [INFO] [stderr] Checking num-traits v0.2.2 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Checking route-recognizer v0.1.12 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking conduit-mime-types v0.7.3 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking hpack v0.2.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking uuid v0.2.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking solicit v0.4.4 [INFO] [stderr] Checking hyper v0.9.18 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Checking router v0.4.0 [INFO] [stderr] Checking logger v0.2.0 [INFO] [stderr] Checking blog_api v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/handlers.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/handlers.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/handlers.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/handlers.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handlers.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | iterator.find(|p| p.uuid() == id).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iterator.find(|p| p.uuid() == id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handlers.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let ref post_id = get_http_params!(req, "id"); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 121 | let post_id = &(match $r.extensions.get::() { [INFO] [stderr] 122 | Some(router) => { [INFO] [stderr] 123 | match router.find($e) { [INFO] [stderr] 124 | Some(v) => v, [INFO] [stderr] 125 | None => return Ok(Response::with(status::BadRequest)), [INFO] [stderr] 126 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/handlers.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | iterator.find(|p| p.uuid() == id).map(|p| p.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iterator.find(|p| p.uuid() == id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/handlers.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let ref post_id = get_http_params!(req, "id"); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 121 | let post_id = &(match $r.extensions.get::() { [INFO] [stderr] 122 | Some(router) => { [INFO] [stderr] 123 | match router.find($e) { [INFO] [stderr] 124 | Some(v) => v, [INFO] [stderr] 125 | None => return Ok(Response::with(status::BadRequest)), [INFO] [stderr] 126 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.16s [INFO] running `"docker" "inspect" "61f0a5900d109c8bb3cbe97f1624ce9e5b040f18a1b466ec8c7a835ebdcc55d9"` [INFO] running `"docker" "rm" "-f" "61f0a5900d109c8bb3cbe97f1624ce9e5b040f18a1b466ec8c7a835ebdcc55d9"` [INFO] [stdout] 61f0a5900d109c8bb3cbe97f1624ce9e5b040f18a1b466ec8c7a835ebdcc55d9