[INFO] updating cached repository yoctoctet/chip8-dasm
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/yoctoctet/chip8-dasm
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/yoctoctet/chip8-dasm" "work/ex/clippy-test-run/sources/stable/gh/yoctoctet/chip8-dasm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yoctoctet/chip8-dasm'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/yoctoctet/chip8-dasm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yoctoctet/chip8-dasm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yoctoctet/chip8-dasm'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0691dd17e937b131c44f60aed1ef3c985f73c083
[INFO] sha for GitHub repo yoctoctet/chip8-dasm: 0691dd17e937b131c44f60aed1ef3c985f73c083
[INFO] validating manifest of yoctoctet/chip8-dasm on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of yoctoctet/chip8-dasm on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing yoctoctet/chip8-dasm
[INFO] finished frobbing yoctoctet/chip8-dasm
[INFO] frobbed toml for yoctoctet/chip8-dasm written to work/ex/clippy-test-run/sources/stable/gh/yoctoctet/chip8-dasm/Cargo.toml
[INFO] started frobbing yoctoctet/chip8-dasm
[INFO] finished frobbing yoctoctet/chip8-dasm
[INFO] frobbed toml for yoctoctet/chip8-dasm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yoctoctet/chip8-dasm/Cargo.toml
[INFO] crate yoctoctet/chip8-dasm has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting yoctoctet/chip8-dasm against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yoctoctet/chip8-dasm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7a400268f862613516c1f94dabdd68e3366f19c860ca2cfd6786beed0d55ca66
[INFO] running `"docker" "start" "-a" "7a400268f862613516c1f94dabdd68e3366f19c860ca2cfd6786beed0d55ca66"`
[INFO] [stderr]    Compiling version_check v0.1.4
[INFO] [stderr]    Compiling lazy_static v1.1.0
[INFO] [stderr]     Checking colored v1.6.1
[INFO] [stderr]     Checking chip8-dasm v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/program.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             print!("\n");
[INFO] [stderr]    |             ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/program.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             print!("\n");
[INFO] [stderr]    |             ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `disassembler::disassemble`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use disassembler::disassemble;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/disassembler.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return Ok(data);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `disassembler::disassemble`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use disassembler::disassemble;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/disassembler.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 |     return Ok(data);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `y`
[INFO] [stderr]    --> src/op.rs:153:42
[INFO] [stderr]     |
[INFO] [stderr] 153 |                     Operation::Op8xy6(x, y) => {
[INFO] [stderr]     |                                          ^ help: consider using `_y` instead
[INFO] [stderr] warning: unused variable: `y`
[INFO] [stderr]    --> src/op.rs:153:42
[INFO] [stderr]     |
[INFO] [stderr] 153 |                     Operation::Op8xy6(x, y) => {
[INFO] [stderr]     |                                          ^ help: consider using `_y` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `y`
[INFO] [stderr]    --> src/op.rs:161:42
[INFO] [stderr]     |
[INFO] [stderr] 161 |                     Operation::Op8xyE(x, y) => {
[INFO] [stderr]     |                                          ^ help: consider using `_y` instead
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `y`
[INFO] [stderr]    --> src/op.rs:161:42
[INFO] [stderr]     |
[INFO] [stderr] 161 |                     Operation::Op8xyE(x, y) => {
[INFO] [stderr]     |                                          ^ help: consider using `_y` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `DisassemblerError`
[INFO] [stderr]   --> src/disassembler.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     DisassemblerError,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `DisassemblerError`
[INFO] [stderr]   --> src/disassembler.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     DisassemblerError,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/op.rs:250:25
[INFO] [stderr]     |
[INFO] [stderr] 250 | fn format_register(num: &u8) -> ColoredString {
[INFO] [stderr]     |                         ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/disassembler.rs:21:28
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let opcode: u16 = ((data[i] as u16) << 8) | (data[i + 1] as u16);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/disassembler.rs:21:53
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let opcode: u16 = ((data[i] as u16) << 8) | (data[i + 1] as u16);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/op.rs:250:25
[INFO] [stderr]     |
[INFO] [stderr] 250 | fn format_register(num: &u8) -> ColoredString {
[INFO] [stderr]     |                         ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/disassembler.rs:21:28
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let opcode: u16 = ((data[i] as u16) << 8) | (data[i + 1] as u16);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/disassembler.rs:21:53
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let opcode: u16 = ((data[i] as u16) << 8) | (data[i + 1] as u16);
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.10s
[INFO] running `"docker" "inspect" "7a400268f862613516c1f94dabdd68e3366f19c860ca2cfd6786beed0d55ca66"`
[INFO] running `"docker" "rm" "-f" "7a400268f862613516c1f94dabdd68e3366f19c860ca2cfd6786beed0d55ca66"`
[INFO] [stdout] 7a400268f862613516c1f94dabdd68e3366f19c860ca2cfd6786beed0d55ca66