[INFO] updating cached repository yochidros/example_scraper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yochidros/example_scraper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yochidros/example_scraper" "work/ex/clippy-test-run/sources/stable/gh/yochidros/example_scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yochidros/example_scraper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yochidros/example_scraper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yochidros/example_scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yochidros/example_scraper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6f7234438278c03f2c764ac7aaec3214bf7a2a45 [INFO] sha for GitHub repo yochidros/example_scraper: 6f7234438278c03f2c764ac7aaec3214bf7a2a45 [INFO] validating manifest of yochidros/example_scraper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yochidros/example_scraper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yochidros/example_scraper [INFO] finished frobbing yochidros/example_scraper [INFO] frobbed toml for yochidros/example_scraper written to work/ex/clippy-test-run/sources/stable/gh/yochidros/example_scraper/Cargo.toml [INFO] started frobbing yochidros/example_scraper [INFO] finished frobbing yochidros/example_scraper [INFO] frobbed toml for yochidros/example_scraper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yochidros/example_scraper/Cargo.toml [INFO] crate yochidros/example_scraper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yochidros/example_scraper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yochidros/example_scraper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32cdac01ef2ed39ab176040a20dc8ba9baf26dbcd04ee00f66470439f424d012 [INFO] running `"docker" "start" "-a" "32cdac01ef2ed39ab176040a20dc8ba9baf26dbcd04ee00f66470439f424d012"` [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Compiling pkg-config v0.3.11 [INFO] [stderr] Compiling string_cache_shared v0.3.0 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling serde v1.0.55 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Compiling procedural-masquerade v0.1.5 [INFO] [stderr] Checking utf-8 v0.7.2 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Checking ego-tree v0.3.0 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Compiling proc-macro2 v0.3.8 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling openssl-sys v0.9.30 [INFO] [stderr] Checking dtoa-short v0.3.2 [INFO] [stderr] Checking base64 v0.9.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking debug_unreachable v0.1.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking futf v0.1.3 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Compiling syn v0.13.10 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking libflate v0.1.14 [INFO] [stderr] Checking tendril v0.4.0 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Compiling selectors v0.19.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Compiling string_cache v0.7.2 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.26 [INFO] [stderr] Compiling serde_derive v1.0.55 [INFO] [stderr] Compiling cssparser v0.23.7 [INFO] [stderr] Compiling html5ever v0.22.3 [INFO] [stderr] Compiling cssparser-macros v0.3.3 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Compiling markup5ever v0.7.2 [INFO] [stderr] Checking scraper v0.6.0 [INFO] [stderr] Checking example_scape v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/country/mod.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | countries: countries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `countries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/country/mod.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | countries: countries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `countries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models/country/mod.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn create<'a>(languages: &'a Vec) -> CountryData { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/models/country/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn create<'a>(languages: &'a Vec) -> CountryData { [INFO] [stderr] 13 | | let mut countries: Vec = Vec::new(); [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | for lang in languages.iter() { [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/scraper/mod.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / fn check_status_code<'a>(response: &'a reqwest::Response) -> bool { [INFO] [stderr] 39 | | match response.status() { [INFO] [stderr] 40 | | reqwest::StatusCode::Ok => true, [INFO] [stderr] 41 | | _ => false, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serializer/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn serialize_from_countries<'a>(object: &'a country::CountryData) -> String { [INFO] [stderr] 7 | | serde_json::to_string(&object).unwrap() [INFO] [stderr] 8 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/models/country/mod.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn create<'a>(languages: &'a Vec) -> CountryData { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/models/country/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn create<'a>(languages: &'a Vec) -> CountryData { [INFO] [stderr] 13 | | let mut countries: Vec = Vec::new(); [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | for lang in languages.iter() { [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/scraper/mod.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / fn check_status_code<'a>(response: &'a reqwest::Response) -> bool { [INFO] [stderr] 39 | | match response.status() { [INFO] [stderr] 40 | | reqwest::StatusCode::Ok => true, [INFO] [stderr] 41 | | _ => false, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/serializer/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn serialize_from_countries<'a>(object: &'a country::CountryData) -> String { [INFO] [stderr] 7 | | serde_json::to_string(&object).unwrap() [INFO] [stderr] 8 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 43s [INFO] running `"docker" "inspect" "32cdac01ef2ed39ab176040a20dc8ba9baf26dbcd04ee00f66470439f424d012"` [INFO] running `"docker" "rm" "-f" "32cdac01ef2ed39ab176040a20dc8ba9baf26dbcd04ee00f66470439f424d012"` [INFO] [stdout] 32cdac01ef2ed39ab176040a20dc8ba9baf26dbcd04ee00f66470439f424d012