[INFO] updating cached repository yjh0502/serde-gen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yjh0502/serde-gen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yjh0502/serde-gen" "work/ex/clippy-test-run/sources/stable/gh/yjh0502/serde-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yjh0502/serde-gen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yjh0502/serde-gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yjh0502/serde-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yjh0502/serde-gen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 49e2206cd55dc46e357855cc01fd455fb6a9f055 [INFO] sha for GitHub repo yjh0502/serde-gen: 49e2206cd55dc46e357855cc01fd455fb6a9f055 [INFO] validating manifest of yjh0502/serde-gen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yjh0502/serde-gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yjh0502/serde-gen [INFO] finished frobbing yjh0502/serde-gen [INFO] frobbed toml for yjh0502/serde-gen written to work/ex/clippy-test-run/sources/stable/gh/yjh0502/serde-gen/Cargo.toml [INFO] started frobbing yjh0502/serde-gen [INFO] finished frobbing yjh0502/serde-gen [INFO] frobbed toml for yjh0502/serde-gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yjh0502/serde-gen/Cargo.toml [INFO] crate yjh0502/serde-gen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yjh0502/serde-gen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yjh0502/serde-gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae29e42c5b33662ca56a4a58e50ed6cabcd6dcd933aa8aa2d16cc2d34757a642 [INFO] running `"docker" "start" "-a" "ae29e42c5b33662ca56a4a58e50ed6cabcd6dcd933aa8aa2d16cc2d34757a642"` [INFO] [stderr] Compiling gcc v0.3.50 [INFO] [stderr] Checking libc v0.2.23 [INFO] [stderr] Checking rustc-demangle v0.1.4 [INFO] [stderr] Checking cfg-if v0.1.1 [INFO] [stderr] Checking bitflags v0.8.2 [INFO] [stderr] Checking dtoa v0.4.1 [INFO] [stderr] Checking itoa v0.3.1 [INFO] [stderr] Checking serde v1.0.8 [INFO] [stderr] Compiling serde_derive_internals v0.15.1 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Compiling serde_derive v1.0.8 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking serde-gen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | write!(w, "{}\n", builder.build(v))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | write!(w, "{}\n", builder.build(v))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `TyBuilder` [INFO] [stderr] --> src/lib.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new() -> Self { [INFO] [stderr] 83 | | TyBuilder { [INFO] [stderr] 84 | | names: HashMap::new(), [INFO] [stderr] 85 | | queue: Vec::new(), [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | *idx = *idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `*idx += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | let name = format!("Root"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Root".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `TyBuilder` [INFO] [stderr] --> src/lib.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new() -> Self { [INFO] [stderr] 83 | | TyBuilder { [INFO] [stderr] 84 | | names: HashMap::new(), [INFO] [stderr] 85 | | queue: Vec::new(), [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | *idx = *idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `*idx += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | let name = format!("Root"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Root".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/serde_gen.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | Some(filename) => write!(&mut File::create(filename)?, "{}\n", out)?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/serde_gen.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | None => write!(&mut std::io::stdout(), "{}\n", out)?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/serde_gen.rs:41:27 [INFO] [stderr] | [INFO] [stderr] 41 | Some(filename) => write!(&mut File::create(filename)?, "{}\n", out)?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/serde_gen.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | None => write!(&mut std::io::stdout(), "{}\n", out)?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.28s [INFO] running `"docker" "inspect" "ae29e42c5b33662ca56a4a58e50ed6cabcd6dcd933aa8aa2d16cc2d34757a642"` [INFO] running `"docker" "rm" "-f" "ae29e42c5b33662ca56a4a58e50ed6cabcd6dcd933aa8aa2d16cc2d34757a642"` [INFO] [stdout] ae29e42c5b33662ca56a4a58e50ed6cabcd6dcd933aa8aa2d16cc2d34757a642