[INFO] updating cached repository yishn/Kalk
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/yishn/Kalk
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/yishn/Kalk" "work/ex/clippy-test-run/sources/stable/gh/yishn/Kalk"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yishn/Kalk'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/yishn/Kalk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yishn/Kalk"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yishn/Kalk'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8c45819137eb1d319001a019cde9e967d957cd94
[INFO] sha for GitHub repo yishn/Kalk: 8c45819137eb1d319001a019cde9e967d957cd94
[INFO] validating manifest of yishn/Kalk on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of yishn/Kalk on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing yishn/Kalk
[INFO] finished frobbing yishn/Kalk
[INFO] frobbed toml for yishn/Kalk written to work/ex/clippy-test-run/sources/stable/gh/yishn/Kalk/Cargo.toml
[INFO] started frobbing yishn/Kalk
[INFO] finished frobbing yishn/Kalk
[INFO] frobbed toml for yishn/Kalk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yishn/Kalk/Cargo.toml
[INFO] crate yishn/Kalk has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting yishn/Kalk against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yishn/Kalk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dd2d9b19592957b45ad748e02f830151563aa338004db7cd647598995715e900
[INFO] running `"docker" "start" "-a" "dd2d9b19592957b45ad748e02f830151563aa338004db7cd647598995715e900"`
[INFO] [stderr]    Compiling pest v1.0.6
[INFO] [stderr]    Compiling pest_derive v1.0.7
[INFO] [stderr]     Checking kalk v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: method is never used: `new_finite`
[INFO] [stderr]    --> src/types.rs:208:5
[INFO] [stderr]     |
[INFO] [stderr] 208 |     fn new_finite(start: f64, step: f64, stop: f64) -> ArithmeticProgression {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new_infinite`
[INFO] [stderr]    --> src/types.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     fn new_infinite(start: f64, step: f64) -> ArithmeticProgression {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new_finite`
[INFO] [stderr]    --> src/types.rs:208:5
[INFO] [stderr]     |
[INFO] [stderr] 208 |     fn new_finite(start: f64, step: f64, stop: f64) -> ArithmeticProgression {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new_infinite`
[INFO] [stderr]    --> src/types.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 |     fn new_infinite(start: f64, step: f64) -> ArithmeticProgression {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/types.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match self {
[INFO] [stderr] 22 | |             &Number(_) => true,
[INFO] [stderr] 23 | |             _ => false
[INFO] [stderr] 24 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 21 |         match *self {
[INFO] [stderr] 22 |             Number(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/types.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         match self {
[INFO] [stderr] 29 | |             &Number(_) => (1, 1),
[INFO] [stderr] 30 | |             &Matrix(ref data, width) => match (width, data.len()) {
[INFO] [stderr] 31 | |                 (0, _) => (0, 0),
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |             }
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 28 |         match *self {
[INFO] [stderr] 29 |             Number(_) => (1, 1),
[INFO] [stderr] 30 |             Matrix(ref data, width) => match (width, data.len()) {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/types.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self {
[INFO] [stderr] 40 | |             &Number(a) => Ok(Number(-a)),
[INFO] [stderr] 41 | |             &Matrix(ref data, width) => Ok(Matrix(
[INFO] [stderr] 42 | |                 data.iter()
[INFO] [stderr] ...  |
[INFO] [stderr] 48 | |             ))
[INFO] [stderr] 49 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 39 |         match *self {
[INFO] [stderr] 40 |             Number(a) => Ok(Number(-a)),
[INFO] [stderr] 41 |             Matrix(ref data, width) => Ok(Matrix(
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/types.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 | /         match self {
[INFO] [stderr] 134 | |             &Number(a) => write!(f, "{}", a),
[INFO] [stderr] 135 | |             &Matrix(ref data, _) => {
[INFO] [stderr] 136 | |                 let (height, width) = self.size();
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             }
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 133 |         match *self {
[INFO] [stderr] 134 |             Number(a) => write!(f, "{}", a),
[INFO] [stderr] 135 |             Matrix(ref data, _) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/types.rs:143:41
[INFO] [stderr]     |
[INFO] [stderr] 143 |                           result.push_str(match f.alternate() {
[INFO] [stderr]     |  _________________________________________^
[INFO] [stderr] 144 | |                             true => ";\n ",
[INFO] [stderr] 145 | |                             false => "; "
[INFO] [stderr] 146 | |                         });
[INFO] [stderr]     | |_________________________^ help: consider using an if/else expression: `if f.alternate() { ";\n " } else { "; " }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/types.rs:223:35
[INFO] [stderr]     |
[INFO] [stderr] 223 |                 .map(|i| self.0 + (i as f64) * self.1)
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state::State`
[INFO] [stderr]   --> src/state.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> State {
[INFO] [stderr] 13 | |         State {
[INFO] [stderr] 14 | |             vars: HashMap::new(),
[INFO] [stderr] 15 | |             cache: RefCell::new(HashMap::new())
[INFO] [stderr] 16 | |         }
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/state.rs:95:42
[INFO] [stderr]    |
[INFO] [stderr] 95 |                   if rows.iter().any(|row| {
[INFO] [stderr]    |  __________________________________________^
[INFO] [stderr] 96 | |                     row.rule != Rule::matrix_row_lit
[INFO] [stderr] 97 | |                     || row.children.len() != width
[INFO] [stderr] 98 | |                 }) {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/types.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match self {
[INFO] [stderr] 22 | |             &Number(_) => true,
[INFO] [stderr] 23 | |             _ => false
[INFO] [stderr] 24 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 21 |         match *self {
[INFO] [stderr] 22 |             Number(_) => true,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/types.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         match self {
[INFO] [stderr] 29 | |             &Number(_) => (1, 1),
[INFO] [stderr] 30 | |             &Matrix(ref data, width) => match (width, data.len()) {
[INFO] [stderr] 31 | |                 (0, _) => (0, 0),
[INFO] [stderr] ...  |
[INFO] [stderr] 34 | |             }
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 28 |         match *self {
[INFO] [stderr] 29 |             Number(_) => (1, 1),
[INFO] [stderr] 30 |             Matrix(ref data, width) => match (width, data.len()) {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/types.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self {
[INFO] [stderr] 40 | |             &Number(a) => Ok(Number(-a)),
[INFO] [stderr] 41 | |             &Matrix(ref data, width) => Ok(Matrix(
[INFO] [stderr] 42 | |                 data.iter()
[INFO] [stderr] ...  |
[INFO] [stderr] 48 | |             ))
[INFO] [stderr] 49 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 39 |         match *self {
[INFO] [stderr] 40 |             Number(a) => Ok(Number(-a)),
[INFO] [stderr] 41 |             Matrix(ref data, width) => Ok(Matrix(
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/types.rs:133:9
[INFO] [stderr]     |
[INFO] [stderr] 133 | /         match self {
[INFO] [stderr] 134 | |             &Number(a) => write!(f, "{}", a),
[INFO] [stderr] 135 | |             &Matrix(ref data, _) => {
[INFO] [stderr] 136 | |                 let (height, width) = self.size();
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             }
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 133 |         match *self {
[INFO] [stderr] 134 |             Number(a) => write!(f, "{}", a),
[INFO] [stderr] 135 |             Matrix(ref data, _) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/types.rs:143:41
[INFO] [stderr]     |
[INFO] [stderr] 143 |                           result.push_str(match f.alternate() {
[INFO] [stderr]     |  _________________________________________^
[INFO] [stderr] 144 | |                             true => ";\n ",
[INFO] [stderr] 145 | |                             false => "; "
[INFO] [stderr] 146 | |                         });
[INFO] [stderr]     | |_________________________^ help: consider using an if/else expression: `if f.alternate() { ";\n " } else { "; " }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/types.rs:223:35
[INFO] [stderr]     |
[INFO] [stderr] 223 |                 .map(|i| self.0 + (i as f64) * self.1)
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state::State`
[INFO] [stderr]   --> src/state.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> State {
[INFO] [stderr] 13 | |         State {
[INFO] [stderr] 14 | |             vars: HashMap::new(),
[INFO] [stderr] 15 | |             cache: RefCell::new(HashMap::new())
[INFO] [stderr] 16 | |         }
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/state.rs:95:42
[INFO] [stderr]    |
[INFO] [stderr] 95 |                   if rows.iter().any(|row| {
[INFO] [stderr]    |  __________________________________________^
[INFO] [stderr] 96 | |                     row.rule != Rule::matrix_row_lit
[INFO] [stderr] 97 | |                     || row.children.len() != width
[INFO] [stderr] 98 | |                 }) {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.70s
[INFO] running `"docker" "inspect" "dd2d9b19592957b45ad748e02f830151563aa338004db7cd647598995715e900"`
[INFO] running `"docker" "rm" "-f" "dd2d9b19592957b45ad748e02f830151563aa338004db7cd647598995715e900"`
[INFO] [stdout] dd2d9b19592957b45ad748e02f830151563aa338004db7cd647598995715e900