[INFO] updating cached repository ygunayer/factrust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ygunayer/factrust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ygunayer/factrust" "work/ex/clippy-test-run/sources/stable/gh/ygunayer/factrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ygunayer/factrust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ygunayer/factrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ygunayer/factrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ygunayer/factrust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91d0efc499df3cf53809d1e76852c2022258c3b6 [INFO] sha for GitHub repo ygunayer/factrust: 91d0efc499df3cf53809d1e76852c2022258c3b6 [INFO] validating manifest of ygunayer/factrust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ygunayer/factrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ygunayer/factrust [INFO] finished frobbing ygunayer/factrust [INFO] frobbed toml for ygunayer/factrust written to work/ex/clippy-test-run/sources/stable/gh/ygunayer/factrust/Cargo.toml [INFO] started frobbing ygunayer/factrust [INFO] finished frobbing ygunayer/factrust [INFO] frobbed toml for ygunayer/factrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ygunayer/factrust/Cargo.toml [INFO] crate ygunayer/factrust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ygunayer/factrust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ygunayer/factrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13a7ff63a71d786489c09e4b4ad76b9e14fffd7f7e22281f9764b40e1a763b05 [INFO] running `"docker" "start" "-a" "13a7ff63a71d786489c09e4b4ad76b9e14fffd7f7e22281f9764b40e1a763b05"` [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking rustfact v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | is_parallel: is_parallel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_parallel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | is_parallel: is_parallel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_parallel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return self.sieve.get_or_insert_with(move || { [INFO] [stderr] 34 | | let iters: Vec<(i64, i64)> = iproduct!(2..limit, 2..limit).collect(); [INFO] [stderr] 35 | | if sync { [INFO] [stderr] 36 | | println!("snync"); [INFO] [stderr] ... | [INFO] [stderr] 48 | | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] 49 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | self.sieve.get_or_insert_with(move || { [INFO] [stderr] 34 | let iters: Vec<(i64, i64)> = iproduct!(2..limit, 2..limit).collect(); [INFO] [stderr] 35 | if sync { [INFO] [stderr] 36 | println!("snync"); [INFO] [stderr] 37 | let mut sieve: HashMap = HashMap::new(); [INFO] [stderr] 38 | for (a, b) in iters { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | / return iters [INFO] [stderr] 46 | | .par_iter() [INFO] [stderr] 47 | | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] 48 | | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | iters [INFO] [stderr] 46 | .par_iter() [INFO] [stderr] 47 | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] 48 | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:87 [INFO] [stderr] | [INFO] [stderr] 47 | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:70 [INFO] [stderr] | [INFO] [stderr] 48 | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return !*self.get_sieve().get(&n).unwrap_or(&false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!*self.get_sieve().get(&n).unwrap_or(&false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return factors; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `factors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return self.sieve.get_or_insert_with(move || { [INFO] [stderr] 34 | | let iters: Vec<(i64, i64)> = iproduct!(2..limit, 2..limit).collect(); [INFO] [stderr] 35 | | if sync { [INFO] [stderr] 36 | | println!("snync"); [INFO] [stderr] ... | [INFO] [stderr] 48 | | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] 49 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | self.sieve.get_or_insert_with(move || { [INFO] [stderr] 34 | let iters: Vec<(i64, i64)> = iproduct!(2..limit, 2..limit).collect(); [INFO] [stderr] 35 | if sync { [INFO] [stderr] 36 | println!("snync"); [INFO] [stderr] 37 | let mut sieve: HashMap = HashMap::new(); [INFO] [stderr] 38 | for (a, b) in iters { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | / return iters [INFO] [stderr] 46 | | .par_iter() [INFO] [stderr] 47 | | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] 48 | | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | iters [INFO] [stderr] 46 | .par_iter() [INFO] [stderr] 47 | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] 48 | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:87 [INFO] [stderr] | [INFO] [stderr] 47 | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `acc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:48:70 [INFO] [stderr] | [INFO] [stderr] 48 | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return !*self.get_sieve().get(&n).unwrap_or(&false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!*self.get_sieve().get(&n).unwrap_or(&false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return factors; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `factors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | .reduce(|| HashMap::new(), |mut a, b| { a.extend(b); return a; }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | .fold(|| HashMap::new(), |mut acc, (a, b)| { acc.insert(a * b, true); return acc; }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.86s [INFO] running `"docker" "inspect" "13a7ff63a71d786489c09e4b4ad76b9e14fffd7f7e22281f9764b40e1a763b05"` [INFO] running `"docker" "rm" "-f" "13a7ff63a71d786489c09e4b4ad76b9e14fffd7f7e22281f9764b40e1a763b05"` [INFO] [stdout] 13a7ff63a71d786489c09e4b4ad76b9e14fffd7f7e22281f9764b40e1a763b05