[INFO] updating cached repository yfaming/diesel_demo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yfaming/diesel_demo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yfaming/diesel_demo" "work/ex/clippy-test-run/sources/stable/gh/yfaming/diesel_demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yfaming/diesel_demo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yfaming/diesel_demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yfaming/diesel_demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yfaming/diesel_demo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] faa49c339d688d503240201f8d171105c79422f1 [INFO] sha for GitHub repo yfaming/diesel_demo: faa49c339d688d503240201f8d171105c79422f1 [INFO] validating manifest of yfaming/diesel_demo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yfaming/diesel_demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yfaming/diesel_demo [INFO] finished frobbing yfaming/diesel_demo [INFO] frobbed toml for yfaming/diesel_demo written to work/ex/clippy-test-run/sources/stable/gh/yfaming/diesel_demo/Cargo.toml [INFO] started frobbing yfaming/diesel_demo [INFO] finished frobbing yfaming/diesel_demo [INFO] frobbed toml for yfaming/diesel_demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yfaming/diesel_demo/Cargo.toml [INFO] crate yfaming/diesel_demo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yfaming/diesel_demo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yfaming/diesel_demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f21796b31930ab8fb5208dd4267e87074e44ef21e616528fb462ab91604be14 [INFO] running `"docker" "start" "-a" "9f21796b31930ab8fb5208dd4267e87074e44ef21e616528fb462ab91604be14"` [INFO] [stderr] Compiling matches v0.1.6 [INFO] [stderr] Compiling unicode-normalization v0.1.5 [INFO] [stderr] Compiling libc v0.2.24 [INFO] [stderr] Compiling percent-encoding v1.0.0 [INFO] [stderr] Compiling byteorder v1.0.0 [INFO] [stderr] Compiling utf8-ranges v1.0.0 [INFO] [stderr] Compiling regex-syntax v0.4.1 [INFO] [stderr] Compiling mysqlclient-sys v0.2.2 [INFO] [stderr] Compiling unreachable v0.1.1 [INFO] [stderr] Checking unicode-bidi v0.3.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling memchr v1.0.1 [INFO] [stderr] Compiling thread-id v3.1.0 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Compiling thread_local v0.3.3 [INFO] [stderr] Compiling aho-corasick v0.6.3 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Compiling regex v0.2.2 [INFO] [stderr] Checking url v1.5.0 [INFO] [stderr] Checking diesel v0.13.0 [INFO] [stderr] Compiling dotenv v0.9.0 [INFO] [stderr] Compiling diesel_infer_schema v0.13.0 [INFO] [stderr] Compiling diesel_codegen v0.13.0 [INFO] [stderr] Checking diesel_orm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/post.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/model/post.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | .expect(&format!("Unable to find post {}", post_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to find post {}", post_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/model/post.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | .expect(&format!("Error when delete post {}", post_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error when delete post {}", post_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/model/post.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | .expect(&format!("Unable to find post {}", post_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to find post {}", post_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/model/post.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | .expect(&format!("Error when delete post {}", post_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error when delete post {}", post_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "9f21796b31930ab8fb5208dd4267e87074e44ef21e616528fb462ab91604be14"` [INFO] running `"docker" "rm" "-f" "9f21796b31930ab8fb5208dd4267e87074e44ef21e616528fb462ab91604be14"` [INFO] [stdout] 9f21796b31930ab8fb5208dd4267e87074e44ef21e616528fb462ab91604be14