[INFO] updating cached repository yelcat/iot_hub [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yelcat/iot_hub [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yelcat/iot_hub" "work/ex/clippy-test-run/sources/stable/gh/yelcat/iot_hub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yelcat/iot_hub'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yelcat/iot_hub" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yelcat/iot_hub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yelcat/iot_hub'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d289d83665018ae062190551425188eb09c76b46 [INFO] sha for GitHub repo yelcat/iot_hub: d289d83665018ae062190551425188eb09c76b46 [INFO] validating manifest of yelcat/iot_hub on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yelcat/iot_hub on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yelcat/iot_hub [INFO] finished frobbing yelcat/iot_hub [INFO] frobbed toml for yelcat/iot_hub written to work/ex/clippy-test-run/sources/stable/gh/yelcat/iot_hub/Cargo.toml [INFO] started frobbing yelcat/iot_hub [INFO] finished frobbing yelcat/iot_hub [INFO] frobbed toml for yelcat/iot_hub written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yelcat/iot_hub/Cargo.toml [INFO] crate yelcat/iot_hub has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yelcat/iot_hub against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yelcat/iot_hub:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9f821b9f7fdbfaac47d3c074f20ccf9afd53d227316c4af5f5e91d7a95519fd [INFO] running `"docker" "start" "-a" "f9f821b9f7fdbfaac47d3c074f20ccf9afd53d227316c4af5f5e91d7a95519fd"` [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Checking regex-syntax v0.4.1 [INFO] [stderr] Checking serde v1.0.23 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Compiling serde_derive v1.0.23 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking tokio-core v0.1.11 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking serde_json v1.0.6 [INFO] [stderr] Checking iot_hub v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / pub fn new() -> Router { [INFO] [stderr] 77 | | Router { [INFO] [stderr] 78 | | children: Arc::new(RwLock::new(vec![])), [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/router.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / nodes [INFO] [stderr] 116 | | .iter() [INFO] [stderr] 117 | | .filter(|n| { [INFO] [stderr] 118 | | n.segment.matched(segment) [INFO] [stderr] 119 | | }) [INFO] [stderr] 120 | | .map(|n| n.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 115 | nodes [INFO] [stderr] 116 | .iter() [INFO] [stderr] 117 | .filter(|n| { [INFO] [stderr] 118 | n.segment.matched(segment) [INFO] [stderr] 119 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if nodes_matched.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes_matched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | if nodes_matched.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes_matched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/router.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | subscriber_coll.iter().map(|sub| sub.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `subscriber_coll.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/server.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new(address: &str) { [INFO] [stderr] 15 | | let mut core = Core::new().unwrap(); [INFO] [stderr] 16 | | let handle = core.handle(); [INFO] [stderr] 17 | | [INFO] [stderr] ... | [INFO] [stderr] 29 | | core.run(server).unwrap(); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / pub fn new() -> Router { [INFO] [stderr] 77 | | Router { [INFO] [stderr] 78 | | children: Arc::new(RwLock::new(vec![])), [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/router.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / nodes [INFO] [stderr] 116 | | .iter() [INFO] [stderr] 117 | | .filter(|n| { [INFO] [stderr] 118 | | n.segment.matched(segment) [INFO] [stderr] 119 | | }) [INFO] [stderr] 120 | | .map(|n| n.clone()) [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 115 | nodes [INFO] [stderr] 116 | .iter() [INFO] [stderr] 117 | .filter(|n| { [INFO] [stderr] 118 | n.segment.matched(segment) [INFO] [stderr] 119 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if nodes_matched.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes_matched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | if nodes_matched.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes_matched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/router.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | subscriber_coll.iter().map(|sub| sub.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `subscriber_coll.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/server.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new(address: &str) { [INFO] [stderr] 15 | | let mut core = Core::new().unwrap(); [INFO] [stderr] 16 | | let handle = core.handle(); [INFO] [stderr] 17 | | [INFO] [stderr] ... | [INFO] [stderr] 29 | | core.run(server).unwrap(); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.23s [INFO] running `"docker" "inspect" "f9f821b9f7fdbfaac47d3c074f20ccf9afd53d227316c4af5f5e91d7a95519fd"` [INFO] running `"docker" "rm" "-f" "f9f821b9f7fdbfaac47d3c074f20ccf9afd53d227316c4af5f5e91d7a95519fd"` [INFO] [stdout] f9f821b9f7fdbfaac47d3c074f20ccf9afd53d227316c4af5f5e91d7a95519fd