[INFO] updating cached repository yehnra/dnddice [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yehnra/dnddice [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yehnra/dnddice" "work/ex/clippy-test-run/sources/stable/gh/yehnra/dnddice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yehnra/dnddice'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yehnra/dnddice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yehnra/dnddice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yehnra/dnddice'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2185654f32b53a8e8057ab09215861f37c1388d9 [INFO] sha for GitHub repo yehnra/dnddice: 2185654f32b53a8e8057ab09215861f37c1388d9 [INFO] validating manifest of yehnra/dnddice on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yehnra/dnddice on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yehnra/dnddice [INFO] finished frobbing yehnra/dnddice [INFO] frobbed toml for yehnra/dnddice written to work/ex/clippy-test-run/sources/stable/gh/yehnra/dnddice/Cargo.toml [INFO] started frobbing yehnra/dnddice [INFO] finished frobbing yehnra/dnddice [INFO] frobbed toml for yehnra/dnddice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yehnra/dnddice/Cargo.toml [INFO] crate yehnra/dnddice has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yehnra/dnddice against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yehnra/dnddice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d04ed5ed332d6d34d4e1e8f72caf008480bf5a4e2a0ef5fd577c867c5ece659 [INFO] running `"docker" "start" "-a" "7d04ed5ed332d6d34d4e1e8f72caf008480bf5a4e2a0ef5fd577c867c5ece659"` [INFO] [stderr] Checking libc v0.2.19 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking dnddice v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | fn parse_args(args: &Vec) -> (Vec, bool, bool, bool) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 1..(args.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for in args.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | fn parse_args(args: &Vec) -> (Vec, bool, bool, bool) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `args`. [INFO] [stderr] --> src/main.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 1..(args.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for in args.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.09s [INFO] running `"docker" "inspect" "7d04ed5ed332d6d34d4e1e8f72caf008480bf5a4e2a0ef5fd577c867c5ece659"` [INFO] running `"docker" "rm" "-f" "7d04ed5ed332d6d34d4e1e8f72caf008480bf5a4e2a0ef5fd577c867c5ece659"` [INFO] [stdout] 7d04ed5ed332d6d34d4e1e8f72caf008480bf5a4e2a0ef5fd577c867c5ece659