[INFO] updating cached repository yavrib/piston-trials [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yavrib/piston-trials [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yavrib/piston-trials" "work/ex/clippy-test-run/sources/stable/gh/yavrib/piston-trials"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yavrib/piston-trials'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yavrib/piston-trials" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/piston-trials"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/piston-trials'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 147f9d4aee840dccc533283576b8c4323b639049 [INFO] sha for GitHub repo yavrib/piston-trials: 147f9d4aee840dccc533283576b8c4323b639049 [INFO] validating manifest of yavrib/piston-trials on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yavrib/piston-trials on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yavrib/piston-trials [INFO] finished frobbing yavrib/piston-trials [INFO] frobbed toml for yavrib/piston-trials written to work/ex/clippy-test-run/sources/stable/gh/yavrib/piston-trials/Cargo.toml [INFO] started frobbing yavrib/piston-trials [INFO] finished frobbing yavrib/piston-trials [INFO] frobbed toml for yavrib/piston-trials written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/piston-trials/Cargo.toml [INFO] crate yavrib/piston-trials has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yavrib/piston-trials against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yavrib/piston-trials:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a08ce82d08baf20d6e29095df8687041f6c1db8c74e626fc870abac4d23b248 [INFO] running `"docker" "start" "-a" "3a08ce82d08baf20d6e29095df8687041f6c1db8c74e626fc870abac4d23b248"` [INFO] [stderr] Compiling bitflags v1.0.4 [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Checking downcast-rs v1.0.3 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling khronos_api v2.2.0 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling cfg-if v0.1.5 [INFO] [stderr] Compiling nix v0.11.0 [INFO] [stderr] Compiling rayon v1.0.2 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling either v1.5.0 [INFO] [stderr] Checking piston-float v0.3.0 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking shader_version v0.3.0 [INFO] [stderr] Checking piston-texture v0.6.0 [INFO] [stderr] Checking interpolation v0.1.0 [INFO] [stderr] Checking read_color v1.0.0 [INFO] [stderr] Checking piston-shaders_graphics2d v0.3.1 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling log v0.4.5 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking inflate v0.4.3 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking stb_truetype v0.2.4 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking piston-viewport v0.3.0 [INFO] [stderr] Checking vecmath v0.3.1 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking lock_api v0.1.4 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking ordered-float v0.5.2 [INFO] [stderr] Compiling wayland-scanner v0.20.12 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling wayland-client v0.20.12 [INFO] [stderr] Compiling wayland-protocols v0.20.12 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling syn v0.15.8 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.81.0 [INFO] [stderr] Checking shapes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut distance_x = dest_x - x; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | let mut distance_y = dest_y - y; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | rectanglee.x = rectanglee.x + steps[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rectanglee.x += steps[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | rectanglee.y = rectanglee.y + steps[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rectanglee.y += steps[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | clicked = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | rectanglee.destination = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / text::Text::new_color([0.0, 0.0, 0.0, 1.0], 32).draw( [INFO] [stderr] 115 | | &message, [INFO] [stderr] 116 | | &mut glyphs, [INFO] [stderr] 117 | | &c.draw_state, [INFO] [stderr] 118 | | transform, g [INFO] [stderr] 119 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut distance_x = dest_x - x; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | let mut distance_y = dest_y - y; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | rectanglee.x = rectanglee.x + steps[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rectanglee.x += steps[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | rectanglee.y = rectanglee.y + steps[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rectanglee.y += steps[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | clicked = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | rectanglee.destination = cursor.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / text::Text::new_color([0.0, 0.0, 0.0, 1.0], 32).draw( [INFO] [stderr] 115 | | &message, [INFO] [stderr] 116 | | &mut glyphs, [INFO] [stderr] 117 | | &c.draw_state, [INFO] [stderr] 118 | | transform, g [INFO] [stderr] 119 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 17s [INFO] running `"docker" "inspect" "3a08ce82d08baf20d6e29095df8687041f6c1db8c74e626fc870abac4d23b248"` [INFO] running `"docker" "rm" "-f" "3a08ce82d08baf20d6e29095df8687041f6c1db8c74e626fc870abac4d23b248"` [INFO] [stdout] 3a08ce82d08baf20d6e29095df8687041f6c1db8c74e626fc870abac4d23b248