[INFO] updating cached repository yasuyuky/sectora [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yasuyuky/sectora [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yasuyuky/sectora" "work/ex/clippy-test-run/sources/stable/gh/yasuyuky/sectora"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yasuyuky/sectora'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yasuyuky/sectora" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yasuyuky/sectora"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yasuyuky/sectora'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8030f81b4bb15ed5514b71b8756900bb0e40b8fd [INFO] sha for GitHub repo yasuyuky/sectora: 8030f81b4bb15ed5514b71b8756900bb0e40b8fd [INFO] validating manifest of yasuyuky/sectora on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yasuyuky/sectora on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yasuyuky/sectora [INFO] finished frobbing yasuyuky/sectora [INFO] frobbed toml for yasuyuky/sectora written to work/ex/clippy-test-run/sources/stable/gh/yasuyuky/sectora/Cargo.toml [INFO] started frobbing yasuyuky/sectora [INFO] finished frobbing yasuyuky/sectora [INFO] frobbed toml for yasuyuky/sectora written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yasuyuky/sectora/Cargo.toml [INFO] crate yasuyuky/sectora has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yasuyuky/sectora against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yasuyuky/sectora:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 832a5a7f6d566cc036baadd854f9f6419bc7469d1c159e5862ee73fc5c1f6770 [INFO] running `"docker" "start" "-a" "832a5a7f6d566cc036baadd854f9f6419bc7469d1c159e5862ee73fc5c1f6770"` [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling openssl v0.10.15 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking string v0.1.2 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Compiling nix v0.12.0 [INFO] [stderr] Compiling sectora v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.1 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Compiling openssl-sys v0.9.39 [INFO] [stderr] Checking arrayvec v0.4.8 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand v0.6.1 [INFO] [stderr] Checking tokio-timer v0.2.8 [INFO] [stderr] Checking smallvec v0.6.7 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking http v0.1.14 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking hyper v0.12.18 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ghclient.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | std::fs::create_dir_all(path.parent().unwrap_or(std::path::Path::new("/")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::path::Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/statics.rs:9:67 [INFO] [stderr] | [INFO] [stderr] 9 | static ref CONF_PATH_STR: String = env::var("SECTORA_CONFIG").unwrap_or(String::from(DEFAULT_CONF_PATH_STR)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(DEFAULT_CONF_PATH_STR))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/structs.rs:172:60 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn get_group(&self) -> String { self.group.clone().unwrap_or(self.sector.name.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.sector.name.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ghclient.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | std::fs::create_dir_all(path.parent().unwrap_or(std::path::Path::new("/")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::path::Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/statics.rs:9:67 [INFO] [stderr] | [INFO] [stderr] 9 | static ref CONF_PATH_STR: String = env::var("SECTORA_CONFIG").unwrap_or(String::from(DEFAULT_CONF_PATH_STR)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(DEFAULT_CONF_PATH_STR))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: casting from `*mut i8` to a more-strictly-aligned pointer (`*mut *mut i8`) [INFO] [stderr] --> src/buffer.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | let mem = self.buf.offset(self.offset) as *mut *mut libc::c_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/cstructs.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / fn pack(&mut self, buf: &mut Buffer, name: &str, passwd: &str, uid: libc::uid_t, gid: libc::gid_t, gecos: &str, [INFO] [stderr] 21 | | dir: &str, shell: &str) [INFO] [stderr] 22 | | -> Result<(), Error> { [INFO] [stderr] 23 | | self.name = buf.write_string(name)?; [INFO] [stderr] ... | [INFO] [stderr] 30 | | Ok(()) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/cstructs.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / fn pack(&mut self, buf: &mut Buffer, namp: &str, pwdp: &str, lstchg: libc::c_long, min: libc::c_long, [INFO] [stderr] 67 | | max: libc::c_long, warn: libc::c_long, inact: libc::c_long, expire: libc::c_long, flag: libc::c_ulong) [INFO] [stderr] 68 | | -> Result<(), Error> { [INFO] [stderr] 69 | | self.namp = buf.write_string(namp)?; [INFO] [stderr] ... | [INFO] [stderr] 78 | | Ok(()) [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ghclient.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | std::fs::create_dir_all(path.parent().unwrap_or(std::path::Path::new("/")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::path::Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/structs.rs:172:60 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn get_group(&self) -> String { self.group.clone().unwrap_or(self.sector.name.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.sector.name.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/statics.rs:9:67 [INFO] [stderr] | [INFO] [stderr] 9 | static ref CONF_PATH_STR: String = env::var("SECTORA_CONFIG").unwrap_or(String::from(DEFAULT_CONF_PATH_STR)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(DEFAULT_CONF_PATH_STR))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: casting from `*mut i8` to a more-strictly-aligned pointer (`*mut *mut i8`) [INFO] [stderr] --> src/buffer.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | let mem = self.buf.offset(self.offset) as *mut *mut libc::c_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/cstructs.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / fn pack(&mut self, buf: &mut Buffer, name: &str, passwd: &str, uid: libc::uid_t, gid: libc::gid_t, gecos: &str, [INFO] [stderr] 21 | | dir: &str, shell: &str) [INFO] [stderr] 22 | | -> Result<(), Error> { [INFO] [stderr] 23 | | self.name = buf.write_string(name)?; [INFO] [stderr] ... | [INFO] [stderr] 30 | | Ok(()) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/cstructs.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / fn pack(&mut self, buf: &mut Buffer, namp: &str, pwdp: &str, lstchg: libc::c_long, min: libc::c_long, [INFO] [stderr] 67 | | max: libc::c_long, warn: libc::c_long, inact: libc::c_long, expire: libc::c_long, flag: libc::c_ulong) [INFO] [stderr] 68 | | -> Result<(), Error> { [INFO] [stderr] 69 | | self.namp = buf.write_string(namp)?; [INFO] [stderr] ... | [INFO] [stderr] 78 | | Ok(()) [INFO] [stderr] 79 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ghclient.rs:46:47 [INFO] [stderr] | [INFO] [stderr] 46 | std::fs::create_dir_all(path.parent().unwrap_or(std::path::Path::new("/")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::path::Path::new("/"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/statics.rs:9:67 [INFO] [stderr] | [INFO] [stderr] 9 | static ref CONF_PATH_STR: String = env::var("SECTORA_CONFIG").unwrap_or(String::from(DEFAULT_CONF_PATH_STR)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(DEFAULT_CONF_PATH_STR))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/structs.rs:172:60 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn get_group(&self) -> String { self.group.clone().unwrap_or(self.sector.name.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.sector.name.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/structs.rs:172:60 [INFO] [stderr] | [INFO] [stderr] 172 | pub fn get_group(&self) -> String { self.group.clone().unwrap_or(self.sector.name.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.sector.name.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sectora`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sectora`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "832a5a7f6d566cc036baadd854f9f6419bc7469d1c159e5862ee73fc5c1f6770"` [INFO] running `"docker" "rm" "-f" "832a5a7f6d566cc036baadd854f9f6419bc7469d1c159e5862ee73fc5c1f6770"` [INFO] [stdout] 832a5a7f6d566cc036baadd854f9f6419bc7469d1c159e5862ee73fc5c1f6770