[INFO] updating cached repository yarrow/setop [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yarrow/setop [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yarrow/setop" "work/ex/clippy-test-run/sources/stable/gh/yarrow/setop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yarrow/setop'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yarrow/setop" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yarrow/setop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yarrow/setop'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 970ab8f6880c0bcad3d888fecd35aa67a79216e7 [INFO] sha for GitHub repo yarrow/setop: 970ab8f6880c0bcad3d888fecd35aa67a79216e7 [INFO] validating manifest of yarrow/setop on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yarrow/setop on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yarrow/setop [INFO] finished frobbing yarrow/setop [INFO] frobbed toml for yarrow/setop written to work/ex/clippy-test-run/sources/stable/gh/yarrow/setop/Cargo.toml [INFO] started frobbing yarrow/setop [INFO] finished frobbing yarrow/setop [INFO] frobbed toml for yarrow/setop written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yarrow/setop/Cargo.toml [INFO] crate yarrow/setop has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yarrow/setop against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yarrow/setop:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 492807f1b63d3388dba6a3f2fd565b54a68d24ce51142b9ebb679beaf042e276 [INFO] running `"docker" "start" "-a" "492807f1b63d3388dba6a3f2fd565b54a68d24ce51142b9ebb679beaf042e276"` [INFO] [stderr] Compiling proc-macro2 v0.4.19 [INFO] [stderr] Compiling serde v1.0.79 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Checking same-file v1.0.3 [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking walkdir v2.2.5 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Checking tempfile v3.0.4 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Compiling syn v0.15.7 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking predicates v0.5.2 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking globwalk v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking setop v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking assert_fs v0.2.1 [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:13:44 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(feature = "cargo-clippy", deny(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:13:44 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(feature = "cargo-clippy", deny(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: you should put `io::stdout` between ticks in the documentation [INFO] [stderr] --> src/sio.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | /// Returns io::stdout, locked [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14| #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::doc_markdown)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/sio.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | ContentsIter { [INFO] [stderr] | ^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::use_self)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] Checking serde_json v1.0.31 [INFO] [stderr] Checking assert_cmd v0.10.1 [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:13:44 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(feature = "cargo-clippy", deny(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:13:44 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(feature = "cargo-clippy", deny(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: you should put `io::stdout` between ticks in the documentation [INFO] [stderr] --> src/sio.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | /// Returns io::stdout, locked [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14| #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::doc_markdown)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: item name starts with its containing module's name [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14| #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::stutter)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#stutter [INFO] [stderr] [INFO] [stderr] warning: unnecessary structure name repetition [INFO] [stderr] --> src/sio.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | ContentsIter { [INFO] [stderr] | ^^^^^^^^^^^^ help: use the applicable keyword: `Self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::use_self)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self [INFO] [stderr] [INFO] [stderr] warning: don't use glob imports for enum variants [INFO] [stderr] --> src/lib.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | use self::OpName::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::enum_glob_use)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use [INFO] [stderr] [INFO] [stderr] error: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:264:42 [INFO] [stderr] | [INFO] [stderr] 264 | fn calc(operation: OpName, operands: &Vec<&[u8]>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&[u8]]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:13:44 [INFO] [stderr] | [INFO] [stderr] 13 | #![cfg_attr(feature = "cargo-clippy", deny(clippy))] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[deny(clippy::ptr_arg)] implied by #[deny(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: it is more concise to loop over references to containers instead of using explicit iteration methods [INFO] [stderr] --> src/lib.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | for op in [Intersect, Union, Diff, Single, Multiple].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&[Intersect, Union, Diff, Single, Multiple]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | #![cfg_attr(feature = "cargo-clippy", warn(clippy_pedantic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::explicit_iter_loop)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `setop`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "492807f1b63d3388dba6a3f2fd565b54a68d24ce51142b9ebb679beaf042e276"` [INFO] running `"docker" "rm" "-f" "492807f1b63d3388dba6a3f2fd565b54a68d24ce51142b9ebb679beaf042e276"` [INFO] [stdout] 492807f1b63d3388dba6a3f2fd565b54a68d24ce51142b9ebb679beaf042e276