[INFO] updating cached repository yagince/slacky-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yagince/slacky-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yagince/slacky-rs" "work/ex/clippy-test-run/sources/stable/gh/yagince/slacky-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yagince/slacky-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yagince/slacky-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yagince/slacky-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yagince/slacky-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b380fbc58fbfefe3026f44739c77f6f7a0719263 [INFO] sha for GitHub repo yagince/slacky-rs: b380fbc58fbfefe3026f44739c77f6f7a0719263 [INFO] validating manifest of yagince/slacky-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yagince/slacky-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yagince/slacky-rs [INFO] finished frobbing yagince/slacky-rs [INFO] frobbed toml for yagince/slacky-rs written to work/ex/clippy-test-run/sources/stable/gh/yagince/slacky-rs/Cargo.toml [INFO] started frobbing yagince/slacky-rs [INFO] finished frobbing yagince/slacky-rs [INFO] frobbed toml for yagince/slacky-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yagince/slacky-rs/Cargo.toml [INFO] crate yagince/slacky-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yagince/slacky-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yagince/slacky-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19448ecfd9ae488ca1d1a0f88a457c97eea965df5a8e6c3a693f9e9f902531c9 [INFO] running `"docker" "start" "-a" "19448ecfd9ae488ca1d1a0f88a457c97eea965df5a8e6c3a693f9e9f902531c9"` [INFO] [stderr] Compiling cc v1.0.17 [INFO] [stderr] Compiling pkg-config v0.3.11 [INFO] [stderr] Compiling httparse v1.3.1 [INFO] [stderr] Compiling serde v1.0.68 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking hex v0.2.0 [INFO] [stderr] Checking log v0.4.2 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Checking base64 v0.9.2 [INFO] [stderr] Compiling proc-macro2 v0.4.6 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-timer v0.2.4 [INFO] [stderr] Checking bytes v0.4.8 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling openssl-sys v0.9.33 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking libflate v0.1.15 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.68 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking serde_json v1.0.22 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking slack-hook v0.6.0 [INFO] [stderr] Checking slacky v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | const PKG_VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | const PKG_NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const PKG_AUTHOR: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | let mut dest_dir = env::home_dir().unwrap_or_default(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | const PKG_VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | const PKG_NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const PKG_AUTHOR: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | let mut dest_dir = env::home_dir().unwrap_or_default(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(_) = matches.subcommand_matches("init") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 54 | | create_conf().expect("create conf"); [INFO] [stderr] 55 | | } else { [INFO] [stderr] 56 | | let mut conf = read_conf().expect("read conf"); [INFO] [stderr] ... | [INFO] [stderr] 73 | | slack::notify(&msg, ¬ify_config).expect("Slack Error"); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("init").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | matches.value_of("webhook-url").map(|url| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 60 | || conf.webhook_url = url.into(); [INFO] [stderr] 61 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(url) = matches.value_of("webhook-url") { conf.webhook_url = url.into(); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | matches.value_of("channel").map(|channel| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 63 | || conf.channel = Some(channel.into()); [INFO] [stderr] 64 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(channel) = matches.value_of("channel") { conf.channel = Some(channel.into()); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | matches.value_of("icon").map(|icon| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 66 | || conf.icon = Some(icon.into()); [INFO] [stderr] 67 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(icon) = matches.value_of("icon") { conf.icon = Some(icon.into()); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(_) = matches.subcommand_matches("init") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 54 | | create_conf().expect("create conf"); [INFO] [stderr] 55 | | } else { [INFO] [stderr] 56 | | let mut conf = read_conf().expect("read conf"); [INFO] [stderr] ... | [INFO] [stderr] 73 | | slack::notify(&msg, ¬ify_config).expect("Slack Error"); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("init").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | matches.value_of("webhook-url").map(|url| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 60 | || conf.webhook_url = url.into(); [INFO] [stderr] 61 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(url) = matches.value_of("webhook-url") { conf.webhook_url = url.into(); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | matches.value_of("channel").map(|channel| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 63 | || conf.channel = Some(channel.into()); [INFO] [stderr] 64 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(channel) = matches.value_of("channel") { conf.channel = Some(channel.into()); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | matches.value_of("icon").map(|icon| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 66 | || conf.icon = Some(icon.into()); [INFO] [stderr] 67 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(icon) = matches.value_of("icon") { conf.icon = Some(icon.into()); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `"docker" "inspect" "19448ecfd9ae488ca1d1a0f88a457c97eea965df5a8e6c3a693f9e9f902531c9"` [INFO] running `"docker" "rm" "-f" "19448ecfd9ae488ca1d1a0f88a457c97eea965df5a8e6c3a693f9e9f902531c9"` [INFO] [stdout] 19448ecfd9ae488ca1d1a0f88a457c97eea965df5a8e6c3a693f9e9f902531c9