[INFO] updating cached repository yaahallo/laundry-bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yaahallo/laundry-bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yaahallo/laundry-bot" "work/ex/clippy-test-run/sources/stable/gh/yaahallo/laundry-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yaahallo/laundry-bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yaahallo/laundry-bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yaahallo/laundry-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yaahallo/laundry-bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff7a441f51380ca0132c26ebbd7e6491604624b6 [INFO] sha for GitHub repo yaahallo/laundry-bot: ff7a441f51380ca0132c26ebbd7e6491604624b6 [INFO] validating manifest of yaahallo/laundry-bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yaahallo/laundry-bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yaahallo/laundry-bot [INFO] finished frobbing yaahallo/laundry-bot [INFO] frobbed toml for yaahallo/laundry-bot written to work/ex/clippy-test-run/sources/stable/gh/yaahallo/laundry-bot/Cargo.toml [INFO] started frobbing yaahallo/laundry-bot [INFO] finished frobbing yaahallo/laundry-bot [INFO] frobbed toml for yaahallo/laundry-bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yaahallo/laundry-bot/Cargo.toml [INFO] crate yaahallo/laundry-bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yaahallo/laundry-bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/yaahallo/laundry-bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e69ecb56f742ff124fb95a11bc1c8d41ecc19efeb43bd58e56e9e0c6fccd0502 [INFO] running `"docker" "start" "-a" "e69ecb56f742ff124fb95a11bc1c8d41ecc19efeb43bd58e56e9e0c6fccd0502"` [INFO] [stderr] Compiling cc v1.0.14 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking stable_deref_trait v1.0.0 [INFO] [stderr] Compiling nix v0.10.0 [INFO] [stderr] Checking smallvec v0.6.1 [INFO] [stderr] Checking sha1 v0.2.0 [INFO] [stderr] Checking bitflags v1.0.2 [INFO] [stderr] Checking kankyo v0.1.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking base64 v0.9.1 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking evzht9h3nznqzwl v0.0.3 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking sysfs_gpio v0.5.3 [INFO] [stderr] Checking serenity v0.5.3 [INFO] [stderr] Checking laundry-bot v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/laundry/mod.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | alerter: alerter, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `alerter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/laundry/mod.rs:43:19 [INFO] [stderr] | [INFO] [stderr] 43 | alerter: alerter, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `alerter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/discord.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return alerter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `alerter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/discord.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return Some(msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return Some(msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/discord.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return alerter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `alerter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/discord.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return Some(msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/laundry/alert/mod.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return Some(msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(msg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/laundry/alert/mod.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let msg = format!("Alright boss, looks like you unloaded the laundry, back to the wall, my \ [INFO] [stderr] | _______________^ [INFO] [stderr] 37 | | watch continues..."); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 36 | let msg = "Alright boss, looks like you unloaded the laundry, back to the wall, my \ [INFO] [stderr] 37 | watch continues...".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/laundry/alert/mod.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let msg = format!("Alright boss, looks like you unloaded the laundry, back to the wall, my \ [INFO] [stderr] | _______________^ [INFO] [stderr] 37 | | watch continues..."); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 36 | let msg = "Alright boss, looks like you unloaded the laundry, back to the wall, my \ [INFO] [stderr] 37 | watch continues...".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.34s [INFO] running `"docker" "inspect" "e69ecb56f742ff124fb95a11bc1c8d41ecc19efeb43bd58e56e9e0c6fccd0502"` [INFO] running `"docker" "rm" "-f" "e69ecb56f742ff124fb95a11bc1c8d41ecc19efeb43bd58e56e9e0c6fccd0502"` [INFO] [stdout] e69ecb56f742ff124fb95a11bc1c8d41ecc19efeb43bd58e56e9e0c6fccd0502