[INFO] updating cached repository y6nH/aoc2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/y6nH/aoc2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/y6nH/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/y6nH/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/y6nH/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/y6nH/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/y6nH/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/y6nH/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 96e2c5ff373ee18e86f3e3f2095103d978b16462
[INFO] sha for GitHub repo y6nH/aoc2018: 96e2c5ff373ee18e86f3e3f2095103d978b16462
[INFO] validating manifest of y6nH/aoc2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of y6nH/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing y6nH/aoc2018
[INFO] finished frobbing y6nH/aoc2018
[INFO] frobbed toml for y6nH/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/y6nH/aoc2018/Cargo.toml
[INFO] started frobbing y6nH/aoc2018
[INFO] finished frobbing y6nH/aoc2018
[INFO] frobbed toml for y6nH/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/y6nH/aoc2018/Cargo.toml
[INFO] crate y6nH/aoc2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting y6nH/aoc2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/y6nH/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fadaf0fda9cca732cf6e223df61cced2e252c6e0bdffa5cfd7e8a10093e08793
[INFO] running `"docker" "start" "-a" "fadaf0fda9cca732cf6e223df61cced2e252c6e0bdffa5cfd7e8a10093e08793"`
[INFO] [stderr]    Compiling libc v0.2.45
[INFO] [stderr]     Checking lazy_static v1.2.0
[INFO] [stderr]     Checking ucd-util v0.1.3
[INFO] [stderr]    Compiling regex v1.1.0
[INFO] [stderr]     Checking utf8-ranges v1.0.2
[INFO] [stderr]    Compiling memchr v2.1.2
[INFO] [stderr]     Checking thread_local v0.3.6
[INFO] [stderr]     Checking regex-syntax v0.6.4
[INFO] [stderr]     Checking time v0.1.41
[INFO] [stderr]     Checking chrono v0.4.6
[INFO] [stderr]     Checking aho-corasick v0.6.9
[INFO] [stderr]     Checking aoc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/day3.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let w: usize = c["w"].parse().expect("no w!");
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/day3.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let h: usize = c["h"].parse().expect("no h!");
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/day3.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |         let w: usize = c["w"].parse().expect("no w!");
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/day3.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let h: usize = c["h"].parse().expect("no h!");
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day2.rs:72:3
[INFO] [stderr]    |
[INFO] [stderr] 72 |   return diff == 1;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `diff == 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day3.rs:77:3
[INFO] [stderr]    |
[INFO] [stderr] 77 |   return uncontested;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `uncontested`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day5.rs:61:3
[INFO] [stderr]    |
[INFO] [stderr] 61 |   return result;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day6.rs:55:4
[INFO] [stderr]    |
[INFO] [stderr] 55 |    return coords;
[INFO] [stderr]    |    ^^^^^^^^^^^^^^ help: remove `return` as shown: `coords`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day6.rs:62:4
[INFO] [stderr]    |
[INFO] [stderr] 62 |    return 23;
[INFO] [stderr]    |    ^^^^^^^^^^ help: remove `return` as shown: `23`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |     Ok(_) => return s,
[INFO] [stderr]    |              ^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day2.rs:72:3
[INFO] [stderr]    |
[INFO] [stderr] 72 |   return diff == 1;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `diff == 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day3.rs:77:3
[INFO] [stderr]    |
[INFO] [stderr] 77 |   return uncontested;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `uncontested`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day5.rs:61:3
[INFO] [stderr]    |
[INFO] [stderr] 61 |   return result;
[INFO] [stderr]    |   ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day6.rs:55:4
[INFO] [stderr]    |
[INFO] [stderr] 55 |    return coords;
[INFO] [stderr]    |    ^^^^^^^^^^^^^^ help: remove `return` as shown: `coords`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/day6.rs:62:4
[INFO] [stderr]    |
[INFO] [stderr] 62 |    return 23;
[INFO] [stderr]    |    ^^^^^^^^^^ help: remove `return` as shown: `23`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |     Ok(_) => return s,
[INFO] [stderr]    |              ^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `coords`
[INFO] [stderr]   --> src/day6.rs:58:17
[INFO] [stderr]    |
[INFO] [stderr] 58 | fn find_closest(coords: &Vec<(usize, usize)>, target: &(usize, usize)) -> usize {
[INFO] [stderr]    |                 ^^^^^^ help: consider using `_coords` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `target`
[INFO] [stderr]   --> src/day6.rs:58:47
[INFO] [stderr]    |
[INFO] [stderr] 58 | fn find_closest(coords: &Vec<(usize, usize)>, target: &(usize, usize)) -> usize {
[INFO] [stderr]    |                                               ^^^^^^ help: consider using `_target` instead
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:29:7
[INFO] [stderr]    |
[INFO] [stderr] 29 |       twos = twos + 1;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^ help: replace it with: `twos += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:32:7
[INFO] [stderr]    |
[INFO] [stderr] 32 |       threes = threes + 1;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^ help: replace it with: `threes += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 |       diff = diff + 1;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^ help: replace it with: `diff += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/day3.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     match claim {
[INFO] [stderr] 23 | |       Some(c) => {
[INFO] [stderr] 24 | |         let id: String = c["id"].to_string();
[INFO] [stderr] 25 | |         let x: usize = c["x"].parse().expect("no x!");
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |       }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 |     if let Some(c) = claim {
[INFO] [stderr] 23 |   let id: String = c["id"].to_string();
[INFO] [stderr] 24 |   let x: usize = c["x"].parse().expect("no x!");
[INFO] [stderr] 25 |   let y: usize = c["y"].parse().expect("no y!");
[INFO] [stderr] 26 |   let w: usize = c["w"].parse().expect("no w!");
[INFO] [stderr] 27 |   let h: usize = c["h"].parse().expect("no h!");
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]   --> src/day3.rs:51:7
[INFO] [stderr]    |
[INFO] [stderr] 51 |       &overlapping_claims.insert(cc.clone());
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overlapping_claims.insert(cc.clone());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:60:6
[INFO] [stderr]    |
[INFO] [stderr] 60 |   x: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:61:6
[INFO] [stderr]    |
[INFO] [stderr] 61 |   y: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:62:6
[INFO] [stderr]    |
[INFO] [stderr] 62 |   w: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:63:6
[INFO] [stderr]    |
[INFO] [stderr] 63 |   h: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/day4.rs:74:45
[INFO] [stderr]    |
[INFO] [stderr] 74 |     for event in timeline.iter().filter(|a| &a.1 == &id) {
[INFO] [stderr]    |                                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 74 |     for event in timeline.iter().filter(|a| a.1 == id) {
[INFO] [stderr]    |                                             ^^^    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day5.rs:37:26
[INFO] [stderr]    |
[INFO] [stderr] 37 | fn collapse_bytes(bytes: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `grid`
[INFO] [stderr]   --> src/day6.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |    for x in bounds.0..=bounds.2 {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 33 |    for (x, <item>) in grid.iter_mut().enumerate().take(bounds.2 + 1).skip(bounds.0) {
[INFO] [stderr]    |        ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 | fn find_closest(coords: &Vec<(usize, usize)>, target: &(usize, usize)) -> usize {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `coords`
[INFO] [stderr]   --> src/day6.rs:58:17
[INFO] [stderr]    |
[INFO] [stderr] 58 | fn find_closest(coords: &Vec<(usize, usize)>, target: &(usize, usize)) -> usize {
[INFO] [stderr]    |                 ^^^^^^ help: consider using `_coords` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `target`
[INFO] [stderr]   --> src/day6.rs:58:47
[INFO] [stderr]    |
[INFO] [stderr] 58 | fn find_closest(coords: &Vec<(usize, usize)>, target: &(usize, usize)) -> usize {
[INFO] [stderr]    |                                               ^^^^^^ help: consider using `_target` instead
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:29:7
[INFO] [stderr]    |
[INFO] [stderr] 29 |       twos = twos + 1;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^ help: replace it with: `twos += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:32:7
[INFO] [stderr]    |
[INFO] [stderr] 32 |       threes = threes + 1;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^ help: replace it with: `threes += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/day2.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 |       diff = diff + 1;
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^ help: replace it with: `diff += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/day3.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     match claim {
[INFO] [stderr] 23 | |       Some(c) => {
[INFO] [stderr] 24 | |         let id: String = c["id"].to_string();
[INFO] [stderr] 25 | |         let x: usize = c["x"].parse().expect("no x!");
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |       }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 |     if let Some(c) = claim {
[INFO] [stderr] 23 |   let id: String = c["id"].to_string();
[INFO] [stderr] 24 |   let x: usize = c["x"].parse().expect("no x!");
[INFO] [stderr] 25 |   let y: usize = c["y"].parse().expect("no y!");
[INFO] [stderr] 26 |   let w: usize = c["w"].parse().expect("no w!");
[INFO] [stderr] 27 |   let h: usize = c["h"].parse().expect("no h!");
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]   --> src/day3.rs:51:7
[INFO] [stderr]    |
[INFO] [stderr] 51 |       &overlapping_claims.insert(cc.clone());
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `overlapping_claims.insert(cc.clone());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:60:6
[INFO] [stderr]    |
[INFO] [stderr] 60 |   x: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:61:6
[INFO] [stderr]    |
[INFO] [stderr] 61 |   y: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:62:6
[INFO] [stderr]    |
[INFO] [stderr] 62 |   w: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day3.rs:63:6
[INFO] [stderr]    |
[INFO] [stderr] 63 |   h: &usize,
[INFO] [stderr]    |      ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/day4.rs:74:45
[INFO] [stderr]    |
[INFO] [stderr] 74 |     for event in timeline.iter().filter(|a| &a.1 == &id) {
[INFO] [stderr]    |                                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 74 |     for event in timeline.iter().filter(|a| a.1 == id) {
[INFO] [stderr]    |                                             ^^^    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day5.rs:37:26
[INFO] [stderr]    |
[INFO] [stderr] 37 | fn collapse_bytes(bytes: &Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `grid`
[INFO] [stderr]   --> src/day6.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |    for x in bounds.0..=bounds.2 {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 33 |    for (x, <item>) in grid.iter_mut().enumerate().take(bounds.2 + 1).skip(bounds.0) {
[INFO] [stderr]    |        ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 | fn find_closest(coords: &Vec<(usize, usize)>, target: &(usize, usize)) -> usize {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.80s
[INFO] running `"docker" "inspect" "fadaf0fda9cca732cf6e223df61cced2e252c6e0bdffa5cfd7e8a10093e08793"`
[INFO] running `"docker" "rm" "-f" "fadaf0fda9cca732cf6e223df61cced2e252c6e0bdffa5cfd7e8a10093e08793"`
[INFO] [stdout] fadaf0fda9cca732cf6e223df61cced2e252c6e0bdffa5cfd7e8a10093e08793