[INFO] updating cached repository xxzozaxx/pwr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xxzozaxx/pwr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xxzozaxx/pwr" "work/ex/clippy-test-run/sources/stable/gh/xxzozaxx/pwr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xxzozaxx/pwr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xxzozaxx/pwr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xxzozaxx/pwr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xxzozaxx/pwr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 795f682d9ace3f97eee586a99e25f567dc17c362 [INFO] sha for GitHub repo xxzozaxx/pwr: 795f682d9ace3f97eee586a99e25f567dc17c362 [INFO] validating manifest of xxzozaxx/pwr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xxzozaxx/pwr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xxzozaxx/pwr [INFO] finished frobbing xxzozaxx/pwr [INFO] frobbed toml for xxzozaxx/pwr written to work/ex/clippy-test-run/sources/stable/gh/xxzozaxx/pwr/Cargo.toml [INFO] started frobbing xxzozaxx/pwr [INFO] finished frobbing xxzozaxx/pwr [INFO] frobbed toml for xxzozaxx/pwr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xxzozaxx/pwr/Cargo.toml [INFO] crate xxzozaxx/pwr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xxzozaxx/pwr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xxzozaxx/pwr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c3e6c32f977198b0ee655bfa75ee3a8e73da7c4f20510619648dc2cfa9b183e [INFO] running `"docker" "start" "-a" "3c3e6c32f977198b0ee655bfa75ee3a8e73da7c4f20510619648dc2cfa9b183e"` [INFO] [stderr] Compiling cc v1.0.23 [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Compiling regex v1.0.4 [INFO] [stderr] Checking openssl-probe v0.1.2 [INFO] [stderr] Checking utf8-ranges v1.0.1 [INFO] [stderr] Checking try_opt v0.1.1 [INFO] [stderr] Checking tico v1.0.0 [INFO] [stderr] Checking memchr v2.0.2 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Compiling libz-sys v1.0.20 [INFO] [stderr] Compiling cmake v0.1.33 [INFO] [stderr] Compiling curl-sys v0.4.8 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling libssh2-sys v0.2.10 [INFO] [stderr] Compiling libgit2-sys v0.7.7 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking pwr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Some(ANSIStrings(&out).to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ANSIStrings(&out).to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | return Some((s_ahead, s_behind)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((s_ahead, s_behind))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return (untracked, staged, changed) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(untracked, staged, changed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | let dir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Some(ANSIStrings(&out).to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ANSIStrings(&out).to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | return Some((s_ahead, s_behind)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((s_ahead, s_behind))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | return (untracked, staged, changed) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(untracked, staged, changed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | stat.unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | let dir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | stat.unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 45s [INFO] running `"docker" "inspect" "3c3e6c32f977198b0ee655bfa75ee3a8e73da7c4f20510619648dc2cfa9b183e"` [INFO] running `"docker" "rm" "-f" "3c3e6c32f977198b0ee655bfa75ee3a8e73da7c4f20510619648dc2cfa9b183e"` [INFO] [stdout] 3c3e6c32f977198b0ee655bfa75ee3a8e73da7c4f20510619648dc2cfa9b183e