[INFO] updating cached repository xurtis/imgdiff
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/xurtis/imgdiff
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/xurtis/imgdiff" "work/ex/clippy-test-run/sources/stable/gh/xurtis/imgdiff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xurtis/imgdiff'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/xurtis/imgdiff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xurtis/imgdiff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xurtis/imgdiff'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5c46a9f29ec7f58db66d2a301831bc589a4a6484
[INFO] sha for GitHub repo xurtis/imgdiff: 5c46a9f29ec7f58db66d2a301831bc589a4a6484
[INFO] validating manifest of xurtis/imgdiff on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xurtis/imgdiff on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xurtis/imgdiff
[INFO] finished frobbing xurtis/imgdiff
[INFO] frobbed toml for xurtis/imgdiff written to work/ex/clippy-test-run/sources/stable/gh/xurtis/imgdiff/Cargo.toml
[INFO] started frobbing xurtis/imgdiff
[INFO] finished frobbing xurtis/imgdiff
[INFO] frobbed toml for xurtis/imgdiff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xurtis/imgdiff/Cargo.toml
[INFO] crate xurtis/imgdiff has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xurtis/imgdiff against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xurtis/imgdiff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 51b8cd76aee810e77a73b0864fc9d1b31bab9d905fba5d4127a34bc5446058fd
[INFO] running `"docker" "start" "-a" "51b8cd76aee810e77a73b0864fc9d1b31bab9d905fba5d4127a34bc5446058fd"`
[INFO] [stderr]    Compiling rayon-core v1.3.0
[INFO] [stderr]     Checking either v1.4.0
[INFO] [stderr]     Checking scopeguard v0.3.3
[INFO] [stderr]     Checking num-traits v0.1.42
[INFO] [stderr]     Checking scoped_threadpool v0.1.8
[INFO] [stderr]     Checking rand v0.3.20
[INFO] [stderr]     Checking num_cpus v1.8.0
[INFO] [stderr]     Checking deflate v0.7.17
[INFO] [stderr]     Checking inflate v0.3.3
[INFO] [stderr]     Checking coco v0.1.1
[INFO] [stderr]     Checking num-integer v0.1.35
[INFO] [stderr]     Checking enum_primitive v0.1.1
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking rayon v0.9.0
[INFO] [stderr]     Checking num-iter v0.1.34
[INFO] [stderr]     Checking num-rational v0.1.40
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking imgdiff v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 |     return root;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `root`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 |     return root;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `root`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn pixel_diff(left: &Rgb<u8>, right: &Rgb<u8>) -> u32 {
[INFO] [stderr]    |                     ^^^^^^^^ help: consider passing by value instead: `Rgb<u8>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:38
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn pixel_diff(left: &Rgb<u8>, right: &Rgb<u8>) -> u32 {
[INFO] [stderr]    |                                      ^^^^^^^^ help: consider passing by value instead: `Rgb<u8>`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:16
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let red = (left.data[0] as i32 - right.data[0] as i32 ).abs();
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(left.data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:38
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let red = (left.data[0] as i32 - right.data[0] as i32 ).abs();
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(right.data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let green = (left.data[1] as i32 - right.data[1] as i32 ).abs();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(left.data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:49:40
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let green = (left.data[1] as i32 - right.data[1] as i32 ).abs();
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(right.data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:50:17
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let blue = (left.data[2] as i32 - right.data[2] as i32 ).abs();
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(left.data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:50:39
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let blue = (left.data[2] as i32 - right.data[2] as i32 ).abs();
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(right.data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn pixel_diff(left: &Rgb<u8>, right: &Rgb<u8>) -> u32 {
[INFO] [stderr]    |                     ^^^^^^^^ help: consider passing by value instead: `Rgb<u8>`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:38
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn pixel_diff(left: &Rgb<u8>, right: &Rgb<u8>) -> u32 {
[INFO] [stderr]    |                                      ^^^^^^^^ help: consider passing by value instead: `Rgb<u8>`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:16
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let red = (left.data[0] as i32 - right.data[0] as i32 ).abs();
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(left.data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:38
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let red = (left.data[0] as i32 - right.data[0] as i32 ).abs();
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(right.data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let green = (left.data[1] as i32 - right.data[1] as i32 ).abs();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(left.data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:49:40
[INFO] [stderr]    |
[INFO] [stderr] 49 |     let green = (left.data[1] as i32 - right.data[1] as i32 ).abs();
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(right.data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:50:17
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let blue = (left.data[2] as i32 - right.data[2] as i32 ).abs();
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(left.data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:50:39
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let blue = (left.data[2] as i32 - right.data[2] as i32 ).abs();
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(right.data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 21.18s
[INFO] running `"docker" "inspect" "51b8cd76aee810e77a73b0864fc9d1b31bab9d905fba5d4127a34bc5446058fd"`
[INFO] running `"docker" "rm" "-f" "51b8cd76aee810e77a73b0864fc9d1b31bab9d905fba5d4127a34bc5446058fd"`
[INFO] [stdout] 51b8cd76aee810e77a73b0864fc9d1b31bab9d905fba5d4127a34bc5446058fd