[INFO] updating cached repository xosmig/rustping
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/xosmig/rustping
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/xosmig/rustping" "work/ex/clippy-test-run/sources/stable/gh/xosmig/rustping"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xosmig/rustping'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/xosmig/rustping" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xosmig/rustping"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xosmig/rustping'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fb908ab95b177a3fe304107acc1507d5e03473fa
[INFO] sha for GitHub repo xosmig/rustping: fb908ab95b177a3fe304107acc1507d5e03473fa
[INFO] validating manifest of xosmig/rustping on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xosmig/rustping on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xosmig/rustping
[INFO] finished frobbing xosmig/rustping
[INFO] frobbed toml for xosmig/rustping written to work/ex/clippy-test-run/sources/stable/gh/xosmig/rustping/Cargo.toml
[INFO] started frobbing xosmig/rustping
[INFO] finished frobbing xosmig/rustping
[INFO] frobbed toml for xosmig/rustping written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xosmig/rustping/Cargo.toml
[INFO] crate xosmig/rustping has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xosmig/rustping against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xosmig/rustping:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c82649a9ff2e35573631900f5a28d3a8732450e34a59b7022fe70f509d22f57c
[INFO] running `"docker" "start" "-a" "c82649a9ff2e35573631900f5a28d3a8732450e34a59b7022fe70f509d22f57c"`
[INFO] [stderr]    Compiling num-integer v0.1.38
[INFO] [stderr]     Checking atty v0.2.10
[INFO] [stderr]     Checking textwrap v0.9.0
[INFO] [stderr]     Checking num-complex v0.1.43
[INFO] [stderr]    Compiling num-traits v0.1.43
[INFO] [stderr]    Compiling enum-primitive-derive v0.1.2
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking num-bigint v0.1.44
[INFO] [stderr]     Checking num-iter v0.1.37
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking rustping v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sys_return.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return sys_return_same(res).map(|x| NumCast::from(x).unwrap())
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sys_return_same(res).map(|x| NumCast::from(x).unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/sys_return.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     return sys_return_same(res).map(|x| NumCast::from(x).unwrap())
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sys_return_same(res).map(|x| NumCast::from(x).unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/icmp.rs:55:19
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let res = (a as u32) + (b as u32);
[INFO] [stderr]    |                   ^^^^^^^^^^ help: try: `u32::from(a)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/icmp.rs:55:32
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let res = (a as u32) + (b as u32);
[INFO] [stderr]    |                                ^^^^^^^^^^ help: try: `u32::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/icmp.rs:69:24
[INFO] [stderr]    |
[INFO] [stderr] 69 |         res = sum(res, data[data.len() - 1] as u16);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[data.len() - 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/num_serialize.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     (be[0] as u16) + ((be[1] as u16) << 8)
[INFO] [stderr]   |     ^^^^^^^^^^^^^^ help: try: `u16::from(be[0])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/num_serialize.rs:5:23
[INFO] [stderr]   |
[INFO] [stderr] 5 |     (be[0] as u16) + ((be[1] as u16) << 8)
[INFO] [stderr]   |                       ^^^^^^^^^^^^^^ help: try: `u16::from(be[1])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/ping.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 let rtt_millis = rtt.as_secs() * 1000 + (rtt.subsec_nanos() / 1_000_000) as u64;
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rtt.subsec_nanos() / 1_000_000)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation
[INFO] [stderr]   --> src/ping.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 let rtt_millis = rtt.as_secs() * 1000 + (rtt.subsec_nanos() / 1_000_000) as u64;
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rtt.subsec_millis()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::duration_subsec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/icmp.rs:55:19
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let res = (a as u32) + (b as u32);
[INFO] [stderr]    |                   ^^^^^^^^^^ help: try: `u32::from(a)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/icmp.rs:55:32
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let res = (a as u32) + (b as u32);
[INFO] [stderr]    |                                ^^^^^^^^^^ help: try: `u32::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/icmp.rs:69:24
[INFO] [stderr]    |
[INFO] [stderr] 69 |         res = sum(res, data[data.len() - 1] as u16);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[data.len() - 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/num_serialize.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     (be[0] as u16) + ((be[1] as u16) << 8)
[INFO] [stderr]   |     ^^^^^^^^^^^^^^ help: try: `u16::from(be[0])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/num_serialize.rs:5:23
[INFO] [stderr]   |
[INFO] [stderr] 5 |     (be[0] as u16) + ((be[1] as u16) << 8)
[INFO] [stderr]   |                       ^^^^^^^^^^^^^^ help: try: `u16::from(be[1])`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/ping.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 let rtt_millis = rtt.as_secs() * 1000 + (rtt.subsec_nanos() / 1_000_000) as u64;
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rtt.subsec_nanos() / 1_000_000)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation
[INFO] [stderr]   --> src/ping.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 let rtt_millis = rtt.as_secs() * 1000 + (rtt.subsec_nanos() / 1_000_000) as u64;
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rtt.subsec_millis()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::duration_subsec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.83s
[INFO] running `"docker" "inspect" "c82649a9ff2e35573631900f5a28d3a8732450e34a59b7022fe70f509d22f57c"`
[INFO] running `"docker" "rm" "-f" "c82649a9ff2e35573631900f5a28d3a8732450e34a59b7022fe70f509d22f57c"`
[INFO] [stdout] c82649a9ff2e35573631900f5a28d3a8732450e34a59b7022fe70f509d22f57c