[INFO] updating cached repository xobs/jig-20-interface-http
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/xobs/jig-20-interface-http
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/xobs/jig-20-interface-http" "work/ex/clippy-test-run/sources/stable/gh/xobs/jig-20-interface-http"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xobs/jig-20-interface-http'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/xobs/jig-20-interface-http" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xobs/jig-20-interface-http"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xobs/jig-20-interface-http'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c536e67c31cd7f120dd077712be150a891847424
[INFO] sha for GitHub repo xobs/jig-20-interface-http: c536e67c31cd7f120dd077712be150a891847424
[INFO] validating manifest of xobs/jig-20-interface-http on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xobs/jig-20-interface-http on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xobs/jig-20-interface-http
[INFO] finished frobbing xobs/jig-20-interface-http
[INFO] frobbed toml for xobs/jig-20-interface-http written to work/ex/clippy-test-run/sources/stable/gh/xobs/jig-20-interface-http/Cargo.toml
[INFO] started frobbing xobs/jig-20-interface-http
[INFO] finished frobbing xobs/jig-20-interface-http
[INFO] frobbed toml for xobs/jig-20-interface-http written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xobs/jig-20-interface-http/Cargo.toml
[INFO] crate xobs/jig-20-interface-http has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xobs/jig-20-interface-http against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xobs/jig-20-interface-http:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 573d8b7fd6337f4fc224d7c7a53a28ce130ec3ddc01eb5896484c11a368a281c
[INFO] running `"docker" "start" "-a" "573d8b7fd6337f4fc224d7c7a53a28ce130ec3ddc01eb5896484c11a368a281c"`
[INFO] [stderr]     Checking unicode-normalization v0.1.3
[INFO] [stderr]     Checking rustc-serialize v0.3.22
[INFO] [stderr]     Checking httparse v1.2.1
[INFO] [stderr]     Checking itoa v0.1.1
[INFO] [stderr]     Checking serde v0.8.23
[INFO] [stderr]    Compiling quote v0.3.12
[INFO] [stderr]     Checking dtoa v0.2.2
[INFO] [stderr]     Checking sequence_trie v0.2.1
[INFO] [stderr]     Checking dtoa v0.4.0
[INFO] [stderr]     Checking serde v0.9.5
[INFO] [stderr]     Checking itoa v0.3.0
[INFO] [stderr]     Checking unicode-bidi v0.2.4
[INFO] [stderr]     Checking unsafe-any v0.4.1
[INFO] [stderr]     Checking time v0.1.36
[INFO] [stderr]     Checking num_cpus v1.2.1
[INFO] [stderr]     Checking term_size v0.2.3
[INFO] [stderr]     Checking error v0.1.9
[INFO] [stderr]    Compiling hyper v0.10.4
[INFO] [stderr]    Compiling syn v0.11.4
[INFO] [stderr]     Checking typemap v0.3.3
[INFO] [stderr]     Checking clap v2.20.5
[INFO] [stderr]     Checking idna v0.1.0
[INFO] [stderr]     Checking plugin v0.2.6
[INFO] [stderr]     Checking url v1.4.0
[INFO] [stderr]     Checking conduit-mime-types v0.7.3
[INFO] [stderr]    Compiling serde_codegen_internals v0.12.1
[INFO] [stderr]     Checking serde_json v0.8.6
[INFO] [stderr]    Compiling serde_derive v0.9.5
[INFO] [stderr]     Checking serde_json v0.9.4
[INFO] [stderr]     Checking iron v0.5.1
[INFO] [stderr]     Checking persistent v0.3.0
[INFO] [stderr]     Checking mount v0.3.0
[INFO] [stderr]     Checking staticfile v0.4.0
[INFO] [stderr]     Checking bodyparser v0.5.0
[INFO] [stderr]     Checking urlencoded v0.5.0
[INFO] [stderr]     Checking jig-20-interface-http v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:390:21
[INFO] [stderr]     |
[INFO] [stderr] 390 |                     message_class: message_class,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_class`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:391:21
[INFO] [stderr]     |
[INFO] [stderr] 391 |                     unit_id: unit_id,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `unit_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:392:21
[INFO] [stderr]     |
[INFO] [stderr] 392 |                     unit_type: unit_type,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:393:21
[INFO] [stderr]     |
[INFO] [stderr] 393 |                     timestamp: timestamp,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:394:21
[INFO] [stderr]     |
[INFO] [stderr] 394 |                     message: message,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `message`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:390:21
[INFO] [stderr]     |
[INFO] [stderr] 390 |                     message_class: message_class,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_class`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:391:21
[INFO] [stderr]     |
[INFO] [stderr] 391 |                     unit_id: unit_id,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `unit_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:392:21
[INFO] [stderr]     |
[INFO] [stderr] 392 |                     unit_type: unit_type,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unit_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:393:21
[INFO] [stderr]     |
[INFO] [stderr] 393 |                     timestamp: timestamp,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:394:21
[INFO] [stderr]     |
[INFO] [stderr] 394 |                     message: message,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `message`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 | const SERVER_SIGNATURE: &'static str = "CFTI HTTP 1.0";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 | const SERVER_SIGNATURE: &'static str = "CFTI HTTP 1.0";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let ref state = *state.lock().unwrap();
[INFO] [stderr]     |     ----^^^^^^^^^-------------------------- help: try: `let state = &(*state.lock().unwrap());`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 |     let ref logs = *logs.lock().unwrap();
[INFO] [stderr]     |     ----^^^^^^^^------------------------- help: try: `let logs = &(*logs.lock().unwrap());`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:278:19
[INFO] [stderr]     |
[INFO] [stderr] 278 |     let name = if rest.len() > 0 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/main.rs:310:9
[INFO] [stderr]     |
[INFO] [stderr] 310 |         rx.read_line(&mut line).ok().expect("Unable to read line");
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 |     let ref state = *state.lock().unwrap();
[INFO] [stderr]     |     ----^^^^^^^^^-------------------------- help: try: `let state = &(*state.lock().unwrap());`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 |     let ref logs = *logs.lock().unwrap();
[INFO] [stderr]     |     ----^^^^^^^^------------------------- help: try: `let logs = &(*logs.lock().unwrap());`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:278:19
[INFO] [stderr]     |
[INFO] [stderr] 278 |     let name = if rest.len() > 0 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/main.rs:310:9
[INFO] [stderr]     |
[INFO] [stderr] 310 |         rx.read_line(&mut line).ok().expect("Unable to read line");
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 43.66s
[INFO] running `"docker" "inspect" "573d8b7fd6337f4fc224d7c7a53a28ce130ec3ddc01eb5896484c11a368a281c"`
[INFO] running `"docker" "rm" "-f" "573d8b7fd6337f4fc224d7c7a53a28ce130ec3ddc01eb5896484c11a368a281c"`
[INFO] [stdout] 573d8b7fd6337f4fc224d7c7a53a28ce130ec3ddc01eb5896484c11a368a281c