[INFO] updating cached repository xoac/u8-selector [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xoac/u8-selector [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xoac/u8-selector" "work/ex/clippy-test-run/sources/stable/gh/xoac/u8-selector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xoac/u8-selector'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xoac/u8-selector" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xoac/u8-selector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xoac/u8-selector'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 75b9870d863afe15d3cd7f39105884323b2c15f3 [INFO] sha for GitHub repo xoac/u8-selector: 75b9870d863afe15d3cd7f39105884323b2c15f3 [INFO] validating manifest of xoac/u8-selector on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xoac/u8-selector on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xoac/u8-selector [INFO] finished frobbing xoac/u8-selector [INFO] frobbed toml for xoac/u8-selector written to work/ex/clippy-test-run/sources/stable/gh/xoac/u8-selector/Cargo.toml [INFO] started frobbing xoac/u8-selector [INFO] finished frobbing xoac/u8-selector [INFO] frobbed toml for xoac/u8-selector written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xoac/u8-selector/Cargo.toml [INFO] crate xoac/u8-selector has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xoac/u8-selector against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xoac/u8-selector:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31c59d72357fc71b59759544e9c297c0d8e763a32cf3253a650701aa80378449 [INFO] running `"docker" "start" "-a" "31c59d72357fc71b59759544e9c297c0d8e763a32cf3253a650701aa80378449"` [INFO] [stderr] Compiling nix v0.10.0 [INFO] [stderr] Checking termcolor v0.3.6 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking log v0.4.2 [INFO] [stderr] Checking regex-syntax v0.6.1 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking tokio-timer v0.2.4 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking pretty_env_logger v0.2.3 [INFO] [stderr] Checking serialport v2.3.0 [INFO] [stderr] Checking mio-serial v0.8.0 [INFO] [stderr] Checking tokio-serial v0.8.0 [INFO] [stderr] Checking u8-selector v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | if self.rd.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.rd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / loop { [INFO] [stderr] 149 | | match self.rx.poll().unwrap() { [INFO] [stderr] 150 | | Async::Ready(Some(v)) => { [INFO] [stderr] 151 | | // Buffer the line. Once all lines are buffered, they will [INFO] [stderr] ... | [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: try: `while let Async::Ready(Some(v)) = self.rx.poll().unwrap() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / while let Ok(Async::Ready(v)) = self.rx.poll() { [INFO] [stderr] 190 | | if let Some(v) = v { [INFO] [stderr] 191 | | return Ok(Async::Ready(Some((v, self.tx.clone())))); [INFO] [stderr] 192 | | } else { [INFO] [stderr] 193 | | return Ok(Async::Ready(None)); [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `u8-selector`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | if self.rd.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.rd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / loop { [INFO] [stderr] 149 | | match self.rx.poll().unwrap() { [INFO] [stderr] 150 | | Async::Ready(Some(v)) => { [INFO] [stderr] 151 | | // Buffer the line. Once all lines are buffered, they will [INFO] [stderr] ... | [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ help: try: `while let Async::Ready(Some(v)) = self.rx.poll().unwrap() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / while let Ok(Async::Ready(v)) = self.rx.poll() { [INFO] [stderr] 190 | | if let Some(v) = v { [INFO] [stderr] 191 | | return Ok(Async::Ready(Some((v, self.tx.clone())))); [INFO] [stderr] 192 | | } else { [INFO] [stderr] 193 | | return Ok(Async::Ready(None)); [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `u8-selector`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "31c59d72357fc71b59759544e9c297c0d8e763a32cf3253a650701aa80378449"` [INFO] running `"docker" "rm" "-f" "31c59d72357fc71b59759544e9c297c0d8e763a32cf3253a650701aa80378449"` [INFO] [stdout] 31c59d72357fc71b59759544e9c297c0d8e763a32cf3253a650701aa80378449