[INFO] updating cached repository xdk78/ros
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/xdk78/ros
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/xdk78/ros" "work/ex/clippy-test-run/sources/stable/gh/xdk78/ros"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xdk78/ros'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/xdk78/ros" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xdk78/ros"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xdk78/ros'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] acfc987fd7627f3924522864c3f50ef8256bae86
[INFO] sha for GitHub repo xdk78/ros: acfc987fd7627f3924522864c3f50ef8256bae86
[INFO] validating manifest of xdk78/ros on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of xdk78/ros on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing xdk78/ros
[INFO] finished frobbing xdk78/ros
[INFO] frobbed toml for xdk78/ros written to work/ex/clippy-test-run/sources/stable/gh/xdk78/ros/Cargo.toml
[INFO] started frobbing xdk78/ros
[INFO] finished frobbing xdk78/ros
[INFO] frobbed toml for xdk78/ros written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xdk78/ros/Cargo.toml
[INFO] crate xdk78/ros has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting xdk78/ros against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xdk78/ros:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2a4c289a70a89e081823d5ce7e7cc5fb8a9d1ea61d10de2662f641c8d822cc23
[INFO] running `"docker" "start" "-a" "2a4c289a70a89e081823d5ce7e7cc5fb8a9d1ea61d10de2662f641c8d822cc23"`
[INFO] [stderr]     Checking rose v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             token_type: token_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:107:13
[INFO] [stderr]     |
[INFO] [stderr] 107 |             literal: literal,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `literal`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             token_type: token_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/scanner.rs:107:13
[INFO] [stderr]     |
[INFO] [stderr] 107 |             literal: literal,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `literal`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scanner.rs:253:5
[INFO] [stderr]     |
[INFO] [stderr] 253 |     return c.is_digit(36) || c == '_';
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `c.is_digit(36) || c == '_'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/scanner.rs:253:5
[INFO] [stderr]     |
[INFO] [stderr] 253 |     return c.is_digit(36) || c == '_';
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `c.is_digit(36) || c == '_'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/scanner.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 | /             self.src
[INFO] [stderr] 57 | |                 .next()
[INFO] [stderr] 58 | |                 .or(Some('\0'))
[INFO] [stderr] 59 | |                 .map(|c| self.peeks.push_back(c));
[INFO] [stderr]    | |_________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 56 |             if let Some(c) = self.src
[INFO] [stderr] 57 |                 .next()
[INFO] [stderr] 58 |                 .or(Some('\0')) { self.peeks.push_back(c) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/scanner.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 | /         match self.match_advance(c) {
[INFO] [stderr] 95 | |             true => self.static_token(m),
[INFO] [stderr] 96 | |             false => self.static_token(u),
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.match_advance(c) { self.static_token(m) } else { self.static_token(u) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:49:27
[INFO] [stderr]    |
[INFO] [stderr] 49 |     while let Some(res) = tokens.next() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `for res in tokens { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/scanner.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 | /             self.src
[INFO] [stderr] 57 | |                 .next()
[INFO] [stderr] 58 | |                 .or(Some('\0'))
[INFO] [stderr] 59 | |                 .map(|c| self.peeks.push_back(c));
[INFO] [stderr]    | |_________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 56 |             if let Some(c) = self.src
[INFO] [stderr] 57 |                 .next()
[INFO] [stderr] 58 |                 .or(Some('\0')) { self.peeks.push_back(c) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/scanner.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 | /         match self.match_advance(c) {
[INFO] [stderr] 95 | |             true => self.static_token(m),
[INFO] [stderr] 96 | |             false => self.static_token(u),
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.match_advance(c) { self.static_token(m) } else { self.static_token(u) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:49:27
[INFO] [stderr]    |
[INFO] [stderr] 49 |     while let Some(res) = tokens.next() {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `for res in tokens { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.89s
[INFO] running `"docker" "inspect" "2a4c289a70a89e081823d5ce7e7cc5fb8a9d1ea61d10de2662f641c8d822cc23"`
[INFO] running `"docker" "rm" "-f" "2a4c289a70a89e081823d5ce7e7cc5fb8a9d1ea61d10de2662f641c8d822cc23"`
[INFO] [stdout] 2a4c289a70a89e081823d5ce7e7cc5fb8a9d1ea61d10de2662f641c8d822cc23