[INFO] updating cached repository xanxys/octree-art [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xanxys/octree-art [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xanxys/octree-art" "work/ex/clippy-test-run/sources/stable/gh/xanxys/octree-art"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xanxys/octree-art'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xanxys/octree-art" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xanxys/octree-art"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xanxys/octree-art'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 156c094015ffa06f7d08cff1ae74abde7c4c549c [INFO] sha for GitHub repo xanxys/octree-art: 156c094015ffa06f7d08cff1ae74abde7c4c549c [INFO] validating manifest of xanxys/octree-art on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xanxys/octree-art on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xanxys/octree-art [INFO] finished frobbing xanxys/octree-art [INFO] frobbed toml for xanxys/octree-art written to work/ex/clippy-test-run/sources/stable/gh/xanxys/octree-art/Cargo.toml [INFO] started frobbing xanxys/octree-art [INFO] finished frobbing xanxys/octree-art [INFO] frobbed toml for xanxys/octree-art written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xanxys/octree-art/Cargo.toml [INFO] crate xanxys/octree-art has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xanxys/octree-art against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xanxys/octree-art:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07bfc643f6ba859dc5202f3d2aa91f7781f0dc9ed1dab3e0f654834cde214afd [INFO] running `"docker" "start" "-a" "07bfc643f6ba859dc5202f3d2aa91f7781f0dc9ed1dab3e0f654834cde214afd"` [INFO] [stderr] Compiling rustc-demangle v0.1.5 [INFO] [stderr] Compiling serde v1.0.21 [INFO] [stderr] Compiling pulldown-cmark v0.1.0 [INFO] [stderr] Checking linked-hash-map v0.5.0 [INFO] [stderr] Compiling peg v0.5.4 [INFO] [stderr] Checking stl_io v0.3.4 [INFO] [stderr] Compiling tempdir v0.3.5 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling serde_derive_internals v0.17.0 [INFO] [stderr] Compiling backtrace v0.3.4 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.21 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.6 [INFO] [stderr] Compiling cargo_metadata v0.3.2 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Compiling ply-rs v0.1.1 [INFO] [stderr] Checking octree-art v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> generate.rs:69:32 [INFO] [stderr] | [INFO] [stderr] 69 | &Octree::Leaf(fill) => if fill { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 70 | | if fill { [INFO] [stderr] 71 | | column_r *= 1.5; [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | &Octree::Leaf(fill) => if fill && fill { [INFO] [stderr] 70 | column_r *= 1.5; [INFO] [stderr] 71 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> generate.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 160 | | if relevant_tris.len() == 0 { [INFO] [stderr] 161 | | Octree::Leaf(false) [INFO] [stderr] 162 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if relevant_tris.len() == 0 { [INFO] [stderr] 160 | Octree::Leaf(false) [INFO] [stderr] 161 | } else { [INFO] [stderr] 162 | let children_cubes = divide_cube(cube); [INFO] [stderr] 163 | let mut children_cells: [Octree; 8] = Default::default(); [INFO] [stderr] 164 | for ix in 0..8 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> generate.rs:69:32 [INFO] [stderr] | [INFO] [stderr] 69 | &Octree::Leaf(fill) => if fill { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 70 | | if fill { [INFO] [stderr] 71 | | column_r *= 1.5; [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | &Octree::Leaf(fill) => if fill && fill { [INFO] [stderr] 70 | column_r *= 1.5; [INFO] [stderr] 71 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> generate.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 160 | | if relevant_tris.len() == 0 { [INFO] [stderr] 161 | | Octree::Leaf(false) [INFO] [stderr] 162 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 170 | | } [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if relevant_tris.len() == 0 { [INFO] [stderr] 160 | Octree::Leaf(false) [INFO] [stderr] 161 | } else { [INFO] [stderr] 162 | let children_cubes = divide_cube(cube); [INFO] [stderr] 163 | let mut children_cells: [Octree; 8] = Default::default(); [INFO] [stderr] 164 | for ix in 0..8 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: function is never used: `min` [INFO] [stderr] --> generate.rs:224:1 [INFO] [stderr] | [INFO] [stderr] 224 | fn min(a: f64, b: f64, c: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> input.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match f.read_to_string(&mut contents) { [INFO] [stderr] 15 | | Err(e) => return Err(e), [INFO] [stderr] 16 | | _ => {}, [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = f.read_to_string(&mut contents) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let ref vertices = &ply.payload["vertex"]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let vertices = &(&ply.payload["vertex"]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | for ref face in &ply.payload["face"] { [INFO] [stderr] | ^^^^^^^^ -------------------- help: try: `let face = &&ply.payload["face"];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let ref ixs = match &face["vertex_indices"] { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | let ixs = &(match &face["vertex_indices"] { [INFO] [stderr] 30 | &Property::ListInt(ref ixs) => ixs, [INFO] [stderr] 31 | _ => continue, [INFO] [stderr] 32 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> input.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let ref ixs = match &face["vertex_indices"] { [INFO] [stderr] | _______________________^ [INFO] [stderr] 30 | | &Property::ListInt(ref ixs) => ixs, [INFO] [stderr] 31 | | _ => continue, [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | let ref ixs = match face["vertex_indices"] { [INFO] [stderr] 30 | Property::ListInt(ref ixs) => ixs, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let ref vertex = &vertices[ixs[i] as usize]; [INFO] [stderr] | ----^^^^^^^^^^------------------------------ help: try: `let vertex = &(&vertices[ixs[i] as usize]);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> input.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | vs[i] = Vector3::new(*x as f64, *y as f64, *z as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> input.rs:39:53 [INFO] [stderr] | [INFO] [stderr] 39 | vs[i] = Vector3::new(*x as f64, *y as f64, *z as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> input.rs:39:64 [INFO] [stderr] | [INFO] [stderr] 39 | vs[i] = Vector3::new(*x as f64, *y as f64, *z as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> input.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | Ok(v) if word.contains("e") => format!("{:.}", v), [INFO] [stderr] | ^^^ help: try using a char instead: `'e'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> output.rs:9:36 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn write_stl(path: &str, mesh: &Vec<[V3; 3]>) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[[V3; 3]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | for p in tri.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> generate.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | let Cube(org, sz) = cube.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `cube` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> generate.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match octree { [INFO] [stderr] 63 | | &Octree::Br(ref children) => { [INFO] [stderr] 64 | | let cc = divide_cube(cube); [INFO] [stderr] 65 | | for i in 0..8 { [INFO] [stderr] ... | [INFO] [stderr] 73 | | }, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *octree { [INFO] [stderr] 63 | Octree::Br(ref children) => { [INFO] [stderr] 64 | let cc = divide_cube(cube); [INFO] [stderr] 65 | for i in 0..8 { [INFO] [stderr] 66 | gen_printable_aux(cc[i], &(*children)[i], level + 1, accum) [INFO] [stderr] 67 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cc` [INFO] [stderr] --> generate.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 65 | for (i, ) in cc.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | for r in [SquareMatrix::identity(), dr, dr * dr].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | for z in [0.0, sz.z].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | for x in [0.0, sz.x].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | for y in [0.0, sz.y].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> generate.rs:152:29 [INFO] [stderr] | [INFO] [stderr] 152 | fn divide(cube: Cube, tris: &Vec, remaining_level: u32) -> Octree { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[TriN]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> generate.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | .map(|&tri| tri.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `tri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> generate.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | Octree::Leaf(relevant_tris.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!relevant_tris.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> generate.rs:160:12 [INFO] [stderr] | [INFO] [stderr] 160 | if relevant_tris.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `relevant_tris.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cubes` [INFO] [stderr] --> generate.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 177 | for (i, ) in cubes.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match output::write_stl(matches.value_of("OUTPUT").unwrap(), &gen_mesh) { [INFO] [stderr] 40 | | Err(e) => panic!("Couldn't write STL:\n{}", e), [INFO] [stderr] 41 | | _ => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = output::write_stl(matches.value_of("OUTPUT").unwrap(), &gen_mesh) { panic!("Couldn't write STL:\n{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> main.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | fn print_mesh_stat(mesh: &Vec<[Vector3; 3]>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[[Vector3; 3]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `octree-art`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `min` [INFO] [stderr] --> generate.rs:224:1 [INFO] [stderr] | [INFO] [stderr] 224 | fn min(a: f64, b: f64, c: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> input.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match f.read_to_string(&mut contents) { [INFO] [stderr] 15 | | Err(e) => return Err(e), [INFO] [stderr] 16 | | _ => {}, [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = f.read_to_string(&mut contents) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let ref vertices = &ply.payload["vertex"]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let vertices = &(&ply.payload["vertex"]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | for ref face in &ply.payload["face"] { [INFO] [stderr] | ^^^^^^^^ -------------------- help: try: `let face = &&ply.payload["face"];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let ref ixs = match &face["vertex_indices"] { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | let ixs = &(match &face["vertex_indices"] { [INFO] [stderr] 30 | &Property::ListInt(ref ixs) => ixs, [INFO] [stderr] 31 | _ => continue, [INFO] [stderr] 32 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> input.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let ref ixs = match &face["vertex_indices"] { [INFO] [stderr] | _______________________^ [INFO] [stderr] 30 | | &Property::ListInt(ref ixs) => ixs, [INFO] [stderr] 31 | | _ => continue, [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | let ref ixs = match face["vertex_indices"] { [INFO] [stderr] 30 | Property::ListInt(ref ixs) => ixs, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> input.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let ref vertex = &vertices[ixs[i] as usize]; [INFO] [stderr] | ----^^^^^^^^^^------------------------------ help: try: `let vertex = &(&vertices[ixs[i] as usize]);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> input.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | vs[i] = Vector3::new(*x as f64, *y as f64, *z as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> input.rs:39:53 [INFO] [stderr] | [INFO] [stderr] 39 | vs[i] = Vector3::new(*x as f64, *y as f64, *z as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> input.rs:39:64 [INFO] [stderr] | [INFO] [stderr] 39 | vs[i] = Vector3::new(*x as f64, *y as f64, *z as f64); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> input.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | Ok(v) if word.contains("e") => format!("{:.}", v), [INFO] [stderr] | ^^^ help: try using a char instead: `'e'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> output.rs:9:36 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn write_stl(path: &str, mesh: &Vec<[V3; 3]>) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[[V3; 3]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | for p in tri.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> generate.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | let Cube(org, sz) = cube.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `cube` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> generate.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match octree { [INFO] [stderr] 63 | | &Octree::Br(ref children) => { [INFO] [stderr] 64 | | let cc = divide_cube(cube); [INFO] [stderr] 65 | | for i in 0..8 { [INFO] [stderr] ... | [INFO] [stderr] 73 | | }, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *octree { [INFO] [stderr] 63 | Octree::Br(ref children) => { [INFO] [stderr] 64 | let cc = divide_cube(cube); [INFO] [stderr] 65 | for i in 0..8 { [INFO] [stderr] 66 | gen_printable_aux(cc[i], &(*children)[i], level + 1, accum) [INFO] [stderr] 67 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cc` [INFO] [stderr] --> generate.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 65 | for (i, ) in cc.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | for r in [SquareMatrix::identity(), dr, dr * dr].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | for z in [0.0, sz.z].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | for x in [0.0, sz.x].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> generate.rs:122:26 [INFO] [stderr] | [INFO] [stderr] 122 | for y in [0.0, sz.y].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> generate.rs:152:29 [INFO] [stderr] | [INFO] [stderr] 152 | fn divide(cube: Cube, tris: &Vec, remaining_level: u32) -> Octree { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[TriN]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> generate.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | .map(|&tri| tri.clone()) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `tri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> generate.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | Octree::Leaf(relevant_tris.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!relevant_tris.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> generate.rs:160:12 [INFO] [stderr] | [INFO] [stderr] 160 | if relevant_tris.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `relevant_tris.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cubes` [INFO] [stderr] --> generate.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 177 | for (i, ) in cubes.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match output::write_stl(matches.value_of("OUTPUT").unwrap(), &gen_mesh) { [INFO] [stderr] 40 | | Err(e) => panic!("Couldn't write STL:\n{}", e), [INFO] [stderr] 41 | | _ => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = output::write_stl(matches.value_of("OUTPUT").unwrap(), &gen_mesh) { panic!("Couldn't write STL:\n{}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> main.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | fn print_mesh_stat(mesh: &Vec<[Vector3; 3]>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[[Vector3; 3]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `octree-art`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "07bfc643f6ba859dc5202f3d2aa91f7781f0dc9ed1dab3e0f654834cde214afd"` [INFO] running `"docker" "rm" "-f" "07bfc643f6ba859dc5202f3d2aa91f7781f0dc9ed1dab3e0f654834cde214afd"` [INFO] [stdout] 07bfc643f6ba859dc5202f3d2aa91f7781f0dc9ed1dab3e0f654834cde214afd