[INFO] updating cached repository xalley/libcjit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xalley/libcjit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xalley/libcjit" "work/ex/clippy-test-run/sources/stable/gh/xalley/libcjit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xalley/libcjit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xalley/libcjit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xalley/libcjit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xalley/libcjit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ac7cdc437ce27bf4ecd33328aecd31895ccd326 [INFO] sha for GitHub repo xalley/libcjit: 8ac7cdc437ce27bf4ecd33328aecd31895ccd326 [INFO] validating manifest of xalley/libcjit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xalley/libcjit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xalley/libcjit [INFO] finished frobbing xalley/libcjit [INFO] frobbed toml for xalley/libcjit written to work/ex/clippy-test-run/sources/stable/gh/xalley/libcjit/Cargo.toml [INFO] started frobbing xalley/libcjit [INFO] finished frobbing xalley/libcjit [INFO] frobbed toml for xalley/libcjit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xalley/libcjit/Cargo.toml [INFO] crate xalley/libcjit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xalley/libcjit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xalley/libcjit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 153768ce0103dda16c05f6481cd1ac7588ecf852d510ac4bb278f6df6f1a8ac3 [INFO] running `"docker" "start" "-a" "153768ce0103dda16c05f6481cd1ac7588ecf852d510ac4bb278f6df6f1a8ac3"` [INFO] [stderr] Checking cjit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scanner/mod.rs:685:54 [INFO] [stderr] | [INFO] [stderr] 685 | ((5, 16), "0xABCDEF", token::Data::I32(0xABCDEF)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00AB_CDEF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scanner/mod.rs:773:58 [INFO] [stderr] | [INFO] [stderr] 773 | ((2, 22), "'中文'", token::Data::CharLtl(0xd6d0cec4)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd6d0_cec4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scanner/mod.rs:818:54 [INFO] [stderr] | [INFO] [stderr] 818 | ((2, 19), "L'aa'", token::Data::LCharLtl(0x00610061)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0061_0061` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_str` [INFO] [stderr] --> src/input.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn from_str(s: &str) -> Input { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/scanner/mod.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn new(input: Input) -> Scanner { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/scanner/mod.rs:52:60 [INFO] [stderr] | [INFO] [stderr] 52 | bin.iter().fold(self, |s, &x| s * Just(256) + Just(x as u32)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/scanner/mod.rs:110:43 [INFO] [stderr] | [INFO] [stderr] 110 | a.checked_add(b).map_or(Overflow, |v| Just(v)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Just` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/scanner/mod.rs:128:43 [INFO] [stderr] | [INFO] [stderr] 128 | a.checked_mul(b).map_or(Overflow, |v| Just(v)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Just` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/scanner/mod.rs:52:60 [INFO] [stderr] | [INFO] [stderr] 52 | bin.iter().fold(self, |s, &x| s * Just(256) + Just(x as u32)) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/scanner/mod.rs:110:43 [INFO] [stderr] | [INFO] [stderr] 110 | a.checked_add(b).map_or(Overflow, |v| Just(v)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Just` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/scanner/mod.rs:128:43 [INFO] [stderr] | [INFO] [stderr] 128 | a.checked_mul(b).map_or(Overflow, |v| Just(v)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Just` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.66s [INFO] running `"docker" "inspect" "153768ce0103dda16c05f6481cd1ac7588ecf852d510ac4bb278f6df6f1a8ac3"` [INFO] running `"docker" "rm" "-f" "153768ce0103dda16c05f6481cd1ac7588ecf852d510ac4bb278f6df6f1a8ac3"` [INFO] [stdout] 153768ce0103dda16c05f6481cd1ac7588ecf852d510ac4bb278f6df6f1a8ac3