[INFO] updating cached repository xTibor/triduty-wave [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/xTibor/triduty-wave [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/xTibor/triduty-wave" "work/ex/clippy-test-run/sources/stable/gh/xTibor/triduty-wave"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/xTibor/triduty-wave'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/xTibor/triduty-wave" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xTibor/triduty-wave"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xTibor/triduty-wave'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f44fdd4264a93b6dc3c3471d75518d6f4450f6b [INFO] sha for GitHub repo xTibor/triduty-wave: 3f44fdd4264a93b6dc3c3471d75518d6f4450f6b [INFO] validating manifest of xTibor/triduty-wave on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of xTibor/triduty-wave on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing xTibor/triduty-wave [INFO] finished frobbing xTibor/triduty-wave [INFO] frobbed toml for xTibor/triduty-wave written to work/ex/clippy-test-run/sources/stable/gh/xTibor/triduty-wave/Cargo.toml [INFO] started frobbing xTibor/triduty-wave [INFO] finished frobbing xTibor/triduty-wave [INFO] frobbed toml for xTibor/triduty-wave written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/xTibor/triduty-wave/Cargo.toml [INFO] crate xTibor/triduty-wave has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting xTibor/triduty-wave against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/xTibor/triduty-wave:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aeb596a7e3aa60f4f65b3c38baaafdc5da1f7e2877a97e58cc187740a1dfbfff [INFO] running `"docker" "start" "-a" "aeb596a7e3aa60f4f65b3c38baaafdc5da1f7e2877a97e58cc187740a1dfbfff"` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling minifb v0.11.1 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking triduty-wave v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | *i = 0xFF000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:96:46 [INFO] [stderr] | [INFO] [stderr] 96 | buffer[y as usize * WIDTH + x] = 0xFFFF0000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | *i = 0xFF000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:96:46 [INFO] [stderr] | [INFO] [stderr] 96 | buffer[y as usize * WIDTH + x] = 0xFFFF0000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let mut tri = Arc::new(Mutex::new(0.5)); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut duty = Arc::new(Mutex::new(0.5)); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let mut pitch = Arc::new(Mutex::new(440.0)); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let mut tri = Arc::new(Mutex::new(0.5)); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut duty = Arc::new(Mutex::new(0.5)); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let mut pitch = Arc::new(Mutex::new(440.0)); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:55:67 [INFO] [stderr] | [INFO] [stderr] 55 | let value = ((next_value() * 0.5 + 0.5) * std::u16::MAX as f32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:55:67 [INFO] [stderr] | [INFO] [stderr] 55 | let value = ((next_value() * 0.5 + 0.5) * std::u16::MAX as f32) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:53 [INFO] [stderr] | [INFO] [stderr] 63 | let value = (next_value() * std::i16::MAX as f32) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(std::i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:53 [INFO] [stderr] | [INFO] [stderr] 63 | let value = (next_value() * std::i16::MAX as f32) as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(std::i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | window.get_mouse_pos(MouseMode::Discard).map(|mouse| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 102 | || *duty.lock().unwrap() = mouse.0 as f32 / WIDTH as f32; [INFO] [stderr] 103 | || *tri.lock().unwrap() = mouse.1 as f32 / HEIGHT as f32; [INFO] [stderr] 104 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(mouse) = window.get_mouse_pos(MouseMode::Discard) { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | window.get_mouse_pos(MouseMode::Discard).map(|mouse| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 102 | || *duty.lock().unwrap() = mouse.0 as f32 / WIDTH as f32; [INFO] [stderr] 103 | || *tri.lock().unwrap() = mouse.1 as f32 / HEIGHT as f32; [INFO] [stderr] 104 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(mouse) = window.get_mouse_pos(MouseMode::Discard) { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | window.get_scroll_wheel().map(|scroll| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 107 | || *pitch.lock().unwrap() += scroll.1; [INFO] [stderr] 108 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(scroll) = window.get_scroll_wheel() { *pitch.lock().unwrap() += scroll.1; }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | window.get_scroll_wheel().map(|scroll| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 107 | || *pitch.lock().unwrap() += scroll.1; [INFO] [stderr] 108 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(scroll) = window.get_scroll_wheel() { *pitch.lock().unwrap() += scroll.1; }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.34s [INFO] running `"docker" "inspect" "aeb596a7e3aa60f4f65b3c38baaafdc5da1f7e2877a97e58cc187740a1dfbfff"` [INFO] running `"docker" "rm" "-f" "aeb596a7e3aa60f4f65b3c38baaafdc5da1f7e2877a97e58cc187740a1dfbfff"` [INFO] [stdout] aeb596a7e3aa60f4f65b3c38baaafdc5da1f7e2877a97e58cc187740a1dfbfff